Skip to content

add chromepolicy to enabled apis for CI + terraform fmt#17179

Merged
BBBmau merged 1 commit into
GoogleCloudPlatform:mainfrom
keeleysam:samuel/chromepolicy-ci
Apr 17, 2026
Merged

add chromepolicy to enabled apis for CI + terraform fmt#17179
BBBmau merged 1 commit into
GoogleCloudPlatform:mainfrom
keeleysam:samuel/chromepolicy-ci

Conversation

@keeleysam

@keeleysam keeleysam commented Apr 17, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

this is a prerequistie for #17106 per #17106 (comment)

this change needs to land before that PR can be properly reviewed, so the CI updates

cc @BBBmau

@modular-magician modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Apr 17, 2026
@github-actions github-actions Bot requested a review from roaks3 April 17, 2026 19:18
@github-actions

github-actions Bot commented Apr 17, 2026

Copy link
Copy Markdown

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@roaks3, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@keeleysam keeleysam mentioned this pull request Apr 17, 2026
Open
BBBmau
BBBmau requested changes Apr 17, 2026
View reviewed changes

@BBBmau BBBmau left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: remove the extra white space that were added on provider = google-beta lines

@keeleysam

keeleysam commented Apr 17, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

the white space is added intentionally - so this file passes terraform fmt without changes

@keeleysam keeleysam requested a review from BBBmau April 17, 2026 20:18
@modular-magician modular-magician removed the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Apr 17, 2026
@modular-magician

modular-magician commented Apr 17, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR hasn't generated any diffs, but I'll let you know if a future commit does.

@BBBmau BBBmau added this pull request to the merge queue Apr 17, 2026
Merged via the queue into GoogleCloudPlatform:main with commit 23eeea9 Apr 17, 2026
24 of 26 checks passed
@modular-magician modular-magician mentioned this pull request Apr 17, 2026
Merged
ChuAmberZhang pushed a commit to ChuAmberZhang/magic-modules that referenced this pull request Apr 29, 2026
@keeleysam @ChuAmberZhang
add chromepolicy to enabled apis for CI + terraform fmt (GoogleCloudP…
5e69681 
…latform#17179)
gitika-yadav pushed a commit to gitika-yadav/magic-modules that referenced this pull request May 7, 2026
@keeleysam @gitika-yadav
add chromepolicy to enabled apis for CI + terraform fmt (GoogleCloudP…
9e946d3 
…latform#17179)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BBBmau BBBmau BBBmau approved these changes
@roaks3 roaks3 Awaiting requested review from roaks3

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@keeleysam @modular-magician @BBBmau