apigee: fix TestAccApigeeOrganization_apigeeOrganizationCloudBasicDataResidencyTestExample#16938
Closed
xuchenma wants to merge 1 commit into
Closed
apigee: fix TestAccApigeeOrganization_apigeeOrganizationCloudBasicDataResidencyTestExample#16938xuchenma wants to merge 1 commit into
xuchenma wants to merge 1 commit into
Conversation
…aResidencyTestExample
|
Googlers: For automatic test runs see go/terraform-auto-test-runs. @roaks3, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
Contributor
Author
|
This is not needed, #16940 fixes this issue. |
Contributor
Author
|
Closing as obsolete. The underlying failure (hashicorp/terraform-provider-google#22528) was fixed by the merged #14003, and the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes hashicorp/terraform-provider-google#22528
The
TestAccApigeeOrganization_apigeeOrganizationCloudBasicDataResidencyTestExampletest was flaky because Apigee Organization deletion is asynchronous. TheCheckDestroyfunction ran immediately afterterraform destroycompleted, but the org could still be inDELETINGstate, causing false "resource still exists" failures.This PR applies the same fix as the sibling PR for b/463028638: override
CheckDestroywith a custom polling implementation that treats both HTTP 404 andstate == "DELETING"as successful deletion, polling up to 10 minutes.Changes:
test_check_destroytommv1/products/apigee/Organization.yamlmmv1/templates/terraform/custom_check_destroy/apigee_organization.go.tmplwith async-aware polling logicTest evidence