Skip to content

chore: add customHostConfig to instance#16723

Merged
roaks3 merged 2 commits into
GoogleCloudPlatform:mainfrom
ericzzzzzzz:customhostconfig
Mar 18, 2026
Merged

chore: add customHostConfig to instance#16723
roaks3 merged 2 commits into
GoogleCloudPlatform:mainfrom
ericzzzzzzz:customhostconfig

Conversation

@ericzzzzzzz

@ericzzzzzzz ericzzzzzzz commented Mar 16, 2026

Copy link
Copy Markdown
Contributor

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

securesourcemanager: added `private_config.custom_host_config` field to `google_secure_source_manager_instance` resource (beta)

@github-actions github-actions Bot requested a review from roaks3 March 16, 2026 14:36
@github-actions

Copy link
Copy Markdown

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@roaks3, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 382 insertions(+))
google-beta provider: Diff ( 4 files changed, 382 insertions(+))
terraform-google-conversion: Diff ( 5 files changed, 236 insertions(+))
Open in Cloud Shell: Diff ( 4 files changed, 187 insertions(+))

@modular-magician

Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 23
Passed tests: 22
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages
  • securesourcemanager

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccSecureSourceManagerInstance_secureSourceManagerInstancePrivateCustomHostExample

Get to know how VCR tests work

@modular-magician

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 382 insertions(+))
google-beta provider: Diff ( 4 files changed, 382 insertions(+))
terraform-google-conversion: Diff ( 5 files changed, 236 insertions(+))
Open in Cloud Shell: Diff ( 4 files changed, 187 insertions(+))

@modular-magician

Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 23
Passed tests: 22
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages
  • securesourcemanager

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccSecureSourceManagerInstance_secureSourceManagerInstancePrivateCustomHostExample

Get to know how VCR tests work

@modular-magician

Copy link
Copy Markdown
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccSecureSourceManagerInstance_secureSourceManagerInstancePrivateCustomHostExample [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🟢 All tests passed!

View the build log or the debug log for each test

@modular-magician

Copy link
Copy Markdown
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccSecureSourceManagerInstance_secureSourceManagerInstancePrivateCustomHostExample [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🟢 All tests passed!

View the build log or the debug log for each test

@zli82016

Copy link
Copy Markdown
Member

Failed terraform-google-conversion-test-integration is unrelated and will be fixed in #16729

@roaks3 roaks3 added this pull request to the merge queue Mar 18, 2026
Merged via the queue into GoogleCloudPlatform:main with commit 24996d4 Mar 18, 2026
23 of 30 checks passed
carreter pushed a commit to carreter/magic-modules that referenced this pull request Apr 2, 2026
ChuAmberZhang pushed a commit to ChuAmberZhang/magic-modules that referenced this pull request Apr 29, 2026
gitika-yadav pushed a commit to gitika-yadav/magic-modules that referenced this pull request May 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants