Skip to content

deletion policy generation saasservicemgmt-storagetransfer#16633

Merged
NickElliot merged 2 commits into
GoogleCloudPlatform:FEATURE-BRANCH-universal-deletion-policyfrom
NickElliot:dpolicygens
Mar 10, 2026
Merged

deletion policy generation saasservicemgmt-storagetransfer#16633
NickElliot merged 2 commits into
GoogleCloudPlatform:FEATURE-BRANCH-universal-deletion-policyfrom
NickElliot:dpolicygens

Conversation

@NickElliot

Copy link
Copy Markdown
Contributor

we have a lot of S products

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.


@modular-magician

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 174 files changed, 2503 insertions(+))
google-beta provider: Diff ( 192 files changed, 2841 insertions(+))

@modular-magician

Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 561
Passed tests: 504
Skipped tests: 53
Affected tests: 4

Click here to see the affected service packages
  • secretmanager
  • siteverification
  • storagetransfer
  • spanner
  • saasruntime
  • securitycenter
  • securityscanner
  • servicedirectory
  • sourcerepo
  • securesourcemanager
  • securityposture
  • serviceusage
  • storage
  • storagebatchoperations
  • storageinsights
  • secretmanagerregional
  • securitycentermanagement
  • securitycenterv2
  • sql

Action taken

Found 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccDataSourceSecretManagerRegionalRegionalSecrets_basic
  • TestAccDataSourceSecretManagerRegionalRegionalSecrets_filter
  • TestAccDataSourceSecretManagerSecrets_basic
  • TestAccDataSourceSecretManagerSecrets_filter

Get to know how VCR tests work

@modular-magician

Copy link
Copy Markdown
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccDataSourceSecretManagerRegionalRegionalSecrets_basic [Error message] [Debug log]
TestAccDataSourceSecretManagerRegionalRegionalSecrets_filter [Error message] [Debug log]
TestAccDataSourceSecretManagerSecrets_basic [Error message] [Debug log]
TestAccDataSourceSecretManagerSecrets_filter [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@NickElliot NickElliot marked this pull request as ready for review March 9, 2026 19:08
@NickElliot NickElliot requested a review from c2thorn March 9, 2026 19:09
@modular-magician

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 176 files changed, 2515 insertions(+), 8 deletions(-))
google-beta provider: Diff ( 194 files changed, 2853 insertions(+), 8 deletions(-))

@modular-magician

Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 561
Passed tests: 508
Skipped tests: 53
Affected tests: 0

Click here to see the affected service packages
  • storagetransfer
  • spanner
  • secretmanagerregional
  • securesourcemanager
  • securitycentermanagement
  • securitycenterv2
  • securityposture
  • securityscanner
  • storageinsights
  • saasruntime
  • securitycenter
  • servicedirectory
  • sourcerepo
  • sql
  • siteverification
  • secretmanager
  • serviceusage
  • storage
  • storagebatchoperations

🟢 All tests passed!

View the build log

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants