FEAT: add support to target_type and target_forwarding_rules on. google_compute_region_network_firewall_policy_rule

[victorsantos-cit]

Hello Folks,
this PR is to create a support to target_type and target_forwarding_rules on google_compute_region_network_firewall_policy_rule resource

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

compute: added `target_type` and `target_forwarding_rules` on `google_compute_region_network_firewall_policy_rule` resource

[github-actions]

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@ScottSuarez, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 133 insertions(+))
google-beta provider: Diff ( 4 files changed, 202 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 20 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_compute_region_network_firewall_policy_rule (15 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_region_network_firewall_policy_rule" "primary" {
  target_forwarding_rules = # value needed
}

[victorsantos-cit]

hey @scott-mitchell , with needed, i can update a test file to this field

[modular-magician]

Tests analytics

Total tests: 1377
Passed tests: 1284
Skipped tests: 90
Affected tests: 3

Click here to see the affected service packages

• compute

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccComputeRegionNetworkFirewallPolicyRule_firewallPolicyRuleTargetTypeInternalManagedLbInstanceRegionalExample
• TestAccComputeRegionNetworkFirewallPolicyRule_regionNetworkFirewallPolicyRuleNetworkContextEgressExample
• TestAccComputeRegionNetworkFirewallPolicyRule_regionNetworkFirewallPolicyRuleNetworkContextIngressExample

Get to know how VCR tests work

[modular-magician]

🟢 Tests passed during RECORDING mode:
TestAccComputeRegionNetworkFirewallPolicyRule_firewallPolicyRuleTargetTypeInternalManagedLbInstanceRegionalExample [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

---

🔴 Tests failed during RECORDING mode:
TestAccComputeRegionNetworkFirewallPolicyRule_regionNetworkFirewallPolicyRuleNetworkContextEgressExample [Error message] [Debug log]
TestAccComputeRegionNetworkFirewallPolicyRule_regionNetworkFirewallPolicyRuleNetworkContextIngressExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[victorsantos-cit]

hey @ScottSuarez this failed test, have something about if my implementation ?

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 134 insertions(+))
google-beta provider: Diff ( 4 files changed, 203 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 20 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_compute_region_network_firewall_policy_rule (15 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_region_network_firewall_policy_rule" "primary" {
  target_forwarding_rules = # value needed
}

[modular-magician]

Tests analytics

Total tests: 1380
Passed tests: 1290
Skipped tests: 90
Affected tests: 0

Click here to see the affected service packages

• compute

🟢 All tests passed!

View the build log

[victorsantos-cit]

@ScottSuarez if you need more to that , please send me , i asking because, this feature, is important