Promote Tags to GA for VPN

[NandiniAgrawal15]

VPN tagging at creation Hz - b/374261939
Release Note Template for Downstream PRs (will be copied)

compute: added `params` field to `google_compute_vpn_tunnel` resource (GA)

compute: added `params` field to `google_compute_vpn_gateway` resource (GA)

compute: added `params` field to `google_compute_external_vpn_gateway` resource (GA)

compute: added `params` field to `google_compute_ha_vpn_gateway` resource (GA)

[NandiniAgrawal15]

Local Testing: VPN-Gateway

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 19 files changed, 453 insertions(+), 14 deletions(-))
google-beta provider: Diff ( 7 files changed, 16 insertions(+), 21 deletions(-))
terraform-google-conversion: Diff ( 8 files changed, 160 insertions(+))

[modular-magician]

Non-exercised tests

🔴 Tests were added that are GA-only additions and require manual runs:

• TestAccComputeExternalVPNGateway_resourceManagerTags
• TestAccComputeHaVpnGateway_resourceManagerTags
• TestAccComputeVpnTunnel_resourceManagerTags

Tests analytics

Total tests: 1372
Passed tests: 1282
Skipped tests: 90
Affected tests: 0

Click here to see the affected service packages

• compute

🟢 All tests passed!

View the build log

[github-actions]

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@melinath, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[melinath]

Manual GA test run (you won't have access to this): https://hashicorp.teamcity.com/buildConfiguration/TerraformProviders_GoogleCloud_GOOGLE_MMUPSTREAMTESTS_GOOGLE_PACKAGE_COMPUTE/623515

[melinath]

It looks like the vpn gateway resource is missing a test for resource_manager_tags? Could you add one? A new "full" example that also sets optional fields should be sufficient. (The "basic" example should just cover the required fields.)

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 19 files changed, 453 insertions(+), 14 deletions(-))
google-beta provider: Diff ( 7 files changed, 16 insertions(+), 21 deletions(-))
terraform-google-conversion: Diff ( 8 files changed, 160 insertions(+))

[modular-magician]

Non-exercised tests

🔴 Tests were added that are GA-only additions and require manual runs:

• TestAccComputeExternalVPNGateway_resourceManagerTags
• TestAccComputeHaVpnGateway_resourceManagerTags
• TestAccComputeVpnTunnel_resourceManagerTags

Tests analytics

Total tests: 1376
Passed tests: 1286
Skipped tests: 90
Affected tests: 0

Click here to see the affected service packages

• compute

🟢 All tests passed!

View the build log

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 19 files changed, 648 insertions(+), 14 deletions(-))
google-beta provider: Diff ( 8 files changed, 211 insertions(+), 21 deletions(-))
terraform-google-conversion: Diff ( 8 files changed, 160 insertions(+))
Open in Cloud Shell: Diff ( 4 files changed, 177 insertions(+))

[modular-magician]

Non-exercised tests

🔴 Tests were added that are GA-only additions and require manual runs:

• TestAccComputeExternalVPNGateway_resourceManagerTags
• TestAccComputeHaVpnGateway_resourceManagerTags
• TestAccComputeVpnTunnel_resourceManagerTags

Tests analytics

Total tests: 1377
Passed tests: 1286
Skipped tests: 90
Affected tests: 1

Click here to see the affected service packages

• compute

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccComputeVpnGateway_targetVpnGatewayTagsExample

Get to know how VCR tests work

[modular-magician]

🟢 Tests passed during RECORDING mode:
TestAccComputeVpnGateway_targetVpnGatewayTagsExample [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

---

🟢 All tests passed!

View the build log or the debug log for each test