Add support for dataproc cluster type#16605
Conversation
uncommenting the subnet config
This change introduces the instance_flexibility_policy block to the master_config and worker_config sections of the google_dataproc_cluster resource, allowing users to specify a ranked list of machine types.
…adding missed file
|
Googlers: For automatic test runs see go/terraform-auto-test-runs. @rileykarson, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_dataproc_cluster" "primary" {
cluster_config {
cluster_tier = # value needed
cluster_type = # value needed
staging_bucket = # value needed
temp_bucket = # value needed
}
}
Missing doc report (experimental)The following resources have fields missing in documents.
|
Tests analyticsTotal tests: 82 Click here to see the affected service packages
Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
| }, | ||
| { | ||
| // Set type to ZERO_SCALE | ||
| Config: testAccDataprocCluster_withClusterType(rnd, subnetworkName, "ZERO_SCALE"), |
There was a problem hiding this comment.
Could you move this to a separate TestAcc entry entirely? Right now this test case will create the resource with the first settings, delete it, and then create the next one, and delete it. By making a separate test case they'll get run in parallel.
There was a problem hiding this comment.
Filed an issue to proceed with merge since this isn't really blocking: hashicorp/terraform-provider-google#26349
rileykarson
left a comment
There was a problem hiding this comment.
LGTM with one test change we should make, but can be done out of band: hashicorp/terraform-provider-google#26349
Release Note Template for Downstream PRs (will be copied)
See Write release notes for guidance.