Skip to content

Add support for dataproc cluster type#16605

Merged
rileykarson merged 13 commits into
GoogleCloudPlatform:mainfrom
sravani-bobbala:main_flex
Mar 5, 2026
Merged

Add support for dataproc cluster type#16605
rileykarson merged 13 commits into
GoogleCloudPlatform:mainfrom
sravani-bobbala:main_flex

Conversation

@sravani-bobbala

@sravani-bobbala sravani-bobbala commented Mar 4, 2026

Copy link
Copy Markdown
Contributor

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

dataproc: added `cluster_type` to `google_dataproc_cluster` resource.

@modular-magician modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Mar 4, 2026
@sravani-bobbala sravani-bobbala marked this pull request as ready for review March 4, 2026 16:13
@github-actions github-actions Bot requested a review from rileykarson March 4, 2026 16:14
@github-actions

github-actions Bot commented Mar 4, 2026

Copy link
Copy Markdown

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@rileykarson, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician modular-magician added service/dataproc and removed awaiting-approval Pull requests that need reviewer's approval to run presubmit tests labels Mar 4, 2026
@modular-magician

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 90 insertions(+))
google-beta provider: Diff ( 3 files changed, 90 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_dataproc_cluster (78 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_dataproc_cluster" "primary" {
  cluster_config {
    cluster_tier   = # value needed
    cluster_type   = # value needed
    staging_bucket = # value needed
    temp_bucket    = # value needed
  }
}

Missing doc report (experimental)

The following resources have fields missing in documents.

  • google_dataproc_cluster
    • Expected Document Path: /website/docs/r/dataproc_cluster.html.markdown
    • Fields: [cluster_config.cluster_type]

@modular-magician

Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 82
Passed tests: 75
Skipped tests: 6
Affected tests: 1

Click here to see the affected service packages
  • dataproc

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccDataprocCluster_withClusterType

Get to know how VCR tests work

@modular-magician

Copy link
Copy Markdown
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccDataprocCluster_withClusterType [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🟢 All tests passed!

View the build log or the debug log for each test

},
{
// Set type to ZERO_SCALE
Config: testAccDataprocCluster_withClusterType(rnd, subnetworkName, "ZERO_SCALE"),

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you move this to a separate TestAcc entry entirely? Right now this test case will create the resource with the first settings, delete it, and then create the next one, and delete it. By making a separate test case they'll get run in parallel.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Filed an issue to proceed with merge since this isn't really blocking: hashicorp/terraform-provider-google#26349

@rileykarson rileykarson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one test change we should make, but can be done out of band: hashicorp/terraform-provider-google#26349

@rileykarson rileykarson added this pull request to the merge queue Mar 5, 2026
Merged via the queue into GoogleCloudPlatform:main with commit 35dc1df Mar 5, 2026
27 checks passed
aditikumarii-google pushed a commit to aditikumarii-google/magic-modules that referenced this pull request Mar 10, 2026
ChuAmberZhang pushed a commit to ChuAmberZhang/magic-modules that referenced this pull request Apr 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants