Skip to content

Replace usage of go-multierror with errors package#16603

Merged
rileykarson merged 1 commit into
GoogleCloudPlatform:mainfrom
rileykarson:remove-multierror
Mar 4, 2026
Merged

Replace usage of go-multierror with errors package#16603
rileykarson merged 1 commit into
GoogleCloudPlatform:mainfrom
rileykarson:remove-multierror

Conversation

@rileykarson

Copy link
Copy Markdown
Member

This is still an indirect dependency through other packages, but gets rid of a direct pin and slightly modernises the relevant code.

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

@modular-magician

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 12 insertions(+), 16 deletions(-))
google-beta provider: Diff ( 3 files changed, 12 insertions(+), 16 deletions(-))

@modular-magician

Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 6118
Passed tests: 5461
Skipped tests: 638
Affected tests: 19

Click here to see the affected service packages

All service packages are affected

Action taken

Found 19 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccDataformConfig_dataformConfigWithKmsKeyExample
  • TestAccDataformConfig_dataformConfigWithoutKmsKeyExample
  • TestAccDataformConfig_update
  • TestAccGKEHubFeatureMembership_gkehubFeatureAcmUpdate
  • TestAccObservabilityProjectSettings_datasource
  • TestAccObservabilityProjectSettings_globalUpdate
  • TestAccObservabilityProjectSettings_observabilityProjectSettingsBasicExample
  • TestAccObservabilityProjectSettings_observabilityProjectSettingsBasicGlobalExample
  • TestAccObservabilityProjectSettings_update
  • TestAccOracleDatabaseCloudExadataInfrastructure_basic
  • TestAccOracleDatabaseCloudVmClusters_basic
  • TestAccOracleDatabaseDbNodes_basic
  • TestAccPubsubSubscription_pubsubSubscriptionPushCloudstorageTextExample
  • TestAccTags__tagKeyIamBinding
  • TestAccTags__tagKeyIamMember
  • TestAccTags__tagKeyIamPolicy
  • TestAccTags__tagValueIamBinding
  • TestAccTags__tagValueIamMember
  • TestAccTags__tagValueIamPolicy

Get to know how VCR tests work

@modular-magician

Copy link
Copy Markdown
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccDataformConfig_dataformConfigWithKmsKeyExample [Debug log]
TestAccDataformConfig_dataformConfigWithoutKmsKeyExample [Debug log]
TestAccDataformConfig_update [Debug log]
TestAccGKEHubFeatureMembership_gkehubFeatureAcmUpdate [Debug log]
TestAccObservabilityProjectSettings_datasource [Debug log]
TestAccObservabilityProjectSettings_globalUpdate [Debug log]
TestAccObservabilityProjectSettings_observabilityProjectSettingsBasicExample [Debug log]
TestAccObservabilityProjectSettings_observabilityProjectSettingsBasicGlobalExample [Debug log]
TestAccObservabilityProjectSettings_update [Debug log]
TestAccPubsubSubscription_pubsubSubscriptionPushCloudstorageTextExample [Debug log]
TestAccTags__tagBindingBasic [Debug log]
TestAccTags__tagBindingNamespaced [Debug log]
TestAccTags__tagKeyBasic [Debug log]
TestAccTags__tagKeyBasicWithAllowedValuesRegex [Debug log]
TestAccTags__tagKeyBasicWithPurposeDataGovernance [Debug log]
TestAccTags__tagKeyBasicWithPurposeGceFirewall [Debug log]
TestAccTags__tagKeyIamBinding [Debug log]
TestAccTags__tagKeyIamMember [Debug log]
TestAccTags__tagKeyIamPolicy [Debug log]
TestAccTags__tagKeyUpdate [Debug log]
TestAccTags__tagKeyUpdateAllowedValuesRegex [Debug log]
TestAccTags__tagValueBasic [Debug log]
TestAccTags__tagValueIamBinding [Debug log]
TestAccTags__tagValueIamMember [Debug log]
TestAccTags__tagValueIamPolicy [Debug log]
TestAccTags__tagValueUpdate [Debug log]
TestAccTags__tagsLocationTagBindingBasic [Debug log]
TestAccTags__tagsLocationTagBindingBasicDynamic [Debug log]
TestAccTags__tagsLocationTagBindingZonal [Debug log]
TestAccTags__tagsLocationTagBindingZonalDynamic [Debug log]
TestAccTags__tagsLocationTagBindingZonalNamespaced [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🔴 Tests failed during RECORDING mode:
TestAccOracleDatabaseCloudExadataInfrastructure_basic [Error message] [Debug log]
TestAccOracleDatabaseCloudVmClusters_basic [Error message] [Debug log]
TestAccOracleDatabaseDbNodes_basic [Error message] [Debug log]
TestAccTags__tagBindingBasicDynamic [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@rileykarson rileykarson requested a review from NickElliot March 4, 2026 17:11
@rileykarson

Copy link
Copy Markdown
Member Author

None of these errors seem related in any way to the change- which affects test code in composer. I think just editing a global file (go.mod) kicked every test and there are numerous deviations kicking around.

@rileykarson rileykarson added this pull request to the merge queue Mar 4, 2026
Merged via the queue into GoogleCloudPlatform:main with commit 45e9cbe Mar 4, 2026
24 of 25 checks passed
@rileykarson rileykarson deleted the remove-multierror branch March 4, 2026 18:07
aditikumarii-google pushed a commit to aditikumarii-google/magic-modules that referenced this pull request Mar 10, 2026
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Apr 7, 2026
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Apr 8, 2026
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Apr 9, 2026
ChuAmberZhang pushed a commit to ChuAmberZhang/magic-modules that referenced this pull request Apr 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants