Skip to content

tgc-revival: Add the option NoOpAncestryManager and HTTPClient to Options#16598

Merged
zli82016 merged 2 commits into
GoogleCloudPlatform:mainfrom
zli82016:tgc-options
Mar 5, 2026
Merged

tgc-revival: Add the option NoOpAncestryManager and HTTPClient to Options#16598
zli82016 merged 2 commits into
GoogleCloudPlatform:mainfrom
zli82016:tgc-options

Conversation

@zli82016

@zli82016 zli82016 commented Mar 3, 2026

Copy link
Copy Markdown
Member

HTTPClient and NoOpAncestryManager exist in g3 TGC v6 and used by the customers. To be sync with g3 TGC v6, add the option NoOpAncestryManager and HTTPClient to Options for TGC to be backward compatible with the legacy TGC.

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.


@modular-magician

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

terraform-google-conversion: Diff ( 5 files changed, 178 insertions(+), 15 deletions(-))

@modular-magician

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

terraform-google-conversion: Diff ( 5 files changed, 173 insertions(+), 11 deletions(-))

@zli82016 zli82016 changed the title Fix TGC unit tests and enable V7 generation tgc-revival: Add the option NoOpAncestryManager and HTTPClient to Options Mar 4, 2026
@zli82016
zli82016 marked this pull request as ready for review March 4, 2026 23:16
@zli82016
zli82016 requested a review from hao-nan-li March 4, 2026 23:17

@hao-nan-li hao-nan-li left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Which problem/issue does this PR try to resolve?

@zli82016

zli82016 commented Mar 4, 2026

Copy link
Copy Markdown
Member Author

Which problem/issue does this PR try to resolve?

HTTPClient and NoOpAncestryManager exist in g3 TGC v6 and used by the customers. To be sync with g3 TGC v6, add these options to new TGC pkg.

@zli82016
zli82016 added this pull request to the merge queue Mar 5, 2026
Merged via the queue into GoogleCloudPlatform:main with commit 92f78eb Mar 5, 2026
26 checks passed
@zli82016
zli82016 deleted the tgc-options branch March 5, 2026 00:36
aditikumarii-google pushed a commit to aditikumarii-google/magic-modules that referenced this pull request Mar 10, 2026
ChuAmberZhang pushed a commit to ChuAmberZhang/magic-modules that referenced this pull request Apr 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants