Tgc revival: add compute resources by zli82016 · Pull Request #16583 · GoogleCloudPlatform/magic-modules

zli82016 · 2026-03-02T20:58:57Z

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

modular-magician · 2026-03-02T21:08:29Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

terraform-google-conversion: Diff ( 101 files changed, 17621 insertions(+), 5 deletions(-))

modular-magician · 2026-03-02T23:02:24Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

terraform-google-conversion: Diff ( 19 files changed, 2456 insertions(+), 1 deletion(-))

modular-magician · 2026-03-02T23:35:28Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

terraform-google-conversion: Diff ( 19 files changed, 2456 insertions(+), 1 deletion(-))

modular-magician · 2026-03-03T00:09:23Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

terraform-google-conversion: Diff ( 19 files changed, 2456 insertions(+), 1 deletion(-))

modular-magician · 2026-03-03T00:10:02Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

terraform-google-conversion: Diff ( 19 files changed, 2456 insertions(+), 1 deletion(-))

modular-magician · 2026-03-03T20:09:27Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 84 files changed, 531 deletions(-))
google-beta provider: Diff ( 86 files changed, 543 deletions(-))
terraform-google-conversion: Diff ( 39 files changed, 2456 insertions(+), 259 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_compute_autoscaler (8 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_autoscaler" "primary" {
  autoscaling_policy {
    metric {
      filter                     = # value needed
      single_instance_assignment = # value needed
    }
  }
}

Resource: google_compute_backend_service (247 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_backend_service" "primary" {
  backend {
    max_rate = # value needed
  }
  cdn_policy {
    cache_key_policy {
      query_string_blacklist = # value needed
    }
  }
}

Resource: google_compute_forwarding_rule (120 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_forwarding_rule" "primary" {
  service_label = # value needed
}

Resource: google_compute_ha_vpn_gateway (39 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_ha_vpn_gateway" "primary" {
  vpn_interfaces {
    interconnect_attachment = # value needed
  }
}

Resource: google_compute_region_autoscaler (6 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_region_autoscaler" "primary" {
  autoscaling_policy {
    metric {
      filter                     = # value needed
      name                       = # value needed
      single_instance_assignment = # value needed
      target                     = # value needed
    }
  }
}

Resource: google_compute_region_backend_service (231 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_region_backend_service" "primary" {
  affinity_cookie_ttl_sec = # value needed
  backend {
    max_connections              = # value needed
    max_connections_per_endpoint = # value needed
    max_connections_per_instance = # value needed
  }
  cdn_policy {
    cache_key_policy {
      include_query_string   = # value needed
      query_string_blacklist = # value needed
      query_string_whitelist = # value needed
    }
  }
}

Resource: google_compute_region_network_endpoint_group (22 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_region_network_endpoint_group" "primary" {
  app_engine {
    url_mask = # value needed
  }
  cloud_function {
    url_mask = # value needed
  }
  cloud_run {
    url_mask = # value needed
  }
}

Resource: google_compute_region_network_firewall_policy_rule (14 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_region_network_firewall_policy_rule" "primary" {
  security_profile_group = # value needed
}

Resource: google_compute_region_url_map (76 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_region_url_map" "primary" {
  default_url_redirect {
    redirect_response_code = # value needed
  }
  path_matcher {
    default_route_action {
      url_rewrite {
        path_template_rewrite = # value needed
      }
    }
    default_url_redirect {
      redirect_response_code = # value needed
    }
    path_rule {
      url_redirect {
        redirect_response_code = # value needed
      }
    }
    route_rules {
      route_action {
        retry_policy {
          retry_conditions = # value needed
        }
      }
    }
  }
}

Resource: google_compute_router_nat (28 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_router_nat" "primary" {
  rules {
    match = # value needed
  }
}

Resource: google_compute_url_map (98 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_url_map" "primary" {
  path_matcher {
    default_url_redirect {
      redirect_response_code = # value needed
    }
    route_rules {
      route_action {
        retry_policy {
          retry_conditions = # value needed
        }
      }
    }
  }
}

This reverts commit 13f9c52.

modular-magician · 2026-03-03T20:19:21Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 84 files changed, 531 deletions(-))
google-beta provider: Diff ( 86 files changed, 543 deletions(-))
terraform-google-conversion: Diff ( 39 files changed, 2456 insertions(+), 259 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_compute_autoscaler (8 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_autoscaler" "primary" {
  autoscaling_policy {
    metric {
      filter                     = # value needed
      single_instance_assignment = # value needed
    }
  }
}

Resource: google_compute_backend_service (247 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_backend_service" "primary" {
  backend {
    max_rate = # value needed
  }
  cdn_policy {
    cache_key_policy {
      query_string_blacklist = # value needed
    }
  }
}

Resource: google_compute_forwarding_rule (120 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_forwarding_rule" "primary" {
  service_label = # value needed
}

Resource: google_compute_ha_vpn_gateway (39 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_ha_vpn_gateway" "primary" {
  vpn_interfaces {
    interconnect_attachment = # value needed
  }
}

Resource: google_compute_region_autoscaler (6 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_region_autoscaler" "primary" {
  autoscaling_policy {
    metric {
      filter                     = # value needed
      name                       = # value needed
      single_instance_assignment = # value needed
      target                     = # value needed
    }
  }
}

Resource: google_compute_region_backend_service (231 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_region_backend_service" "primary" {
  affinity_cookie_ttl_sec = # value needed
  backend {
    max_connections              = # value needed
    max_connections_per_endpoint = # value needed
    max_connections_per_instance = # value needed
  }
  cdn_policy {
    cache_key_policy {
      include_query_string   = # value needed
      query_string_blacklist = # value needed
      query_string_whitelist = # value needed
    }
  }
}

Resource: google_compute_region_network_endpoint_group (22 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_region_network_endpoint_group" "primary" {
  app_engine {
    url_mask = # value needed
  }
  cloud_function {
    url_mask = # value needed
  }
  cloud_run {
    url_mask = # value needed
  }
}

Resource: google_compute_region_network_firewall_policy_rule (14 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_region_network_firewall_policy_rule" "primary" {
  security_profile_group = # value needed
}

Resource: google_compute_region_url_map (76 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_region_url_map" "primary" {
  default_url_redirect {
    redirect_response_code = # value needed
  }
  path_matcher {
    default_route_action {
      url_rewrite {
        path_template_rewrite = # value needed
      }
    }
    default_url_redirect {
      redirect_response_code = # value needed
    }
    path_rule {
      url_redirect {
        redirect_response_code = # value needed
      }
    }
    route_rules {
      route_action {
        retry_policy {
          retry_conditions = # value needed
        }
      }
    }
  }
}

Resource: google_compute_router_nat (28 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_router_nat" "primary" {
  rules {
    match = # value needed
  }
}

Resource: google_compute_url_map (98 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_url_map" "primary" {
  path_matcher {
    default_url_redirect {
      redirect_response_code = # value needed
    }
    route_rules {
      route_action {
        retry_policy {
          retry_conditions = # value needed
        }
      }
    }
  }
}

modular-magician · 2026-03-03T20:19:37Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 84 files changed, 531 deletions(-))
google-beta provider: Diff ( 86 files changed, 543 deletions(-))
terraform-google-conversion: Diff ( 39 files changed, 2456 insertions(+), 259 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_compute_autoscaler (8 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_autoscaler" "primary" {
  autoscaling_policy {
    metric {
      filter                     = # value needed
      single_instance_assignment = # value needed
    }
  }
}

Resource: google_compute_backend_service (247 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_backend_service" "primary" {
  backend {
    max_rate = # value needed
  }
  cdn_policy {
    cache_key_policy {
      query_string_blacklist = # value needed
    }
  }
}

Resource: google_compute_forwarding_rule (120 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_forwarding_rule" "primary" {
  service_label = # value needed
}

Resource: google_compute_ha_vpn_gateway (39 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_ha_vpn_gateway" "primary" {
  vpn_interfaces {
    interconnect_attachment = # value needed
  }
}

Resource: google_compute_region_autoscaler (6 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_region_autoscaler" "primary" {
  autoscaling_policy {
    metric {
      filter                     = # value needed
      name                       = # value needed
      single_instance_assignment = # value needed
      target                     = # value needed
    }
  }
}

Resource: google_compute_region_backend_service (231 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_region_backend_service" "primary" {
  affinity_cookie_ttl_sec = # value needed
  backend {
    max_connections              = # value needed
    max_connections_per_endpoint = # value needed
    max_connections_per_instance = # value needed
  }
  cdn_policy {
    cache_key_policy {
      include_query_string   = # value needed
      query_string_blacklist = # value needed
      query_string_whitelist = # value needed
    }
  }
}

Resource: google_compute_region_network_endpoint_group (22 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_region_network_endpoint_group" "primary" {
  app_engine {
    url_mask = # value needed
  }
  cloud_function {
    url_mask = # value needed
  }
  cloud_run {
    url_mask = # value needed
  }
}

Resource: google_compute_region_network_firewall_policy_rule (14 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_region_network_firewall_policy_rule" "primary" {
  security_profile_group = # value needed
}

Resource: google_compute_region_url_map (76 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_region_url_map" "primary" {
  default_url_redirect {
    redirect_response_code = # value needed
  }
  path_matcher {
    default_route_action {
      url_rewrite {
        path_template_rewrite = # value needed
      }
    }
    default_url_redirect {
      redirect_response_code = # value needed
    }
    path_rule {
      url_redirect {
        redirect_response_code = # value needed
      }
    }
    route_rules {
      route_action {
        retry_policy {
          retry_conditions = # value needed
        }
      }
    }
  }
}

Resource: google_compute_router_nat (28 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_router_nat" "primary" {
  rules {
    match = # value needed
  }
}

Resource: google_compute_url_map (98 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_url_map" "primary" {
  path_matcher {
    default_url_redirect {
      redirect_response_code = # value needed
    }
    route_rules {
      route_action {
        retry_policy {
          retry_conditions = # value needed
        }
      }
    }
  }
}

modular-magician · 2026-03-03T20:23:55Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 84 files changed, 531 deletions(-))
google-beta provider: Diff ( 86 files changed, 543 deletions(-))
terraform-google-conversion: Diff ( 19 files changed, 2456 insertions(+), 1 deletion(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_compute_autoscaler (8 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_autoscaler" "primary" {
  autoscaling_policy {
    metric {
      filter                     = # value needed
      single_instance_assignment = # value needed
    }
  }
}

Resource: google_compute_backend_service (247 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_backend_service" "primary" {
  backend {
    max_rate = # value needed
  }
  cdn_policy {
    cache_key_policy {
      query_string_blacklist = # value needed
    }
  }
}

Resource: google_compute_forwarding_rule (120 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_forwarding_rule" "primary" {
  service_label = # value needed
}

Resource: google_compute_ha_vpn_gateway (39 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_ha_vpn_gateway" "primary" {
  vpn_interfaces {
    interconnect_attachment = # value needed
  }
}

Resource: google_compute_region_autoscaler (6 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_region_autoscaler" "primary" {
  autoscaling_policy {
    metric {
      filter                     = # value needed
      name                       = # value needed
      single_instance_assignment = # value needed
      target                     = # value needed
    }
  }
}

Resource: google_compute_region_backend_service (231 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_region_backend_service" "primary" {
  affinity_cookie_ttl_sec = # value needed
  backend {
    max_connections              = # value needed
    max_connections_per_endpoint = # value needed
    max_connections_per_instance = # value needed
  }
  cdn_policy {
    cache_key_policy {
      include_query_string   = # value needed
      query_string_blacklist = # value needed
      query_string_whitelist = # value needed
    }
  }
}

Resource: google_compute_region_network_endpoint_group (22 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_region_network_endpoint_group" "primary" {
  app_engine {
    url_mask = # value needed
  }
  cloud_function {
    url_mask = # value needed
  }
  cloud_run {
    url_mask = # value needed
  }
}

Resource: google_compute_region_network_firewall_policy_rule (14 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_region_network_firewall_policy_rule" "primary" {
  security_profile_group = # value needed
}

Resource: google_compute_region_url_map (76 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_region_url_map" "primary" {
  default_url_redirect {
    redirect_response_code = # value needed
  }
  path_matcher {
    default_route_action {
      url_rewrite {
        path_template_rewrite = # value needed
      }
    }
    default_url_redirect {
      redirect_response_code = # value needed
    }
    path_rule {
      url_redirect {
        redirect_response_code = # value needed
      }
    }
    route_rules {
      route_action {
        retry_policy {
          retry_conditions = # value needed
        }
      }
    }
  }
}

Resource: google_compute_router_nat (28 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_router_nat" "primary" {
  rules {
    match = # value needed
  }
}

Resource: google_compute_url_map (98 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_url_map" "primary" {
  path_matcher {
    default_url_redirect {
      redirect_response_code = # value needed
    }
    route_rules {
      route_action {
        retry_policy {
          retry_conditions = # value needed
        }
      }
    }
  }
}

modular-magician · 2026-03-03T20:25:35Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

terraform-google-conversion: Diff ( 19 files changed, 2456 insertions(+), 1 deletion(-))

zli82016 force-pushed the tgc-ai-compute branch from 8a37bf7 to 10e455f Compare March 2, 2026 21:00

zli82016 force-pushed the tgc-ai-compute branch from 10e455f to 183fae8 Compare March 2, 2026 22:53

zli82016 force-pushed the tgc-ai-compute branch from d5c7edf to eb227fe Compare March 3, 2026 00:00

Refactor include_in_tgc_next in Compute resources (Part 1)

4f6b1a2

zli82016 force-pushed the tgc-ai-compute branch from eb227fe to 4f6b1a2 Compare March 3, 2026 00:01

zli82016 requested a review from hao-nan-li March 3, 2026 18:31

zli82016 marked this pull request as ready for review March 3, 2026 18:31

hao-nan-li approved these changes Mar 3, 2026

View reviewed changes

zli82016 added 2 commits March 3, 2026 11:57

Remove all empty lines

13f9c52

Restore newline after license header

afe0716

zli82016 force-pushed the tgc-ai-compute branch from 58885e8 to afe0716 Compare March 3, 2026 20:06

modular-magician added the service/terraform label Mar 3, 2026

Revert "Remove all empty lines"

34fb6c6

This reverts commit 13f9c52.

zli82016 added this pull request to the merge queue Mar 4, 2026

Merged via the queue into GoogleCloudPlatform:main with commit 6884667 Mar 4, 2026
22 checks passed

zli82016 deleted the tgc-ai-compute branch March 4, 2026 23:14

modular-magician mentioned this pull request Mar 4, 2026

Tgc revival: add compute resources GoogleCloudPlatform/terraform-google-conversion#5226

Merged

aditikumarii-google pushed a commit to aditikumarii-google/magic-modules that referenced this pull request Mar 10, 2026

Tgc revival: add compute resources (GoogleCloudPlatform#16583)

52c7af8

ChuAmberZhang pushed a commit to ChuAmberZhang/magic-modules that referenced this pull request Apr 29, 2026

Tgc revival: add compute resources (GoogleCloudPlatform#16583)

873cc5f

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Tgc revival: add compute resources#16583

Tgc revival: add compute resources#16583
zli82016 merged 4 commits into
GoogleCloudPlatform:mainfrom
zli82016:tgc-ai-compute

zli82016 commented Mar 2, 2026

Uh oh!

modular-magician commented Mar 2, 2026

Uh oh!

modular-magician commented Mar 2, 2026

Uh oh!

modular-magician commented Mar 2, 2026

Uh oh!

modular-magician commented Mar 3, 2026

Uh oh!

modular-magician commented Mar 3, 2026

Uh oh!

modular-magician commented Mar 3, 2026

Uh oh!

modular-magician commented Mar 3, 2026

Uh oh!

modular-magician commented Mar 3, 2026

Uh oh!

modular-magician commented Mar 3, 2026

Uh oh!

modular-magician commented Mar 3, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

zli82016 commented Mar 2, 2026

Uh oh!

modular-magician commented Mar 2, 2026

Diff report

Uh oh!

modular-magician commented Mar 2, 2026

Diff report

Uh oh!

modular-magician commented Mar 2, 2026

Diff report

Uh oh!

modular-magician commented Mar 3, 2026

Diff report

Uh oh!

modular-magician commented Mar 3, 2026

Diff report

Uh oh!

modular-magician commented Mar 3, 2026

Diff report

Missing test report

Uh oh!

modular-magician commented Mar 3, 2026

Diff report

Missing test report

Uh oh!

modular-magician commented Mar 3, 2026

Diff report

Missing test report

Uh oh!

modular-magician commented Mar 3, 2026

Diff report

Missing test report

Uh oh!

modular-magician commented Mar 3, 2026

Diff report

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants