Skip to content

removed usages of primary_resource_name#16558

Merged
melinath merged 1 commit into
GoogleCloudPlatform:mainfrom
melinath:remove-primary-resource-name-usage
Feb 27, 2026
Merged

removed usages of primary_resource_name#16558
melinath merged 1 commit into
GoogleCloudPlatform:mainfrom
melinath:remove-primary-resource-name-usage

Conversation

@melinath

Copy link
Copy Markdown
Member

This is no longer used as of #15306

I'm not removing the actual option yet to avoid breaking in-flight PRs; just want to remove things people might accidentally copy & propagate.

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.


@melinath melinath requested a review from shuyama1 February 26, 2026 23:38
@melinath

Copy link
Copy Markdown
Member Author

(possibly this should wait until after the example-based update tests; no urgency)

@modular-magician

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR hasn't generated any diffs, but I'll let you know if a future commit does.

@shuyama1 shuyama1 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(possibly this should wait until after the example-based update tests; no urgency)

I think it should be fine. I've also removed the PrimaryResourceName from the new iam test template (in #16518) based on the changes in #15306, so I don't think these are needed

@melinath melinath added this pull request to the merge queue Feb 27, 2026
Merged via the queue into GoogleCloudPlatform:main with commit 0df58d4 Feb 27, 2026
21 checks passed
@melinath melinath deleted the remove-primary-resource-name-usage branch February 27, 2026 00:25
kefang2 pushed a commit to kefang2/magic-modules that referenced this pull request Feb 28, 2026
habh-11 pushed a commit to habh-11/magic-modules that referenced this pull request Mar 2, 2026
aditikumarii-google pushed a commit to aditikumarii-google/magic-modules that referenced this pull request Mar 10, 2026
ChuAmberZhang pushed a commit to ChuAmberZhang/magic-modules that referenced this pull request Apr 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants