Skip to content

Updated vpc-project under resource_kms_ekm_connection_test.go#16534

Merged
c2thorn merged 3 commits into
GoogleCloudPlatform:mainfrom
rishamchokshi:main
Mar 16, 2026
Merged

Updated vpc-project under resource_kms_ekm_connection_test.go#16534
c2thorn merged 3 commits into
GoogleCloudPlatform:mainfrom
rishamchokshi:main

Conversation

@rishamchokshi

@rishamchokshi rishamchokshi commented Feb 25, 2026

Copy link
Copy Markdown
Contributor

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

@modular-magician modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Feb 25, 2026
@github-actions github-actions Bot requested a review from c2thorn February 25, 2026 22:10
@github-actions

Copy link
Copy Markdown

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@c2thorn, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@c2thorn

c2thorn commented Feb 26, 2026

Copy link
Copy Markdown
Member

@rishamchokshi please see go/terraform-auto-test-runs to get automatic test runs.

I've manually approved the build so it can start running.

Also, I've removed the changelog note, as test-only changes do not need a changelog note.

@modular-magician modular-magician added service/cloudkms and removed awaiting-approval Pull requests that need reviewer's approval to run presubmit tests labels Feb 26, 2026
@modular-magician

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 1 insertion(+), 1 deletion(-))
google-beta provider: Diff ( 1 file changed, 1 insertion(+), 1 deletion(-))

@modular-magician

Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 49
Passed tests: 42
Skipped tests: 6
Affected tests: 1

Click here to see the affected service packages
  • kms

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccKMSEkmConnection_kmsEkmConnectionBasicExample_update

Get to know how VCR tests work

@modular-magician

Copy link
Copy Markdown
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccKMSEkmConnection_kmsEkmConnectionBasicExample_update [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@c2thorn c2thorn left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

        Error: the user does not have permission to access Project "refekm-gdu-prod" or it may not exist

@c2thorn

c2thorn commented Mar 3, 2026

Copy link
Copy Markdown
Member

/gcbrun

@modular-magician modular-magician added awaiting-approval Pull requests that need reviewer's approval to run presubmit tests and removed awaiting-approval Pull requests that need reviewer's approval to run presubmit tests labels Mar 3, 2026
@modular-magician

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 1 insertion(+), 1 deletion(-))
google-beta provider: Diff ( 1 file changed, 1 insertion(+), 1 deletion(-))

@modular-magician

Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 49
Passed tests: 42
Skipped tests: 6
Affected tests: 1

Click here to see the affected service packages
  • kms

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccKMSEkmConnection_kmsEkmConnectionBasicExample_update

Get to know how VCR tests work

@modular-magician

Copy link
Copy Markdown
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccKMSEkmConnection_kmsEkmConnectionBasicExample_update [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Mar 16, 2026
@github-actions github-actions Bot requested a review from c2thorn March 16, 2026 18:33
@modular-magician modular-magician removed the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Mar 16, 2026
@modular-magician

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 6 deletions(-))
google-beta provider: Diff ( 1 file changed, 6 deletions(-))

@modular-magician

Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 49
Passed tests: 43
Skipped tests: 6
Affected tests: 0

Click here to see the affected service packages
  • kms

🟢 All tests passed!

View the build log

@c2thorn c2thorn added this pull request to the merge queue Mar 16, 2026
Merged via the queue into GoogleCloudPlatform:main with commit 86954ce Mar 16, 2026
24 checks passed
@yasassyasass57-create

Copy link
Copy Markdown

Tests analytics

Total tests: 49
Passed tests: 42
Skipped tests: 6
Affected tests: 1

Click here to see the affected service packages
  • kms

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccKMSEkmConnection_kmsEkmConnectionBasicExample_update

Get to know how VCR tests work

aditikumarii-google pushed a commit to aditikumarii-google/magic-modules that referenced this pull request Mar 18, 2026
ChuAmberZhang pushed a commit to ChuAmberZhang/magic-modules that referenced this pull request Apr 29, 2026
gitika-yadav pushed a commit to gitika-yadav/magic-modules that referenced this pull request May 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants