Skip to content

Add new targets to AuthzPolicy, AuthzExtension#16390

Merged
rileykarson merged 6 commits into
GoogleCloudPlatform:mainfrom
rileykarson:authz-policy
Feb 13, 2026
Merged

Add new targets to AuthzPolicy, AuthzExtension#16390
rileykarson merged 6 commits into
GoogleCloudPlatform:mainfrom
rileykarson:authz-policy

Conversation

@rileykarson

@rileykarson rileykarson commented Feb 13, 2026

Copy link
Copy Markdown
Member

These features are behind an allowlist and some targets don't actually validate (but will in the future), so I've skipped current tests until things stabilize. b/484137930 to follow up.

TestAccNetworkSecurityAuthzPolicy_networkSecurityAuthzPolicyMcpExample: gpaste/5225265870536704
TestAccNetworkSecurityAuthzPolicy_networkSecurityAuthzPolicyMcpUpdate: gpaste/5085298053742592 (note: due to a bug I had to disable the update mask on this one. That'll get remediated by the API, or I'll patch and retest if we need clientside changes)
TestAccNetworkServicesAuthzExtension_networkServicesAuthzExtensionIapExample does not pass yet, but the changes should be backwards compatible for existing targets and we should accommodate new targets barring unusual canonicalization rules.

Also renamed incorrectly named AuthzPolicy files in a few places; it's in NetworkSecurity, not NetworkServices. I only messed that one up a half dozen times myself working on these...

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

networkservices: relaxed `load_balancing_scheme` validation to support non-Backend Service targets in `google_network_services_authz_extension`
networksecurity: added `policy_profile`, `http_rules.0.to.0.operations.0.mcp` to `google_network_security_authz_policy`. Relaxed `load_balancing_scheme` validation to support non-Backend Service targets.

@modular-magician

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 8 files changed, 717 insertions(+), 36 deletions(-))
google-beta provider: Diff ( 8 files changed, 717 insertions(+), 36 deletions(-))
terraform-google-conversion: Diff ( 5 files changed, 529 insertions(+), 6 deletions(-))
Open in Cloud Shell: Diff ( 8 files changed, 243 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_network_security_authz_policy (6 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_network_security_authz_policy" "primary" {
  http_rules {
    to {
      operations {
        mcp {
          methods {
            params {
              contains = # value needed
              suffix   = # value needed
            }
          }
        }
      }
    }
  }
}

@modular-magician

Copy link
Copy Markdown
Collaborator

Non-exercised tests

🔴 Tests were added that are skipped in VCR:

  • TestAccNetworkSecurityAuthzPolicy_networkSecurityAuthzPolicyMcpExample
  • TestAccNetworkSecurityAuthzPolicy_networkSecurityAuthzPolicyMcpUpdate

Tests analytics

Total tests: 171
Passed tests: 161
Skipped tests: 8
Affected tests: 2

Click here to see the affected service packages
  • networksecurity
  • networkservices

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccNetworkSecurityAuthzPolicy_networkSecurityAuthzPolicyAdvancedExample
  • TestAccNetworkServicesAuthzExtension_networkServicesAuthzExtensionIapExample

Get to know how VCR tests work

@modular-magician

Copy link
Copy Markdown
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccNetworkSecurityAuthzPolicy_networkSecurityAuthzPolicyAdvancedExample [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🔴 Tests failed during RECORDING mode:
TestAccNetworkServicesAuthzExtension_networkServicesAuthzExtensionIapExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 8 files changed, 718 insertions(+), 36 deletions(-))
google-beta provider: Diff ( 8 files changed, 718 insertions(+), 36 deletions(-))
terraform-google-conversion: Diff ( 5 files changed, 529 insertions(+), 6 deletions(-))
Open in Cloud Shell: Diff ( 8 files changed, 243 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_network_security_authz_policy (6 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_network_security_authz_policy" "primary" {
  http_rules {
    to {
      operations {
        mcp {
          methods {
            params {
              contains = # value needed
              suffix   = # value needed
            }
          }
        }
      }
    }
  }
}

@modular-magician

Copy link
Copy Markdown
Collaborator

Non-exercised tests

🔴 Tests were added that are skipped in VCR:

  • TestAccNetworkSecurityAuthzPolicy_networkSecurityAuthzPolicyMcpExample
  • TestAccNetworkSecurityAuthzPolicy_networkSecurityAuthzPolicyMcpUpdate
  • TestAccNetworkServicesAuthzExtension_networkServicesAuthzExtensionIapExample

Tests analytics

Total tests: 171
Passed tests: 162
Skipped tests: 9
Affected tests: 0

Click here to see the affected service packages
  • networkservices
  • networksecurity

🟢 All tests passed!

View the build log

@NickElliot NickElliot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

verified test logs and context for skipping tests, LGTM

@rileykarson rileykarson added this pull request to the merge queue Feb 13, 2026
Merged via the queue into GoogleCloudPlatform:main with commit 96b15b7 Feb 13, 2026
29 checks passed
@rileykarson rileykarson deleted the authz-policy branch February 13, 2026 17:53
JianweiQ pushed a commit to JianweiQ/magic-modules that referenced this pull request Feb 20, 2026
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Feb 24, 2026
kefang2 pushed a commit to kefang2/magic-modules that referenced this pull request Feb 28, 2026
aditikumarii-google pushed a commit to aditikumarii-google/magic-modules that referenced this pull request Mar 10, 2026
ChuAmberZhang pushed a commit to ChuAmberZhang/magic-modules that referenced this pull request Apr 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants