Add new targets to AuthzPolicy, AuthzExtension#16390
Conversation
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_network_security_authz_policy" "primary" {
http_rules {
to {
operations {
mcp {
methods {
params {
contains = # value needed
suffix = # value needed
}
}
}
}
}
}
}
|
Non-exercised tests🔴 Tests were added that are skipped in VCR:
Tests analyticsTotal tests: 171 Click here to see the affected service packages
Action takenFound 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
|
🟢 Tests passed during RECORDING mode: 🟢 No issues found for passed tests after REPLAYING rerun. 🔴 Tests failed during RECORDING mode: 🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR. |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_network_security_authz_policy" "primary" {
http_rules {
to {
operations {
mcp {
methods {
params {
contains = # value needed
suffix = # value needed
}
}
}
}
}
}
}
|
Non-exercised tests🔴 Tests were added that are skipped in VCR:
Tests analyticsTotal tests: 171 Click here to see the affected service packages
🟢 All tests passed! View the build log |
NickElliot
left a comment
There was a problem hiding this comment.
verified test logs and context for skipping tests, LGTM
96b15b7
These features are behind an allowlist and some targets don't actually validate (but will in the future), so I've skipped current tests until things stabilize. b/484137930 to follow up.
TestAccNetworkSecurityAuthzPolicy_networkSecurityAuthzPolicyMcpExample: gpaste/5225265870536704
TestAccNetworkSecurityAuthzPolicy_networkSecurityAuthzPolicyMcpUpdate: gpaste/5085298053742592 (note: due to a bug I had to disable the update mask on this one. That'll get remediated by the API, or I'll patch and retest if we need clientside changes)
TestAccNetworkServicesAuthzExtension_networkServicesAuthzExtensionIapExample does not pass yet, but the changes should be backwards compatible for existing targets and we should accommodate new targets barring unusual canonicalization rules.
Also renamed incorrectly named AuthzPolicy files in a few places; it's in NetworkSecurity, not NetworkServices. I only messed that one up a half dozen times myself working on these...
Release Note Template for Downstream PRs (will be copied)
See Write release notes for guidance.