deletion policy generation accessapproval-artifactregistry#16324
Conversation
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Errors
|
Tests analyticsTotal tests: 0 Click here to see the affected service packages
🔴 Errors occurred during REPLAYING mode. Please fix them to complete your PR. View the build log |
Tests analyticsTotal tests: 270 Click here to see the affected service packages
Action takenFound 217 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
|
🔴 Tests failed during RECORDING mode: 🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR. |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: 978 Click here to see the affected service packages
Action takenFound 874 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: 978 Click here to see the affected service packages
Action takenFound 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
|
🟢 Tests passed during RECORDING mode: 🔴 Tests failed when rerunning REPLAYING mode: Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made. Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer. 🔴 Tests failed during RECORDING mode: 🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR. |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
|
🔴 The provider crashed while running the VCR tests in REPLAYING mode |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
|
🔴 The provider crashed while running the VCR tests in REPLAYING mode |
|
🔴 The provider crashed while running the VCR tests in REPLAYING mode |
|
/gcbrun |
|
appears there is bad error handling in acctest.AddBigQueryDatasetReplica(), rerunning to see if its a fluke and unrelated to this PR (as it seems) |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: 5986 Click here to see the affected service packages
Action takenFound 66 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
|
🟢 Tests passed during RECORDING mode: 🔴 Tests failed when rerunning REPLAYING mode: Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made. Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer. 🔴 Tests failed during RECORDING mode: 🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR. |
| Create: resource{{ $.ResourceName -}}Create, | ||
| Read: resource{{ $.ResourceName -}}Read, | ||
| {{- if or (or $.Updatable $.RootLabels) $.VirtualFields }} | ||
| {{- if or (or $.Updatable $.RootLabels (and (not $.ExcludeDelete) (not $.DeletionPolicyExclude) $.ProductMetadata.DeletionPolicyOptIn)) $.VirtualFields }} |
There was a problem hiding this comment.
this is because the deletion policy field is essentially an extended virtual field, and existence of virtual fields mean the resource is updatable?
There are probably very few generated cases now that would be not updatable now right?
There was a problem hiding this comment.
I would expect there to be fairly few yeah
NickElliot
merged commit 59e2f9f
into
GoogleCloudPlatform:FEATURE-BRANCH-universal-deletion-policy
3 participants
Release Note Template for Downstream PRs (will be copied)
See Write release notes for guidance.