Add DeveloperConnectSource to Vertex ReasoningEngine#16316
Conversation
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_vertex_ai_reasoning_engine" "primary" {
spec {
source_code_spec {
developer_connect_source {
config {
dir = # value needed
git_repository_link = # value needed
revision = # value needed
}
}
}
}
}
|
Tests analyticsTotal tests: 83 Click here to see the affected service packages
🟢 All tests passed! View the build log |
|
Discussed offline; the schema is simple and unlikely to have issues, the API accepts the request and fails for domain-specific reasons. I'll follow up with a test per issue hashicorp/terraform-provider-google#26007 |
c2thorn
left a comment
There was a problem hiding this comment.
Discussed testing offline, LGTM.
5e5c388
Fixes hashicorp/terraform-provider-google#25931
Followup test issue: hashicorp/terraform-provider-google#26007
I've omitted testing for now. This is complicated because we need a properly set up Git repo with developer connect set up- so wrangling external credentials, specific files, etc. Let me know what you'd look for for this!
I could probably get it set up manually, but it's a bit of a pain following policy since the path of least resistance is a personal Git repo.
Sending it in a request:
I get a domain-specific error:
where without the field configured I get:
Release Note Template for Downstream PRs (will be copied)
See Write release notes for guidance.