Skip to content

tgc-revival: Build Parent to child map for parent resolver#16252

Merged
hao-nan-li merged 2 commits into
GoogleCloudPlatform:mainfrom
hao-nan-li:parent_resolver1
Feb 5, 2026
Merged

tgc-revival: Build Parent to child map for parent resolver#16252
hao-nan-li merged 2 commits into
GoogleCloudPlatform:mainfrom
hao-nan-li:parent_resolver1

Conversation

@hao-nan-li

Copy link
Copy Markdown
Contributor

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.


@hao-nan-li
hao-nan-li requested a review from zli82016 January 28, 2026 20:37
@modular-magician

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

terraform-google-conversion: Diff ( 3 files changed, 350 insertions(+))

@hao-nan-li
hao-nan-li marked this pull request as ready for review January 28, 2026 21:06

@zli82016 zli82016 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By the way, what graph traversal algorithm are you going to use?

Comment thread mmv1/third_party/tgc_next/pkg/tfplan2cai/resolvers/parent_resolver.go Outdated
Comment thread mmv1/third_party/tgc_next/pkg/tfplan2cai/resolvers/parent_resolver.go Outdated
Comment thread mmv1/third_party/tgc_next/pkg/tfplan2cai/resolvers/parent_resolver.go Outdated
Comment thread mmv1/third_party/tgc_next/pkg/tfplan2cai/resolvers/parent_resolver.go Outdated
@modular-magician

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

terraform-google-conversion: Diff ( 4 files changed, 742 insertions(+))

@zli82016 zli82016 changed the title Build Parent to child map for parent resolver tgc-revival: Build Parent to child map for parent resolver Feb 5, 2026
@hao-nan-li
hao-nan-li enabled auto-merge February 5, 2026 21:43
@hao-nan-li
hao-nan-li disabled auto-merge February 5, 2026 23:04
@hao-nan-li
hao-nan-li added this pull request to the merge queue Feb 5, 2026
Merged via the queue into GoogleCloudPlatform:main with commit c55a1e0 Feb 5, 2026
24 of 26 checks passed
@hao-nan-li
hao-nan-li deleted the parent_resolver1 branch February 5, 2026 23:24
18811376770 pushed a commit to 18811376770/magic-modules that referenced this pull request Feb 11, 2026
JianweiQ pushed a commit to JianweiQ/magic-modules that referenced this pull request Feb 20, 2026
kefang2 pushed a commit to kefang2/magic-modules that referenced this pull request Feb 28, 2026
aditikumarii-google pushed a commit to aditikumarii-google/magic-modules that referenced this pull request Mar 10, 2026
ChuAmberZhang pushed a commit to ChuAmberZhang/magic-modules that referenced this pull request Apr 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants