Skip to content

feat(apigee): google_apigee_instance datasource#16230

Merged
BBBmau merged 14 commits into
GoogleCloudPlatform:mainfrom
YpNo:feat/googe_apigee_instance_datasource
Jun 3, 2026
Merged

feat(apigee): google_apigee_instance datasource#16230
BBBmau merged 14 commits into
GoogleCloudPlatform:mainfrom
YpNo:feat/googe_apigee_instance_datasource

Conversation

@YpNo

@YpNo YpNo commented Jan 26, 2026

Copy link
Copy Markdown
Contributor

Fixes : #15287

Enabling datasource creation in the instance Template.

Release Note Template for Downstream PRs (will be copied)

apigee: new `google_apigee_instance` datasource

@modular-magician modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Jan 26, 2026
@github-actions github-actions Bot requested a review from ScottSuarez January 26, 2026 20:41
@github-actions

github-actions Bot commented Jan 26, 2026

Copy link
Copy Markdown

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@BBBmau, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@YpNo YpNo marked this pull request as draft January 28, 2026 08:01
@YpNo YpNo marked this pull request as ready for review January 28, 2026 12:43
@modular-magician modular-magician added service/apigee and removed awaiting-approval Pull requests that need reviewer's approval to run presubmit tests labels Jan 28, 2026
@modular-magician

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 6 files changed, 478 insertions(+), 14 deletions(-))
google-beta provider: Diff ( 6 files changed, 478 insertions(+), 14 deletions(-))
Open in Cloud Shell: Diff ( 4 files changed, 134 insertions(+))

@modular-magician

Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 74
Passed tests: 35
Skipped tests: 37
Affected tests: 2

Click here to see the affected service packages
  • apigee

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccApigeeEndpointAttachment_apigeeEndpointAttachmentBasicExample
  • TestAccDataSourceApigeeInstance_basic

Get to know how VCR tests work

@modular-magician

Copy link
Copy Markdown
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccApigeeEndpointAttachment_apigeeEndpointAttachmentBasicExample [Error message] [Debug log]
TestAccDataSourceApigeeInstance_basic [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@github-actions

github-actions Bot commented Feb 2, 2026

Copy link
Copy Markdown

@ScottSuarez This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

Comment thread mmv1/products/apigee/Instance.yaml Outdated
@YpNo YpNo force-pushed the feat/googe_apigee_instance_datasource branch from d0c98fc to 23706ed Compare February 7, 2026 17:45
@modular-magician modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Feb 7, 2026
@github-actions github-actions Bot requested a review from ScottSuarez February 7, 2026 17:46
@YpNo

YpNo commented Feb 7, 2026

Copy link
Copy Markdown
Contributor Author

Hi @ScottSuarez , I reviewed my copy.

Let me know

@github-actions

Copy link
Copy Markdown

@ScottSuarez This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

@modular-magician modular-magician removed the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Feb 12, 2026
@modular-magician

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 8 files changed, 418 insertions(+), 14 deletions(-))
google-beta provider: Diff ( 8 files changed, 418 insertions(+), 14 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 1 insertion(+))
Open in Cloud Shell: Diff ( 4 files changed, 134 insertions(+))

@modular-magician

Copy link
Copy Markdown
Collaborator

Non-exercised tests

🔴 Tests were added that are skipped in VCR:

  • TestAccDataSourceApigeeInstance_basic

Tests analytics

Total tests: 74
Passed tests: 35
Skipped tests: 38
Affected tests: 1

Click here to see the affected service packages
  • apigee

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccApigeeEndpointAttachment_apigeeEndpointAttachmentBasicExample

Get to know how VCR tests work

@modular-magician

Copy link
Copy Markdown
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccApigeeEndpointAttachment_apigeeEndpointAttachmentBasicExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

Comment thread mmv1/products/apigee/EndpointAttachment.yaml Outdated
@YpNo YpNo force-pushed the feat/googe_apigee_instance_datasource branch from 23706ed to 37a6130 Compare February 19, 2026 09:59
@modular-magician modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Feb 19, 2026
@github-actions github-actions Bot requested a review from ScottSuarez February 19, 2026 10:00
@modular-magician modular-magician removed the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Feb 19, 2026
@modular-magician

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 7 files changed, 471 insertions(+), 35 deletions(-))
google-beta provider: Diff ( 7 files changed, 471 insertions(+), 35 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 1 insertion(+))

@modular-magician

Copy link
Copy Markdown
Collaborator

Non-exercised tests

🔴 Tests were added that are skipped in VCR:

  • TestAccDataSourceApigeeInstance_basic

Tests analytics

Total tests: 73
Passed tests: 35
Skipped tests: 37
Affected tests: 1

Click here to see the affected service packages
  • apigee

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccApigeeEndpointAttachment_apigeeEndpointAttachmentBasicExample

Get to know how VCR tests work

@modular-magician

Copy link
Copy Markdown
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccApigeeEndpointAttachment_apigeeEndpointAttachmentBasicExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician

modular-magician commented May 11, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 50a2dd3:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 6 files changed, 470 insertions(+), 58 deletions(-)
google-beta provider View Diff 6 files changed, 470 insertions(+), 58 deletions(-)
terraform-google-conversion View Diff 1 file changed, 1 insertion(+)

Test report

Important

Manual Verification Required

VCR cannot automatically execute the following tests added in this PR. Please verify them manually:

🔴 TestAccDataSourceApigeeInstance_basic

Analytics

Total Tests Passed Skipped Affected
76 35 38 3
Affected Service Packages
  • apigee

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccApigeeEndpointAttachment_apigeeEndpointAttachmentBasicExample
  • TestAccApigeeOrganization_apigeeOrganizationCloudBasicDisableVpcPeeringTestExample
  • TestAccApigeeOrganization_apigeeOrganizationCloudFullDisableVpcPeeringTestExample

View the build log


Step 2: Recording Mode

Caution

Panic occurred during VCR tests

🔴 RECORDING mode: The provider crashed with a panic. Please check the build log for details.

Please fix the issue to complete your PR.

View the build log

@YpNo, @ScottSuarez, @BBBmau VCR tests complete for 50a2dd3!

@github-actions

Copy link
Copy Markdown

@YpNo, this PR is waiting for action from you. If no action is taken, this PR will be closed in 28 days.

Please address any comments or change requests, or re-request review from a core reviewer if no action is required.

Image showing the re-request review button

This notification can be disabled with the disable-automatic-closure label.

@YpNo YpNo force-pushed the feat/googe_apigee_instance_datasource branch from 50a2dd3 to e0746dd Compare June 3, 2026 21:22
@modular-magician modular-magician added awaiting-approval Pull requests that need reviewer's approval to run presubmit tests and removed awaiting-approval Pull requests that need reviewer's approval to run presubmit tests labels Jun 3, 2026
@modular-magician

modular-magician commented Jun 3, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit e0746dd:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 3 files changed, 252 insertions(+)
google-beta provider View Diff 3 files changed, 252 insertions(+)
terraform-google-conversion View Diff 1 file changed, 1 insertion(+)

Test report

Important

Manual Verification Required

VCR cannot automatically execute the following tests added in this PR. Please verify them manually:

🔴 TestAccDataSourceApigeeInstance_basic

Analytics

Total Tests Passed Skipped Affected
79 40 39 0
Affected Service Packages
  • apigee

Learn how VCR tests work


Step 1: Replaying Mode

🟢 All tests passed in Replaying mode! No Recording was needed.

Caution

Issues requiring attention before PR completion

🔴 Manual Verification Required: New tests were added that are skipped in presubmit tests. See the "Manual Verification Required" section at the top for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the replaying VCR build log

@YpNo, @ScottSuarez, @BBBmau VCR tests complete for e0746dd!

@BBBmau BBBmau left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants