dataproc: add encryption_config block to docs

[BBBmau]

Release Note Template for Downstream PRs (will be copied)

At first it seemed as though we didn't support encryption_config to be able to setup dataproc_workflow_templates with CMEK but the resource documentation simply lacked the top-level mention of encryption_config.

This will add the encryption_config block as well as an example for encryption_config block usage.

Link to the current dataproc_workflow_template documentation page

See Write release notes for guidance.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 3 insertions(+), 2 deletions(-))

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 96 insertions(+), 8 deletions(-))
google-beta provider: Diff ( 1 file changed, 93 insertions(+), 6 deletions(-))

[github-actions]

@melinath This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

[github-actions]

@GoogleCloudPlatform/terraform-team @melinath This PR has been waiting for review for 1 week. Please take a look! Use the label disable-review-reminders to disable these notifications.

[melinath]

@zli82016 it looks like this is a DCL resource - shouldn't it have docs generated instead of needing them handwritten?

[zli82016]

@zli82016 it looks like this is a DCL resource - shouldn't it have docs generated instead of needing them handwritten?

It looks like the docs for this resource is handwritten. I think it is OK to add the field to the doc manually.

But do we want to override the field in the file tpgtools/overrides/dataproc/workflow_template.yaml?

[melinath]

Ah, yeah, it looks like this doc file has been handwritten for a while. Weird!

[melinath]

+1 to Zhenhua's question; this seems outside the scope of this PR.

[BBBmau]

good catch, this came from having the assumption that it wasn't already supported on the resource itself. will remove in latest commit

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 93 insertions(+), 6 deletions(-))
google-beta provider: Diff ( 1 file changed, 93 insertions(+), 6 deletions(-))

[melinath]

Suggested change

	* The `encryption_config` - (Optional) Encryption settings for encrypting workflow template job arguments.
	* `encryption_config` - (Optional) Encryption settings for encrypting workflow template job arguments.

[melinath]

Here & below:

• these links all seem to include extraneous ?gl= query params; could those be removed?
• all the links now redirect to docs.cloud.google.com - could we update them to point there directly instead? Context: Add docs subdomain to resourcemanager links #16189 & similar PRs recently.

[melinath]

just here: #adding_jobs_to_a_template isn't the correct anchor. It could be worth double-checking the rest.

[melinath]

nit: not a blocker since this doc is already incorrect, but this should be structured differently, with anchor links from the field definition to what's in the block. Currently, the jobs field is very far from its subfields with no links, and this PR makes that slightly worse. Compare for example: https://github.com/hashicorp/terraform-provider-google-beta/blob/6bbd36a89f4448462e988c990892e0a06d1a9134/website/docs/r/alloydb_instance.html.markdown?plain=1#L289

[BBBmau]

went ahead and fixed the structuring and cleaned up the links

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 110 insertions(+), 23 deletions(-))
google-beta provider: Diff ( 1 file changed, 110 insertions(+), 23 deletions(-))

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 110 insertions(+), 23 deletions(-))
google-beta provider: Diff ( 1 file changed, 110 insertions(+), 23 deletions(-))