Skip to content

Adding google_vmwareengine_network_policy to TGC tfplan2cai converter#15574

Merged
zli82016 merged 5 commits into
GoogleCloudPlatform:mainfrom
hemantadil:feat-vmware-engine-network-policy-converter
Nov 5, 2025
Merged

Adding google_vmwareengine_network_policy to TGC tfplan2cai converter#15574
zli82016 merged 5 commits into
GoogleCloudPlatform:mainfrom
hemantadil:feat-vmware-engine-network-policy-converter

Conversation

@hemantadil

Copy link
Copy Markdown
Member

Adding vmware engine network policy tfplan to cai converter
Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.


This commit adds a new converter for the `google_vmwareengine_network_policy` resource.

The converter is registered in `mmv1/third_party/tgc/resource_converters.go.tmpl`, and a new test case has been added to `mmv1/third_party/tgc/tests/data` to verify its functionality.
This commit adds a new converter for the `google_vmwareengine_network_policy` resource.

The converter is registered in `mmv1/third_party/tgc/resource_converters.go.tmpl`, and a new test case has been added to `mmv1/third_party/tgc/tests/data` to verify its functionality.
@github-actions github-actions Bot requested a review from slevenick November 2, 2025 09:36
@github-actions

github-actions Bot commented Nov 2, 2025

Copy link
Copy Markdown

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@slevenick, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

terraform-google-conversion: Diff ( 4 files changed, 45 insertions(+))

@zli82016 zli82016 requested review from zli82016 and removed request for slevenick November 3, 2025 20:35
@zli82016 zli82016 changed the title Adding vmware engine network policy tfplan to cai converter Adding google_vmwareengine_network_policy to TGC tfplan2cai converter Nov 4, 2025
Comment thread mmv1/third_party/tgc/tests/data/vmwareengine_network_policy.tf Outdated
@github-actions github-actions Bot requested a review from zli82016 November 5, 2025 03:22
@modular-magician

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

terraform-google-conversion: Diff ( 4 files changed, 39 insertions(+))

@zli82016 zli82016 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@zli82016

zli82016 commented Nov 5, 2025

Copy link
Copy Markdown
Member

@hemantadil , can you resolve the conflicts? Thanks.

@github-actions github-actions Bot requested a review from zli82016 November 5, 2025 17:35
@modular-magician

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

terraform-google-conversion: Diff ( 4 files changed, 38 insertions(+))

@hemantadil

Copy link
Copy Markdown
Member Author

@hemantadil , can you resolve the conflicts? Thanks.

Done

@zli82016 zli82016 added this pull request to the merge queue Nov 5, 2025
Merged via the queue into GoogleCloudPlatform:main with commit da305c0 Nov 5, 2025
23 of 24 checks passed
bcreddy-gcp pushed a commit to bcreddy-gcp/magic-modules that referenced this pull request Nov 24, 2025
…er (GoogleCloudPlatform#15574)

Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
Co-authored-by: Hemant Adil <hemantadil@google.com>
deliaqi pushed a commit to deliaqi/magic-modules that referenced this pull request Nov 26, 2025
…er (GoogleCloudPlatform#15574)

Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
Co-authored-by: Hemant Adil <hemantadil@google.com>
JianweiQ pushed a commit to JianweiQ/magic-modules that referenced this pull request Feb 20, 2026
…er (GoogleCloudPlatform#15574)

Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
Co-authored-by: Hemant Adil <hemantadil@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants