Skip to content

Detect malformed frontmatter in changed doc files#13609

Merged
shuyama1 merged 1 commit into
GoogleCloudPlatform:mainfrom
iyabchen:frontmatter
Jun 18, 2025
Merged

Detect malformed frontmatter in changed doc files#13609
shuyama1 merged 1 commit into
GoogleCloudPlatform:mainfrom
iyabchen:frontmatter

Conversation

@iyabchen

@iyabchen iyabchen commented Apr 10, 2025

Copy link
Copy Markdown
Contributor

hashicorp/terraform-provider-google#19828

Detect malformed frontmatter in changed doc files

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

@modular-magician

modular-magician commented Apr 10, 2025

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR hasn't generated any diffs, but I'll let you know if a future commit does.

1 similar comment
@modular-magician

modular-magician commented Apr 10, 2025

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR hasn't generated any diffs, but I'll let you know if a future commit does.

@iyabchen iyabchen requested a review from shuyama1 April 10, 2025 16:49
@iyabchen iyabchen marked this pull request as ready for review April 10, 2025 16:49
@iyabchen

iyabchen commented Apr 10, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Not sure whether that's the way to surface the error, so sending some initial code to get some feedback.
A test PR showing how it looks like in here: #13617

@github-actions

github-actions Bot commented Apr 15, 2025

Copy link
Copy Markdown

@shuyama1 This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

@github-actions

github-actions Bot commented Apr 17, 2025

Copy link
Copy Markdown

@GoogleCloudPlatform/terraform-team @shuyama1 This PR has been waiting for review for 1 week. Please take a look! Use the label disable-review-reminders to disable these notifications.

@iyabchen iyabchen force-pushed the frontmatter branch 3 times, most recently from 551d04b to c405ddf Compare April 17, 2025 19:05
@modular-magician

modular-magician commented Apr 17, 2025

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR hasn't generated any diffs, but I'll let you know if a future commit does.

1 similar comment
@modular-magician

modular-magician commented Apr 17, 2025

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR hasn't generated any diffs, but I'll let you know if a future commit does.

@github-actions

github-actions Bot commented Apr 24, 2025

Copy link
Copy Markdown

@GoogleCloudPlatform/terraform-team @shuyama1 This PR has been waiting for review for 2 weeks. Please take a look! Use the label disable-review-reminders to disable these notifications.

@github-actions

github-actions Bot commented May 1, 2025

Copy link
Copy Markdown

@GoogleCloudPlatform/terraform-team @shuyama1 This PR has been waiting for review for 3 weeks. Please take a look! Use the label disable-review-reminders to disable these notifications.

@github-actions

github-actions Bot commented May 8, 2025

Copy link
Copy Markdown

@GoogleCloudPlatform/terraform-team @shuyama1 This PR has been waiting for review for 4 weeks. Please take a look! Use the label disable-review-reminders to disable these notifications.

@github-actions

github-actions Bot commented May 15, 2025

Copy link
Copy Markdown

@GoogleCloudPlatform/terraform-team @shuyama1 This PR has been waiting for review for 5 weeks. Please take a look! Use the label disable-review-reminders to disable these notifications.

@github-actions

github-actions Bot commented May 22, 2025

Copy link
Copy Markdown

@GoogleCloudPlatform/terraform-team @shuyama1 This PR has been waiting for review for 6 weeks. Please take a look! Use the label disable-review-reminders to disable these notifications.

@github-actions

github-actions Bot commented May 29, 2025

Copy link
Copy Markdown

@GoogleCloudPlatform/terraform-team @shuyama1 This PR has been waiting for review for 7 weeks. Please take a look! Use the label disable-review-reminders to disable these notifications.

@github-actions

github-actions Bot commented Jun 5, 2025

Copy link
Copy Markdown

@GoogleCloudPlatform/terraform-team @shuyama1 This PR has been waiting for review for 8 weeks. Please take a look! Use the label disable-review-reminders to disable these notifications.

@github-actions

github-actions Bot commented Jun 12, 2025

Copy link
Copy Markdown

@GoogleCloudPlatform/terraform-team @shuyama1 This PR has been waiting for review for 9 weeks. Please take a look! Use the label disable-review-reminders to disable these notifications.

shuyama1
shuyama1 reviewed Jun 12, 2025
View reviewed changes

@shuyama1 shuyama1 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Regarding your question hashicorp/terraform-provider-google#19828 (comment), I looked through our docs and it seems that subcategory is a key part of the categorization logic. What are your thoughts on adding an check for subcategory existence here as well?

@iyabchen

iyabchen commented Jun 18, 2025

Copy link
Copy Markdown
Contributor Author

Done, added a check for that as well.

Regarding your question hashicorp/terraform-provider-google#19828 (comment), I looked through our docs and it seems that subcategory is a key part of the categorization logic. What are your thoughts on adding an check for subcategory existence here as well?

@github-actions github-actions Bot requested a review from shuyama1 June 18, 2025 02:21
@modular-magician

modular-magician commented Jun 18, 2025

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR hasn't generated any diffs, but I'll let you know if a future commit does.

shuyama1
shuyama1 reviewed Jun 18, 2025
View reviewed changes

@shuyama1 shuyama1 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@shuyama1 shuyama1 added this pull request to the merge queue Jun 18, 2025
Merged via the queue into GoogleCloudPlatform:main with commit 9838a00 Jun 18, 2025
25 checks passed
@modular-magician modular-magician mentioned this pull request Jun 19, 2025
Merged
G-jackyli pushed a commit to G-jackyli/magic-modules that referenced this pull request Jun 21, 2025
@iyabchen @G-jackyli
Detect malformed frontmatter in changed doc files (GoogleCloudPlatfor…
9f38a7b 
…m#13609)
niharika-98 pushed a commit to niharika-98/magic-modules that referenced this pull request Jun 23, 2025
@iyabchen @niharika-98
Detect malformed frontmatter in changed doc files (GoogleCloudPlatfor…
fe5397c 
…m#13609)
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Jun 25, 2025
@iyabchen @BBBmau
Detect malformed frontmatter in changed doc files (GoogleCloudPlatfor…
b48619e 
…m#13609)
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Jun 25, 2025
@iyabchen @BBBmau
Detect malformed frontmatter in changed doc files (GoogleCloudPlatfor…
30f24c1 
…m#13609)
jingqizz pushed a commit to jingqizz/magic-modules that referenced this pull request Jul 9, 2025
@iyabchen @jingqizz
Detect malformed frontmatter in changed doc files (GoogleCloudPlatfor…
9e7557b 
…m#13609)
@shuyama1 shuyama1 mentioned this pull request Jul 18, 2025
Closed
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Jul 28, 2025
@iyabchen @BBBmau
Detect malformed frontmatter in changed doc files (GoogleCloudPlatfor…
f93d48c 
…m#13609)
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Jul 28, 2025
@iyabchen @BBBmau
Detect malformed frontmatter in changed doc files (GoogleCloudPlatfor…
1276b75 
…m#13609)
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Jul 28, 2025
@iyabchen @BBBmau
Detect malformed frontmatter in changed doc files (GoogleCloudPlatfor…
80a1e23 
…m#13609)
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Jul 28, 2025
@iyabchen @BBBmau
Detect malformed frontmatter in changed doc files (GoogleCloudPlatfor…
80cc488 
…m#13609)
NandiniAgrawal15 pushed a commit to NandiniAgrawal15/magic-modules that referenced this pull request Sep 4, 2025
@iyabchen @NandiniAgrawal15
Detect malformed frontmatter in changed doc files (GoogleCloudPlatfor…
03f6f8e 
…m#13609)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shuyama1 shuyama1 shuyama1 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@iyabchen @modular-magician @shuyama1