Skip to content

Generate test coverage check and comment#13012

Merged
shuyama1 merged 2 commits into
GoogleCloudPlatform:mainfrom
iyabchen:cov-check
Oct 31, 2025
Merged

Generate test coverage check and comment#13012
shuyama1 merged 2 commits into
GoogleCloudPlatform:mainfrom
iyabchen:cov-check

Conversation

@iyabchen

@iyabchen iyabchen commented Feb 9, 2025

Copy link
Copy Markdown
Contributor

hashicorp/terraform-provider-google#18868
Report involved service coverage into check and comment as part of the vcr test.

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.


@modular-magician

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))
google-beta provider: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

@modular-magician

Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 1101
Passed tests: 1023
Skipped tests: 75
Affected tests: 3

Click here to see the affected service packages
  • compute

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccComputeBackendService_withBackend
  • TestAccComputeBackendService_withBackendAndIAP
  • TestAccComputeBackendService_withBackendAndMaxUtilization

Get to know how VCR tests work

@modular-magician

Copy link
Copy Markdown
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccComputeBackendService_withBackend [Debug log]
TestAccComputeBackendService_withBackendAndIAP [Debug log]
TestAccComputeBackendService_withBackendAndMaxUtilization [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🟢 All tests passed!

View the build log or the debug log for each test

@modular-magician

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))
google-beta provider: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

@modular-magician

Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 1101
Passed tests: 1026
Skipped tests: 75
Affected tests: 0

Click here to see the affected service packages
  • compute

🟢 All tests passed!

View the build log
github.com/hashicorp/terraform-provider-google-beta/google-beta/services/compute coverage: 66.7% of statements

@modular-magician

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))
google-beta provider: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

@modular-magician

Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 1101
Passed tests: 1026
Skipped tests: 75
Affected tests: 0

Click here to see the affected service packages
  • compute

🟢 All tests passed!

View the build log
github.com/hashicorp/terraform-provider-google-beta/google-beta/services/compute coverage: 66.7% of statements

@modular-magician

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))
google-beta provider: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

@modular-magician

Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 1101
Passed tests: 1026
Skipped tests: 75
Affected tests: 0

Click here to see the affected service packages
  • compute

🟢 All tests passed!

View the build log
Test Coverage:

github.com/hashicorp/terraform-provider-google-beta/google-beta/services/compute coverage: 66.7% of statements

@modular-magician

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))
google-beta provider: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

@modular-magician

Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 1105
Passed tests: 1030
Skipped tests: 75
Affected tests: 0

Click here to see the affected service packages
  • compute

🟢 All tests passed!

View the build log

Test Coverage:

github.com/hashicorp/terraform-provider-google-beta/google-beta/services/compute coverage: 66.7% of statements

@modular-magician

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR hasn't generated any diffs, but I'll let you know if a future commit does.

@shuyama1

Copy link
Copy Markdown
Member

I think the output format looks good to me. Can we try targeting multiple services - wonder how the GH check's gonna look like for multiple services

@modular-magician

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 6 files changed, 8 insertions(+), 8 deletions(-))
google-beta provider: Diff ( 6 files changed, 8 insertions(+), 8 deletions(-))

@modular-magician

Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 463
Passed tests: 396
Skipped tests: 64
Affected tests: 3

Click here to see the affected service packages
  • accesscontextmanager
  • alloydb
  • compute

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccAccessContextManager
  • TestAccAlloydbBackup_update
  • TestAccComputeBackendService_withBackendAndIAP

Get to know how VCR tests work

@modular-magician

Copy link
Copy Markdown
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccAccessContextManager [Debug log]
TestAccComputeBackendService_withBackendAndIAP [Debug log]

🔴 Tests failed when rerunning REPLAYING mode:
TestAccAccessContextManager [Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.


🔴 Tests failed during RECORDING mode:
TestAccAlloydbBackup_update [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 6 insertions(+), 6 deletions(-))
google-beta provider: Diff ( 5 files changed, 6 insertions(+), 6 deletions(-))

@modular-magician

Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 433
Passed tests: 367
Skipped tests: 64
Affected tests: 2

Click here to see the affected service packages
  • alloydb
  • compute
  • accesscontextmanager

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccAccessContextManager
  • TestAccAlloydbBackup_update

Get to know how VCR tests work

@modular-magician

Copy link
Copy Markdown
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccAccessContextManager [Debug log]

🔴 Tests failed when rerunning REPLAYING mode:
TestAccAccessContextManager [Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.


🔴 Tests failed during RECORDING mode:
TestAccAlloydbBackup_update [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@iyabchen iyabchen force-pushed the cov-check branch 2 times, most recently from 7d8c680 to c453963 Compare February 19, 2025 18:19
@modular-magician

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 5 insertions(+), 5 deletions(-))
google-beta provider: Diff ( 4 files changed, 5 insertions(+), 5 deletions(-))

1 similar comment
@modular-magician

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 5 insertions(+), 5 deletions(-))
google-beta provider: Diff ( 4 files changed, 5 insertions(+), 5 deletions(-))

@modular-magician

Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 330
Passed tests: 268
Skipped tests: 62
Affected tests: 0

Click here to see the affected service packages
  • accesscontextmanager
  • compute

🔴 Errors occurred during REPLAYING mode. Please fix them to complete your PR.

View the build log

@modular-magician

Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 418
Passed tests: 357
Skipped tests: 61
Affected tests: 0

Click here to see the affected service packages
  • compute
  • accesscontextmanager

🔴 Errors occurred during REPLAYING mode. Please fix them to complete your PR.

View the build log

@github-actions

Copy link
Copy Markdown

@GoogleCloudPlatform/terraform-team @shuyama1 This PR has been waiting for review for 1 week. Please take a look! Use the label disable-review-reminders to disable these notifications.

@github-actions

Copy link
Copy Markdown

@GoogleCloudPlatform/terraform-team @shuyama1 This PR has been waiting for review for 2 weeks. Please take a look! Use the label disable-review-reminders to disable these notifications.

@github-actions

github-actions Bot commented Jul 7, 2025

Copy link
Copy Markdown

@GoogleCloudPlatform/terraform-team @shuyama1 This PR has been waiting for review for 3 weeks. Please take a look! Use the label disable-review-reminders to disable these notifications.

@github-actions

Copy link
Copy Markdown

@GoogleCloudPlatform/terraform-team @shuyama1 This PR has been waiting for review for 4 weeks. Please take a look! Use the label disable-review-reminders to disable these notifications.

@shuyama1

Copy link
Copy Markdown
Member

/gcbrun

@modular-magician

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR hasn't generated any diffs, but I'll let you know if a future commit does.

@shuyama1 shuyama1 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you rebase the branch? I left a small comment. This should be good to go after. Thanks!

Comment thread .ci/magician/cov/merger.go
@github-actions

github-actions Bot commented Oct 1, 2025

Copy link
Copy Markdown

@iyabchen, this PR is waiting for action from you. If no action is taken, this PR will be closed in 28 days.

Please address any comments or change requests, or re-request review from a core reviewer if no action is required.

Image showing the re-request review button

This notification can be disabled with the disable-automatic-closure label.

@modular-magician modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Oct 8, 2025
@github-actions github-actions Bot requested a review from shuyama1 October 8, 2025 08:57
@modular-magician modular-magician removed the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Oct 11, 2025
@modular-magician

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR hasn't generated any diffs, but I'll let you know if a future commit does.

@shuyama1

Copy link
Copy Markdown
Member

/gcbrun

@modular-magician modular-magician added awaiting-approval Pull requests that need reviewer's approval to run presubmit tests and removed awaiting-approval Pull requests that need reviewer's approval to run presubmit tests labels Oct 31, 2025
@modular-magician

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR hasn't generated any diffs, but I'll let you know if a future commit does.

@shuyama1 shuyama1 added this pull request to the merge queue Oct 31, 2025
Merged via the queue into GoogleCloudPlatform:main with commit 5881be9 Oct 31, 2025
32 checks passed
shuyama1 added a commit that referenced this pull request Nov 5, 2025
bcreddy-gcp pushed a commit to bcreddy-gcp/magic-modules that referenced this pull request Nov 24, 2025
Co-authored-by: Shuya Ma <87669292+shuyama1@users.noreply.github.com>
JianweiQ pushed a commit to JianweiQ/magic-modules that referenced this pull request Feb 20, 2026
Co-authored-by: Shuya Ma <87669292+shuyama1@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants