container: fix node_config.kubelet_config updates in google_container_cluster

[wyardley]

This is still shy of a fix for updates for everything within node_config, and doesn't consolidate where we're updating the google_container_node_pool resource vs. the default-pool that can be created directly within google_container_cluster, but it does fix a subset of the fields that don't work, and also simplifies some of the code and consolidates some tests, so maybe still worth considering as another step in the right direction.

• Fix updates for fields within node_config.kubelet_config where updates didn't function properly (basically all except for insecure_kubelet_readonly_port_enabled.
• Consolidate test cases for items under node_config.kubelet_config with the one for node_config.kubelet_config.insecure_kubelet_readonly_port_enabled, including testing updates.

Part of hashicorp/terraform-provider-google#19225

Release Note Template for Downstream PRs (will be copied)

container: fixed `node_config.kubelet_config` updates in `google_container_cluster` resource

[github-actions]

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@trodge, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 47 insertions(+), 69 deletions(-))
google-beta provider: Diff ( 2 files changed, 47 insertions(+), 69 deletions(-))

[modular-magician]

Tests analytics

Total tests: 208
Passed tests: 194
Skipped tests: 13
Affected tests: 1

Click here to see the affected service packages

• container

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccContainerCluster_withNodeConfigKubeletConfigSettingsUpdates

Get to know how VCR tests work

[modular-magician]

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccContainerCluster_withNodeConfigKubeletConfigSettingsUpdates[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

---

$\textcolor{green}{\textsf{All tests passed!}}$

View the build log or the debug log for each test

[github-actions]

@trodge This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 46 insertions(+), 68 deletions(-))
google-beta provider: Diff ( 2 files changed, 46 insertions(+), 68 deletions(-))

[modular-magician]

Tests analytics

Total tests: 209
Passed tests: 196
Skipped tests: 13
Affected tests: 0

Click here to see the affected service packages

• container

$\textcolor{green}{\textsf{All tests passed!}}$

View the build log

[github-actions]

@GoogleCloudPlatform/terraform-team @trodge This PR has been waiting for review for 1 week. Please take a look! Use the label disable-review-reminders to disable these notifications.