Skip to content

DC apigee collector addition - first time contributor, long time user and admirer!!#11655

Closed
ogormans-stack wants to merge 2 commits into
GoogleCloudPlatform:mainfrom
ogormans-stack:dc-apigee-collector
Closed

DC apigee collector addition - first time contributor, long time user and admirer!!#11655
ogormans-stack wants to merge 2 commits into
GoogleCloudPlatform:mainfrom
ogormans-stack:dc-apigee-collector

Conversation

@ogormans-stack

@ogormans-stack ogormans-stack commented Sep 6, 2024

Copy link
Copy Markdown

Apigee Data Collector addition

This solves a pernicious issue within apigee, where one can have configured the entire suite in terraform but is unable to create or import dc resources, which greatly affect the ordering of analytical data should you gather and structure request downstream
image
I've added basic testing to exercise the code and I already had a crack at doing this fully on my own

I did get sense and no reinvent the wheel, I also looked at the issue tracker for apigee related stuff, to no avail


`google_apigee_datacollector' - create or import existing datacollector which are critical to the analytical structure of the request you consume from on apigee

@google-cla

google-cla Bot commented Sep 6, 2024

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@modular-magician modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Sep 6, 2024
@ogormans-stack ogormans-stack reopened this Sep 6, 2024
@rileykarson

Copy link
Copy Markdown
Member

Apologies, this seems to have fallen through the cracks at some point! It didn't hit our reviewer assignment rule, I'm not sure why. I'm going to close this PR as stale for now.

We've changed our core generator to Go from Ruby, and moved the YAML inputs from serialized Ruby objects to generic YAML types as described under https://googlecloudplatform.github.io/magic-modules/develop/add-resource/. If you're interested in making the change I'd recommend refactoring the yaml contents (it should be 1:1 or close) and opening a new PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting-approval Pull requests that need reviewer's approval to run presubmit tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants