Adding HappyBase Connection.create_table(). by dhermes · Pull Request #1502 · googleapis/google-cloud-python

dhermes · 2016-02-19T22:47:24Z

@tseaver sorry #1501 got closed. I did a git push -f after rebase-ing and it just pushed the HEAD of master (which GitHub interpreted as a delete).

gcloud/bigtable/happybase/connection.py

+                         family options as the values. The options can be among
+
+                         * :class:`dict`
+                         * :class:`.GarbageCollectionRule`


tseaver · 2016-02-20T00:12:03Z

Do all the possible options (dict keys) control only garbage collection?

dhermes · 2016-02-20T00:16:32Z

The only fields for a table (other than a name) are the GC rules. So the keys of families the dictionary (the one that gets passed to create_table) are the names of the column families (as strings) and then the values specify the configuration for each table.

You're right in wondering though. I'd imagine if at some point the Thrift/HBase table settings

max_versions
compression
in_memory
bloom_filter_type
bloom_filter_vector_size
bloom_filter_nb_hashes
block_cache_enabled
time_to_live

then we'd have a re-design on our hands.

dhermes · 2016-02-20T00:23:10Z

How big of a n00b am I! I closed this by accident (from the command line) the exact same way I closed #1501.

dhermes · 2016-02-20T17:58:55Z

@tseaver Does my explanation make sense?

gcloud/bigtable/happybase/connection.py

+    result = option
+    if isinstance(result, dict):
+        if not set(result.keys()) <= set(['max_versions', 'time_to_live']):
+            raise ValueError('Cloud Bigtable only supports max_versions and '


dhermes · 2016-02-24T16:50:10Z

@jonparrott I changed the exception to a warning in _parse_family_option. Still waiting on the atomicity / rollback question.

theacodes · 2016-02-24T17:13:48Z

LGTM, barring the question about atomicity.

(don't forget to squash)

dhermes · 2016-02-24T17:23:01Z

OK. Will squash and merge and file an issue to follow up.

theacodes · 2016-02-24T17:23:41Z

SGTM.

Adding HappyBase Connection.create_table().

#1541) * bug: fixes discrepancy btwn python-api-core & bigquery re object default timeout * Fix: loosen ipywidget dependency (#1504) * fix: updates ipywidget dependency * fix: updates ipywidget version number * chore(main): release 3.6.0 (#1490) Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> * docs: Remove < 3.11 reference from README (#1502) * chore(python): upgrade gcp-releasetool in .kokoro [autoapprove] (#1508) Source-Link: googleapis/synthtool@5f2a608 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:8555f0e37e6261408f792bfd6635102d2da5ad73f8f09bcb24f25e6afb5fac97 Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> * feat: add `connection_properties` and `create_session` to `LoadJobConfig` (#1509) * feat: added `connection_properties` and `create_session` in load job * chore(deps): update all dependencies (#1501) * chore(deps): update all dependencies * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Anthonios Partheniou <partheniou@google.com> Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> * chore(deps): update all dependencies (#1513) * feat: add default_query_job_config property and property setter to BQ client (#1511) Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly: - [x] Make sure to open an issue as a [feature request](https://togithub.com/googleapis/python-bigquery/issues/1512) before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea - [x] Ensure the tests and linter pass - [x] Code coverage does not decrease (if any source code was changed) - [x] Appropriate docs were updated (if necessary) Fixes - [feature request](https://togithub.com/googleapis/python-bigquery/issues/1512)🦕 - [internal bug](https://b.corp.google.com/issues/271044948) * chore(deps): update all dependencies (#1514) * chore(deps): update dependency charset-normalizer to v3.1.0 (#1518) * chore(main): release 3.7.0 (#1507) Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> * feat: expose configuration property on CopyJob, ExtractJob, LoadJob, QueryJob (#1521) * feat: expose configuration property on CopyJob, ExtractJob, LoadJob, QueryJob Note for google-cloud-bigquery developers: This also refactors these classes so that `_set_properties` does not modify the `_properties` dictionary in-place. Doing so was also mutating the request object, making it difficult to debug what request was _actually_ sent. Before this change, many tests hallucinated that the request was always equal to the response. * E google.api_core.exceptions.BadRequest: 400 Clone operation with write disposition WRITE_TRUNCATE is not supported. Please try again with WRITE_EMPTY. * chore(deps): Update nox in .kokoro/requirements.in [autoapprove] (#1527) Source-Link: googleapis/synthtool@92006bb Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:2e247c7bf5154df7f98cce087a20ca7605e236340c7d6d1a14447e5c06791bd6 Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> * feat: add default LoadJobConfig to Client (#1526) * feat: add bool, int, float, string dtype to to_dataframe (#1529) * fix: loosen ipywidgets restrictions further to address ipython compatibility issues (#1531) * fix: loosen ipywidgets restrictions further to address ipython compatibility issues * include ipywidgets in prerelease deps * show all package versions * add ipykernel dependency * ipykernel in noxfile * oops * chore(main): release 3.8.0 (#1525) Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> * fix: keyerror when the load_table_from_dataframe accesses a unmapped dtype dataframe index (#1535) * feat: expose query job on dbapi cursor (#1520) Co-authored-by: Tim Swast <swast@google.com> * chore(main): release 3.9.0 (#1537) Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> * chore: update tests to be compatible with pandas 2.0 (#1538) * chore: update tests to be compatible with pandas 2.0 * use StringDtype without storage argument * avoid Float64Dtype on older pandas * chore(deps): update all dependencies (#1522) * chore: updates minimum version of bqstorage (#1542) * chore: updates minimum version of bqstorage * removes unneeded test * updates linting, removes unneeded comment * updates conditional checks, comments, adds test * Removes test, adds pragma no cover * Removes test * fix linting error --------- Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Atsushi Yamamoto <yamaatsushi927@gmail.com> Co-authored-by: gcf-owl-bot[bot] <78513119+gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Shobhit Singh <just.shobhit@gmail.com> Co-authored-by: Mend Renovate <bot@renovateapp.com> Co-authored-by: Anthonios Partheniou <partheniou@google.com> Co-authored-by: chelsea-lin <124939984+chelsea-lin@users.noreply.github.com> Co-authored-by: Tim Swast <swast@google.com> Co-authored-by: r1b <robert.cole.jensen@gmail.com>

#1502) * feat: Add new field `contexts` for Object Contexts in message `Object` feat: Add new field `filter` for Object Contexts in message `ListObjectsRequest` PiperOrigin-RevId: 781971065 Source-Link: googleapis/googleapis@f2a87ff Source-Link: googleapis/googleapis-gen@9cab897 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiOWNhYjg5N2Y0YTAxZDNhMmU5NzBkMjg5ZjRjMzk4OGQ0NGFmOGM2NCJ9 chore: update the GAPIC generator version for C# PiperOrigin-RevId: 778777226 docs: Various documentation and comment improvements, Enable organization-level support for VPC Flow Logs feat: Enable organization-level support for VPC Flow Logs feat: add field `service_uri` to message `Endpoint.CloudRunRevisionEndpoint` feat: add message `Endpoint.SingleEdgeResponse` feat: add http additional_bindings feat: add enum `Status` to message `InstanceInfo` feat: add field `running` to message `InstanceInfo` feat: add field `policy_priority` to message `NetworkInfo` feat: add enum value `RouteInfo.NextHopType.SECURE_WEB_PROXY_GATEWAY` feat: add enum `DeliverInfo.GoogleServiceType` feat: add field `google_service_type` to message `DeliverInfo` feat: add enum value `AbortInfo.Cause.GOOGLE_MANAGED_SERVICE_AMBIGUOUS_ENDPOINT` feat: add enum values `NO_ROUTE_FROM_EXTERNAL_IPV6_SOURCE_TO_PRIVATE_IPV6_ADDRESS`, `TRAFFIC_FROM_HYBRID_ENDPOINT_TO_INTERNET_DISALLOWED`, `NO_MATCHING_NAT64_GATEWAY`, `LOAD_BALANCER_BACKEND_IP_VERSION_MISMATCH`, and `NO_KNOWN_ROUTE_FROM_NCC_NETWORK_TO_DESTINATION` to `DropInfo.Cause` feat: add rpc `VpcFlowLogsService.QueryOrgVpcFlowLogsConfigs` feat: add service `OrganizationVpcFlowLogsService` feat: add enum `VpcFlowLogsConfig.CrossProjectMetadata` feat: add enum `VpcFlowLogsConfig.TargetResourceState` feat: add fields `cross_project_metadata`, `target_resource_state`, `network`, and `subnet` to message `VpcFlowLogsConfig` PiperOrigin-RevId: 778807926 feat: A new field `semantic_search` is added to `message.google.cloud.dataplex.v1.SearchEntriesRequest` PiperOrigin-RevId: 778817135 fix: pagination response for Compute Subnetworks.ListUsable (39952d9) PiperOrigin-RevId: 778931614 fix!: Correct resource reference type for `parent` field in `data_chat_service.proto` PiperOrigin-RevId: 780026729 feat: update libraries and clients for Managed Kafka PiperOrigin-RevId: 780098649 chore: regenerate gapic yaml and service yaml for cloudtrace v2 by augmentation configs PiperOrigin-RevId: 780150418 chore: regenerate gapic yaml and service yaml for iam by augmentation configs PiperOrigin-RevId: 780151180 chore: regenerate gapic yaml and service yaml for cloudtrace v1 by augmentation configs PiperOrigin-RevId: 780152154 feat: Update Compute Engine v1 API to revision 20250626 feat: Update Compute Engine v1beta API to revision 20250626 docs: Add more details for BidiReadObjectRedirectedError and BidiWriteObjectRedirectedError docs: Add more information for AppendObjectSpec fields fix!: Remove field `restricted` within encryption enforcement config. feat: Add new field `restriction_mode` for encryption enforcement config in message Bucket PiperOrigin-RevId: 780246504 feat: Add isolation support to prevent cross-region overflow by adding a new field "isolation_config" to message "ServiceLbPolicy" PiperOrigin-RevId: 780262024 feat: Add safebrowsing proto defs PiperOrigin-RevId: 780289284 feat: add RDN sequence feat: add User Defined Access URLs feat: add backdate duration feat: adds tbs_certificate_digest to CertificateDescription PiperOrigin-RevId: 780300269 chore: update the GAPIC generator version for C# PiperOrigin-RevId: 780414513 Source-Link: googleapis/googleapis@f1decb8 Source-Link: googleapis/googleapis-gen@96e33aa Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiOTZlMzNhYWIyNTUxMmIzOTgxMGYxNTk3MWFmNjNhMzRmY2E1Y2Y1ZiJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

dhermes added the api: bigtable Issues related to the Bigtable API. label Feb 19, 2016

dhermes assigned tseaver Feb 19, 2016

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 19, 2016

dhermes reviewed Feb 19, 2016
View reviewed changes

gcloud/bigtable/happybase/connection.py

family options as the values. The options can be among

* :class:`dict`

* :class:`.GarbageCollectionRule`

This comment was marked as spam.

Sign in to view

dhermes closed this Feb 20, 2016

dhermes force-pushed the happybase-create-table branch from 10d0ea4 to 91be693 Compare February 20, 2016 00:22

dhermes reopened this Feb 20, 2016

tseaver mentioned this pull request Feb 22, 2016

Implementing HappyBase Table atomic counter helpers. #1514

Merged

dhermes assigned theacodes and unassigned tseaver Feb 22, 2016

theacodes reviewed Feb 23, 2016
View reviewed changes

dhermes force-pushed the happybase-create-table branch from c988088 to 35b5e8d Compare February 24, 2016 16:48

dhermes mentioned this pull request Feb 24, 2016

How should we resolve the fact that we can't make HappyBase create_table() atomic #1524

Closed

Adding HappyBase Connection.create_table().

c001fb9

dhermes force-pushed the happybase-create-table branch from 35b5e8d to c001fb9 Compare February 24, 2016 17:36

dhermes added a commit that referenced this pull request Feb 24, 2016

Merge pull request #1502 from dhermes/happybase-create-table

8e03b0d

Adding HappyBase Connection.create_table().

dhermes merged commit 8e03b0d into googleapis:master Feb 24, 2016

dhermes deleted the happybase-create-table branch February 24, 2016 17:40

theacodes mentioned this pull request Mar 4, 2016

Upgrading version to 0.11.0 #1573

Merged

parthea pushed a commit that referenced this pull request Nov 26, 2025

chore: update token (#1502)

51d84fe

parthea added a commit that referenced this pull request Mar 2, 2026

chore: update owlbot post processor image (#1502)

dd8a39b

parthea pushed a commit that referenced this pull request Mar 6, 2026

docs: Remove < 3.11 reference from README (#1502)

8ec60fe

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adding HappyBase Connection.create_table().#1502

Adding HappyBase Connection.create_table().#1502
dhermes merged 1 commit intogoogleapis:masterfrom
dhermes:happybase-create-table

dhermes commented Feb 19, 2016

Uh oh!

This comment was marked as spam.

Uh oh!

tseaver commented Feb 20, 2016

Uh oh!

dhermes commented Feb 20, 2016

Uh oh!

dhermes commented Feb 20, 2016

Uh oh!

dhermes commented Feb 20, 2016

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

dhermes commented Feb 24, 2016

Uh oh!

theacodes commented Feb 24, 2016

Uh oh!

dhermes commented Feb 24, 2016

Uh oh!

theacodes commented Feb 24, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

dhermes commented Feb 19, 2016

Uh oh!

This comment was marked as spam.

Uh oh!

tseaver commented Feb 20, 2016

Uh oh!

dhermes commented Feb 20, 2016

Uh oh!

dhermes commented Feb 20, 2016

Uh oh!

dhermes commented Feb 20, 2016

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

dhermes commented Feb 24, 2016

Uh oh!

theacodes commented Feb 24, 2016

Uh oh!

dhermes commented Feb 24, 2016

Uh oh!

theacodes commented Feb 24, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants