test: add integration test for PostgreSQL source in Datastream to BigQuery#4039
test: add integration test for PostgreSQL source in Datastream to BigQuery#4039yonatandt wants to merge 1 commit into
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request expands the integration testing suite for the Datastream to BigQuery template by adding support for PostgreSQL. The changes include necessary dependency updates and refactoring of the test logic to accommodate PostgreSQL-specific resource management and source initialization, ensuring robust validation of the pipeline across multiple database sources. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request adds support for PostgreSQL integration testing in the Datastream to BigQuery template. This includes adding the PostgreSQL JDBC driver dependency, introducing a new integration test testDataStreamPostgresToBigQuery, and refactoring the test setup to support PostgreSQL using switch expressions. Feedback is provided regarding a potential issue with table name casing in PostgreSQL: unquoted table names are folded to lowercase, which will cause mismatches with case-sensitive BigQuery table IDs. A suggestion is provided to use lowercase table names when running tests with PostgreSQL.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4039 +/- ##
============================================
- Coverage 55.70% 55.68% -0.02%
- Complexity 6774 7234 +460
============================================
Files 1125 1124 -1
Lines 68437 68447 +10
Branches 7719 7721 +2
============================================
- Hits 38121 38114 -7
- Misses 27844 27856 +12
- Partials 2472 2477 +5
🚀 New features to boost your workflow:
|
fee69ff to
3516392
Compare
No description provided.