gix 0.77 vs. 0.78: Error message is different (wrong?) with invalid commit id

[35VLG84]

Current behavior 😯

With gix 0.78 error message for invalid (unknown) commit id has been changed.

The gix 0.77 used to say "An object prefixed 1234abcd could not be found",
when gix 0.78 says "couldn't parse revision: 1234abcd".

Is this intended behavior? Personally, the new message is slightly confusing as it's saying "couldn't parse" even though there isn't anything wrong with the commit id in sense of parsing, it's just unknown.

IMHO, the old error message was the best and clearest, also when compared to git.

This is slightly related to an old gitoxide issue #1914 and the client code in question is here:

• Tackler's Gix code: lookup by commit id as reference
• Tackler's test suite: git error path tests

Below is collection of various messages in case of unknown commit id:

git show ef88456ffae9eb546d115833f2ad66d48a8e268b
fatal: bad object ef88456ffae9eb546d115833f2ad66d48a8e268b

gix: 0.77
An object prefixed ef88456ffae9eb546d115833f2ad66d48a8e268b could not be found

gix: 0.78
couldn't parse revision: ef88456ffae9eb546d115833f2ad66d48a8e268b

git show ef88456
fatal: ambiguous argument 'ef88456': unknown revision or path not in the working tree.

gix 0.77
An object prefixed ef88456 could not be found

gix 0.78
couldn't parse revision: ef88456

Most importantly, thank you for working with Gitoxide!

Expected behavior 🤔

The gix 0.77 used to say "An object prefixed 1234abcd could not be found".

Git behavior

git show ef88456ffae9eb546d115833f2ad66d48a8e268b
fatal: bad object ef88456ffae9eb546d115833f2ad66d48a8e268b

Steps to reproduce 🕹

The client code in question is here:

• Tackler's Gix code: lookup by commit id as reference
• Tackler's test suite: git error path tests

[35VLG84]

Sorry, I realized that this could be just an api change with repo.rev_parse_single. I will investigate more and get back if needed.

[Byron]

It's a regression in some way, and there will probably be more of them due to #2351.

Here is what I get, so the original error is still present.

❯ gix rev parse 1234abcd
Error: couldn't parse revision: 1234abcd

Caused by:
    An object prefixed 1234abcd could not be found