polish(update): clarify target-specific release output#99
Conversation
Zero automated PR reviewVerdict: No blockers found Blockers
Validation
ScopeHead: This deterministic review checks validation status and basic diff hygiene. A human reviewer still owns product judgment and design quality. |
|
Lost in the diff? Review this PR in Change Stack to follow the change map from intent to exact ranges. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
WalkthroughThis PR enhances update messages with platform-arch visibility. It introduces a helper to compute ChangesPlatform-arch-specific release guidance
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Vasanthdev2004
left a comment
There was a problem hiding this comment.
Blockers
- None.
Non-Blocking
- None.
Looks Good
- The formatter now includes the resolved release target before the archive/checksum names and removes the ambiguous "your platform" guidance from update-available output.
- The fallback path remains safe when asset platform/arch are absent: it omits the target line and uses generic verified-release-asset wording instead of inventing a target.
- The branch was behind current
origin/main, so I also validated a clean latest-main test merge. - Validation run locally on the PR head:
go test -count=1 ./internal/updatego test -count=1 -p 1 ./...go run ./cmd/zero-release build./zero update --check --target windows-x64 --endpoint <windows data: endpoint>git diff --check
- Validation run locally on a latest-main test merge:
go test -count=1 ./internal/updatego test -count=1 -p 1 ./...go run ./cmd/zero-release build./zero update --check --target windows-x64 --endpoint <windows data: endpoint>git diff --check
Summary
Validation
Sample output
Summary by CodeRabbit
Bug Fixes
Tests