docs: comprehensive project README#33
Conversation
Replace the stub README with a full overview: highlights, quick start, provider/model config, TUI + headless usage, command reference, tool table, architecture, project layout, dev/release, and docs index.
BlockersNone found. Non-Blocking
Looks Good
Verdict: Approve — Clean comprehensive README update. |
gnanam1990
left a comment
There was a problem hiding this comment.
Automated Hermes Agent review
Verdict: Changes requested
I reviewed the README-only diff against the current branch and checked the referenced CLI/TUI implementation.
Blocking docs accuracy issue
README.md:70-71advertises interactive TUI shortcuts/features that do not exist in the current code on this branch:@file references,!shell commands,shift+tabmode cycling, andEscinterrupt. The current TUI input handler insrc/tui/App.tsxhandles slash commands, Enter, Tab completion, basic editing, scrolling when the prompt is empty, and Ctrl+C exit; it does not implement those advertised shortcuts. Shipping the README as-is would give users incorrect instructions for core interaction.
Please either remove those advertised shortcuts from the README or reword them to only describe implemented behavior. If those features are intended to come from another branch, this README should wait until the matching implementation is on the target branch.
Validation
npx --yes bun test ./tests --timeout 15000✅ — 205 pass / 0 fail
The rest of the README structure and links looked coherent from this pass.
Automated review by Hermes Agent
BlockersNone found. Non-Blocking
Looks Good
Verdict: Approve — Clean README accuracy fix for the previously requested TUI shortcut issue. |
Address review: the TUI input handler only implements Enter (send), Tab (accept slash suggestion), arrow/PgUp-PgDn/Home-End scrolling when empty, and Ctrl+C. Remove advertised @ file refs, ! shell, shift+tab cycling, and Esc interrupt (those are UI affordances not yet wired). Also correct 'collapsible tool rows' to 'compact tool-call rows' to match the current renderer.
|
Addressed the review (and kept your
|
gnanam1990
left a comment
There was a problem hiding this comment.
Automated Hermes Agent rereview
Verdict: Approved
I rereviewed the new README commits (575b701, 9d2ef7b) after my previous changes-requested review.
Requested change resolution
- The previous blocker on
README.md:70-71is resolved. The README no longer advertises unimplemented@file references,!shell commands, Shift+Tab mode cycling, or Esc interrupt behavior. - The current TUI usage wording now matches the implemented input handler in
src/tui/App.tsx: Enter sends,/opens suggestions, Tab accepts the first suggestion, empty-prompt arrow/PgUp/PgDn/Home/End keys scroll the transcript, and Ctrl+C exits. - The highlights wording was also corrected from "collapsible tool rows" to "compact tool-call rows with inline diffs", which matches the current renderer better.
Validation
npx --yes bun test ./tests --timeout 15000✅ — 227 pass / 0 fail on the current checked repo state.
No new docs accuracy blockers found in this rereview.
Automated rereview by Hermes Agent
anandh8x
left a comment
There was a problem hiding this comment.
Review: Comprehensive README
No blockers. Accurate, well-structured, and covers the full surface of what's shipped on main.
What's good
- Discipline to
main— The PR description explicitly says all content was taken from HEADaee8b82, not invented. No unreleased features (resume/fork, tool approval) are advertised. - Quick start — Clear path from
bun installto running; env-var-based config for first use plus YAML config for profiles - Usage section — TUI interaction docs match the actual input handler (slash commands, Tab, scroll-on-empty-prompt). Headless exec examples cover the three output formats
- Provider and tool tables — Correct and cover all registered providers and tools
- Architecture diagram — Accurate layered view: TUI + headless exec → Agent Core → swappable modules
- Project layout — Reflects the actual
src/structure including allzero-*modules anddocs/ - Development commands — Complete set: test, typecheck, build, smoke, perf, release
- No factual errors — Cross-checked against everything I've seen across PRs #9–#32
Replaces the stub README with a full, accurate overview of Zero as it stands on
main.Includes:
exec(incl. stream-json), and theproviders/search/doctor/config/updatecommandsAll commands, flags, providers, models, and module paths were taken from
main(HEADaee8b82), not invented.