feat: add M2 performance benchmark harness#20
Merged
Conversation
gnanam1990
approved these changes
Jun 3, 2026
gnanam1990
left a comment
Collaborator
There was a problem hiding this comment.
Automated Hermes Agent rereview
Verdict: Approve
This PR had not yet been reviewed by gnanam1990, so I performed a full review of the current PR diff against origin/main.
Existing review/comment context considered
- Reviews: none found.
- Issue comments: none found.
Scope reviewed
- Adds
scripts/perf-bench.tsfor cold-start, TTFT, stream overhead, and RSS benchmark reporting. - Adds helper tests in
tests/perf-bench.test.ts. - Adds
perf:bench/perf:smokepackage scripts, performance CI job, and docs.
Validation
npx --yes bun install --frozen-lockfile✅npx --yes bun test✅ (138 passing)npx --yes bun run typecheck✅npx --yes bun run build✅- Targeted performance smoke:
npx --yes bun run perf:smoke✅- cold start p95 77.04 ms; TTFT p95 0.48 ms; RSS peak 67.81 MB; warnings: none
- GitHub checks observed passing for Performance Smoke and all Smoke matrix jobs ✅
I did not find blocking correctness, security, or maintainability issues. The benchmark code handles CLI/env parsing errors, emits CI warnings without failing by default, writes reports safely under caller-provided paths, and has useful unit plus end-to-end coverage.
Collaborator
BlockersNone found. Non-BlockingNone. Looks Good
Verdict: Approve — solid M2 benchmark/CI foundation and safe to merge after the stale-base check. |
Vasanthdev2004
approved these changes
Jun 3, 2026
Vasanthdev2004
left a comment
Collaborator
There was a problem hiding this comment.
Approved. Solid M2 performance benchmark/CI foundation; PR branch and latest-main test-merge validation passed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
Note