Add M1 release packaging workflow#14
Merged
Merged
Conversation
gnanam1990
approved these changes
Jun 2, 2026
gnanam1990
left a comment
Collaborator
There was a problem hiding this comment.
Code Review Summary
Verdict: Approved
The release packaging slice looks good overall:
- Adds a clear
package:releasescript that builds, smoke-checks, stages, archives, and writes a matching.sha256checksum. - Artifact naming helpers correctly normalize
darwin -> macos,win32 -> windows, and select.zipfor Windows vs.tar.gzelsewhere. - The workflow supports both manual dispatch and
v*tag pushes across Linux, macOS, and Windows. - Naming behavior is covered by tests, and CI is green on all three OSes.
Non-blocking note
- scripts/package-release.ts — Linux/macOS archives are created with
tar -C ${stagingDir} -czf ${archivePath} ., so extracting the tarball places files directly into the current directory instead of under a top-levelzero-v<version>-<platform>-<arch>/folder. That is fine if intentional, but top-level folders are usually cleaner for release archives.
Collaborator
BlockersNone found. Non-Blocking
Looks Good
Verdict: Approve — clean release packaging foundation with working artifact generation and checksum output. |
Vasanthdev2004
approved these changes
Jun 2, 2026
Vasanthdev2004
left a comment
Collaborator
There was a problem hiding this comment.
Approved — release packaging, workflow wiring, archive naming, smoke packaging, and checksum verification all checked out locally and on a test-merge into current main.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
bun run package:releaseto build, smoke-check, package, and checksum release artifactsArtifact behavior
zero-v<version>-<platform>-<arch>.tar.gzzero-v<version>-windows-<arch>.zip.sha256fileVerification