Skip to content

Enable ignored unit tests - #3960

Merged
arturcic merged 2 commits into
GitTools:mainfrom
HHobeck:feature/enable-ignored-unit-tests
Mar 15, 2024
Merged

Enable ignored unit tests#3960
arturcic merged 2 commits into
GitTools:mainfrom
HHobeck:feature/enable-ignored-unit-tests

Conversation

@HHobeck

@HHobeck HHobeck commented Mar 15, 2024

Copy link
Copy Markdown
Contributor

Description

Close #3919

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@HHobeck

HHobeck commented Mar 15, 2024

Copy link
Copy Markdown
Contributor Author

@arturcic: Please fix this test:

[Test]
[Ignore("This test is not working on GitHub Actions")]
public void WriteVersionInfoTaskShouldLogOutputVariablesToBuildOutputInGitHubActions()

Comment thread src/GitVersion.Configuration/TrunkBasedConfigurationBuilder.cs Outdated
@arturcic

Copy link
Copy Markdown
Member

@HHobeck I think we need to remove this test

[Test]
[Ignore("Support of multiple tunks are not implemented at the moment.")]
public void VerifyNonMainMainlineVersionIdenticalAsMain()

And whenever we add support we will add tests

@HHobeck
HHobeck force-pushed the feature/enable-ignored-unit-tests branch from b4882b6 to ff3e1a2 Compare March 15, 2024 11:00
@arturcic
arturcic enabled auto-merge March 15, 2024 11:10
@arturcic
arturcic merged commit 6a6687c into GitTools:main Mar 15, 2024
@mergify

mergify Bot commented Mar 15, 2024

Copy link
Copy Markdown
Contributor

Thank you @HHobeck for your contribution!

@arturcic arturcic mentioned this pull request Mar 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Review Ignored unit tests

2 participants