Change GitVersionInformation C# template ('const string' instead of 'static string') - #3102
Closed
kvasnevskyivlad wants to merge 1 commit into
Closed
Change GitVersionInformation C# template ('const string' instead of 'static string')#3102kvasnevskyivlad wants to merge 1 commit into
kvasnevskyivlad wants to merge 1 commit into
Conversation
Member
|
@kvasnevskiy, the breaking change is how existing reflection code works. If we change from |
asbjornu
requested changes
May 4, 2022
asbjornu
left a comment
asbjornu
left a comment
Member
There was a problem hiding this comment.
I'm not opposed to implement this, I just think we need to do it on main and fold it into v6 and not release it as a part of v5.
Author
ok, If I get you right @asbjornu, I just need to reopen PR with |
Member
|
@kvasnevskiy right |
Author
|
Closed and will reopen on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed GitVersionInformation C# template from
static stringtoconst stringas discussed in #3095. Also I tested this with reflection and I didn't find any problems, I am able to get GitVersionInformation through reflection, maybe I missed smth. But as was mentioned in #3095 this change should be breaking, so if it's breaking please let me know what exactly stopped working and how I can test it.