Skip to content

Added the icon and title to the site - #56

Merged
mehul-m-prajapati merged 5 commits into
GitMetricsLab:mainfrom
parassareen4:main
Jan 15, 2025
Merged

Added the icon and title to the site#56
mehul-m-prajapati merged 5 commits into
GitMetricsLab:mainfrom
parassareen4:main

Conversation

@parassareen4

@parassareen4 parassareen4 commented Dec 5, 2024

Copy link
Copy Markdown
Contributor

Related Issue


Description


How Has This Been Tested?


Screenshots (if applicable)


Type of Change

  • Bug fix
  • New feature
  • Code style update
  • Breaking change
  • Documentation update

@netlify

netlify Bot commented Dec 5, 2024

Copy link
Copy Markdown

Deploy Preview for github-spy ready!

Name Link
🔨 Latest commit cd05948
🔍 Latest deploy log https://app.netlify.com/sites/github-spy/deploys/6752545e2a8a630008440eab
😎 Deploy Preview https://deploy-preview-56--github-spy.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mehul-m-prajapati

Copy link
Copy Markdown
Collaborator

@parassareen4 : use a proper commit message.

@parassareen4
parassareen4 force-pushed the main branch 2 times, most recently from b2000a3 to 13e4a75 Compare December 5, 2024 04:39
- Corrected passport authentication flow for login route.
- Fixed CORS setup to handle credentials in frontend requests.
- Implemented session handling for login and signup at (/signup)and(/login).
- Updated API endpoints to return appropriate error messages and status codes
@parassareen4

Copy link
Copy Markdown
Contributor Author

signup is on /signup route and login on /login

@yashksaini-coder yashksaini-coder left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change the icon file name

Comment thread backend/server.js
Comment thread index.html
Comment thread src/Routes/Login/Login.tsx
Comment thread src/Routes/Router.tsx
Comment thread src/Routes/Signup/Signup.tsx
Comment thread src/components/Navbar.tsx
Comment thread src/Routes/Signup/Signup.tsx Outdated

@yashksaini-coder yashksaini-coder left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything is good just try to write good code for backend

Comment thread .env.example

@parassareen4 parassareen4 left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any changes needed here?

Comment thread index.html
Comment thread src/Routes/Router.tsx
Comment thread src/Routes/Signup/Signup.tsx Outdated
Comment thread .env.example
@yashksaini-coder

Copy link
Copy Markdown

any changes needed here?

@parassareen4 good all changes look fine to me, @mehul-m-prajapati please look into this PR. I think it's good enough to be merged now.

@yashksaini-coder

Copy link
Copy Markdown

@mehul-m-prajapati Kindly merge this PR

@mehul-m-prajapati

Copy link
Copy Markdown
Collaborator

@yashksaini-coder : okay, I will test and merge today.

@parassareen4

Copy link
Copy Markdown
Contributor Author

@yashksaini-coder : okay, I will test and merge today.

the tests went fine?

@parassareen4

Copy link
Copy Markdown
Contributor Author

@yashksaini-coder : okay, I will test and merge today.

@mehul-m-prajapati i think this can be merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add logo and favicon

3 participants