Repository navigation
Improve Telecom and Bluetooth Headset connectivity - #1841
rahul-lohra wants to merge 5 commits into
Conversation
PR checklist ✅All required conditions are satisfied:
🎉 Great job! This PR is ready for review. |
SDK Size Comparison 📏
|
8b23b05 to
723d61e
Compare
Bump AudioSwitch and fix dropped Telecom actions 1. Bump AudioSwitch to 1.1.0, which includes Twilio 1.2.5 with BLE listener support. 2. Fix dropped Telecom actions by buffering the channel. Previously, the Bluetooth request could take up to 2 seconds, causing the call accept action to be dropped when both events arrived simultaneously.
723d61e to
b86cea9
Compare
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (6)
Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 1 remain after this review. WalkthroughThe pull request updates the audioswitch dependency and microphone-selection logging. It also changes Jetpack Telecom action buffering, call-result logging, answer-error handling, and related tests. ChangesAudio Device Updates
Telecom Call Handling
Priority: ➖ Normal Estimated code review effort: 2 (Simple) | ~10 minutes Change: Bug fix Suggested reviewers: Merge Risk: ⚪ Minimal · up to Concurrent Telecom actions can be buffered, and failed answers retain the existing BUSY call-ending behavior. No concrete merge-blocking behavior risk remains. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 22.22% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 9 functions across 5 files. (1 skipped: 1 unsupported.)
✨ Finishing Touches 💡 2📝 Generate docstrings 💡
🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. A rabbit taps two mute commands, Comment |


Goal
Closes AND-1536
Problems Addressed
This PR fixes 2 issues related to Bluetooth headset audio routing and Telecom event handling:
Implementation
Upgrade AudioSwitch to
1.1.0(based on Twilio's1.2.5)Add buffering to the Telecom Channel
🎨 UI Changes
None
Testing
Expected Behavior
Previous Version (Before Fix):
Current Version (After Fix):
Summary by CodeRabbit