Skip to content

feat: added support for channelListSkeleton.maskFillColor theme property [CRNS-471] - #970

Merged
vishalnarkhede merged 1 commit into
developfrom
vishal/mask-fill-color
Nov 3, 2021
Merged

vishalnarkhede merged 1 commit into
developfrom
vishal/mask-fill-color

Conversation

@vishalnarkhede

Copy link
Copy Markdown
Contributor

🎯 Goal

Technically you can still use white_snow theme color to change this color, but white_snow is used across the SDK and will affect plenty of components. So better to give explicit customization to change this color.

πŸ›  Implementation details

  • Added a new theme key to override mask color for skeleton - channelListSkeleton.maskFillColor

🎨 UI Changes

Following table displays a customizable theme in channel list loading indicator:

const theme = {
    channelListMessenger: {
      flatList: {
        backgroundColor: 'yellow',
      },
    },
    channelListLoadingIndicator: {
      container: {
        backgroundColor: 'blue',
      },
    },
    channelListSkeleton: {
      background: {
        backgroundColor: 'red',
      },
      maskFillColor: 'black', // <-- this is the new theme key
    },
}
OOTB design Customizable design (after above theme changes)

@vishalnarkhede
vishalnarkhede merged commit e20e6c7 into develop Nov 3, 2021
@vishalnarkhede
vishalnarkhede deleted the vishal/mask-fill-color branch November 3, 2021 10:32
@vishalnarkhede

Copy link
Copy Markdown
Contributor Author

πŸŽ‰ This PR is included in version 3.10.0 πŸŽ‰

The release is available on:

Your semantic-release bot πŸ“¦πŸš€

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant