Repository navigation
fix: gracefully handle empty arrays on poll preview label - #3897
Merged
isekovanic merged 1 commit intoOct 27, 2026
Merged
Conversation
Contributor
SDK Size
|
szuperaz
approved these changes
Oct 27, 2026
isekovanic
deleted the
fix/gracefully-handle-empty-arrays-on-preview-label
branch
October 27, 2026 17:52
Contributor
|
🎉 This PR is included in version 9.10.2 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎯 Goal
This PR handles an unfortunate crash that was introduced with poll optimistic votes. Since we were not properly handling the case of having an empty array (as server-side this never happens but rather the entry is removed from the object) it would result in an uncaught error instead of just resolving gracefully.
🛠 Implementation details
Linear ticket: https://linear.app/stream/issue/REACT-1415/uncaught-error-when-removing-the-last-vote-in-a-poll
🎨 UI Changes
iOS
Android
🧪 Testing
☑️ Checklist
developbranch