Skip to content

fix: set an initial image index for the ImageGallery #1639

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
madsroskar merged 1 commit into from
Aug 11, 2022
Merged

fix: set an initial image index for the ImageGallery #1639

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions package/src/components/ImageGallery/ImageGallery.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -381,6 +381,7 @@ export const ImageGallery = <
scale,
screenHeight,
screenWidth,
selectedIndex,
setSelectedIndex,
translateX,
translateY,
Expand Down
16 changes: 16 additions & 0 deletions package/src/components/ImageGallery/hooks/useImageGalleryGestures.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,7 @@ export const useImageGalleryGestures = ({
scale,
screenHeight,
screenWidth,
selectedIndex,
setSelectedIndex,
translateX,
translateY,
Expand All @@ -57,6 +58,7 @@ export const useImageGalleryGestures = ({
scale: SharedValue<number>;
screenHeight: number;
screenWidth: number;
selectedIndex: number;
setSelectedIndex: React.Dispatch<React.SetStateAction<number>>;
translateX: SharedValue<number>;
translateY: SharedValue<number>;
Expand All @@ -82,6 +84,20 @@ export const useImageGalleryGestures = ({
const focalY = useSharedValue(0);
const index = useSharedValue(0);

/**
* if a specific image index > 0 has been passed in
* while creating the hook, set the value of the index
* reference to its value.
*
* This makes it possible to seelct an image in the list,
* and scroll/pan as normal. Prior to this,
* it was always assumed that one started at index 0 in the
* gallery.
* */
if (index.value !== selectedIndex) {
index.value = selectedIndex;
}

/**
* Shared values for movement
*/
Expand Down