Repository navigation
feat: use new generics format - #1133
Merged
Merged
Conversation
madsroskar
approved these changes
Feb 16, 2022
Contributor
|
lgtm, but we could do a pass through the documentation with Grammarly or similar, I think |
Co-authored-by: Mads Røskar <mads.roskar@getstream.io>
vishalnarkhede
commented
Feb 17, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎯 Goal
This PR focuses on converting the Stream chat generics into a single generics making the code simpler.
🛠 Implementation details
The previously written generics are now converted to a single generic as an object of the different types(attachment, channel, etc.).
🎨 UI Changes
No such UI change is done in this PR.
iOS
Android
🧪 Testing
☑️ Checklist
developbranch