Repository navigation
fix: fixing logic for resizing image url - #1123
Merged
Merged
Conversation
vishalnarkhede
requested review from
khushal87 and
madsroskar
and removed request for
khushal87 and
madsroskar
February 3, 2022 16:43
vishalnarkhede
marked this pull request as draft
February 3, 2022 16:47
vishalnarkhede
marked this pull request as ready for review
February 4, 2022 08:20
Contributor
|
I have two concerns regarding the URL polyfill included:
|
Contributor
|
charpeni/react-native-url-polyfill#366 We should probably keep a reference for this for when we work on web support as well |
Contributor
Author
|
@madsroskar do you know any better library btw? I didn't put too much thought into it honestly |
…act-native into vishal/resize-image-url-fix # Conflicts: # package/package.json # package/yarn.lock
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎯 Goal
Fixing the logic for resizing the image urls:
.stream-io-cdn.comgetResizedImageUrlfunction