Repository navigation
Fix: Error banner UI in channel list screen [CRNS - 436] - #1078
Merged
Merged
Conversation
fix: error banner ui in channel list screen
khushal87
force-pushed
the
khushal87-crns-436
branch
from
January 13, 2022 13:33
a6f1e82 to
5ba169c
Compare
vishalnarkhede
approved these changes
Jan 13, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎯 Goal
The goal of this PR is to fix the error banner UI in the Channel list screen when there's a network error or the user isn't online.
🛠 Implementation details
The text color of the error text is changed to
white(#ffffff). The background color of the UI is also fixed.Note: These changes were specific to the SDK and not the SampleApp. Tested for Dark mode too.
🎨 UI Changes
iOS
Android
🧪 Testing
☑️ Checklist
developbranch