Repository navigation
fix: Issue on android while sharing file [CRNS - 510] - #1077
Merged
Merged
Conversation
vishalnarkhede
changed the title
vishalnarkhede
approved these changes
Jan 11, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎯 Goal
This PR solves the issue of not being able to share files on android devices from the ImageGallery.
Should fix: #1015
🛠 Implementation details
There was an issue with the file name which doesn't have spaces while saving the file i.e. it was saved with (%20 characters) but when we try to read the file using the
readFileAPI it worked well and the filename was read with spaced. This is solved by changing thephoto.user.nametophoto.user.idwhich makes more sense. Thephoto.userIdis removed as it's undefined every time.🎨 UI Changes
iOS
Android
🧪 Testing
☑️ Checklist
developbranch