Repository navigation
fix(parseLinks): Make the patterns compatible with hermes - #1069
Merged
Merged
Conversation
madsroskar
force-pushed
the
regexp-hermes
branch
from
January 5, 2022 16:18
1d11a81 to
04b171d
Compare
vishalnarkhede
approved these changes
Jan 6, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎯 Goal
Hermes doesn't support named capture groups in regular expressions, which I didn't catch previously. I think e2e tests would be the most sensible way to catch this automatically, but I'll look a little into it later in the week to see if anything else makes sense. For now, I've tested the functionality with jest (so on V8), and manually tested on Android and iOS for see that it works with Hermes.
This fixes the issue of building the app currently on v4.0.0-beta.2
🎨 UI Changes
None
🧪 Testing
Described above
☑️ Checklist
developbranch