Skip to content

build: Run prettier for documentation with lint script - #1022

Merged
vishalnarkhede merged 1 commit into
v4.0.0from
mads/add-docs-linting-to-script
Nov 25, 2021
Merged

vishalnarkhede merged 1 commit into
v4.0.0from
mads/add-docs-linting-to-script

Conversation

@madsroskar

Copy link
Copy Markdown
Contributor

🎯 Goal

Currently, we run prettier on docs with lint-fix but nothing with lint. This adds prettier --check on lint so errors are caught in PRs.

To test this

  1. Make a change in a .mdx file within docusaurus/, that should be caught by the linter
  2. run yarn lint in the root directory and see that it's caught
  3. run yarn lint-fix and see that it fixes that error

☑️ Checklist

  • I have signed the Stream CLA (required)
  • PR targets the develop branch
  • Commits follow the conventional commits spec
  • New code is covered by tests
  • Screenshots added for visual changes
  • Documentation is updated

@madsroskar

Copy link
Copy Markdown
Contributor Author

(This might make the check fail cause of the change in #1021 )

@vishalnarkhede
vishalnarkhede merged commit a3edba1 into v4.0.0 Nov 25, 2021
@vishalnarkhede
vishalnarkhede deleted the mads/add-docs-linting-to-script branch November 25, 2021 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants