Skip to content

chore: Upgrade SampleApp react native to 0.66.2 [CRNS-477] #1003

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vishalnarkhede merged 3 commits into from
Nov 24, 2021
Merged

chore: Upgrade SampleApp react native to 0.66.2 [CRNS-477] #1003

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0a888c6
chore: Upgrade SampleApp to rn 0.66.0
madsroskar Nov 16, 2021
2b16058
docs: Update bersion compabilities table
madsroskar Nov 16, 2021
6d63d75
style: Restore indents in build.gradle
madsroskar Nov 16, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions docusaurus/docs/reactnative/basics/getting_started.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,10 +92,11 @@ For iOS on a Mac install the pods `npx pod-install ios`.
To be able to use the Stream Chat React Native SDK, a few dependencies must meet the following version requirements:

| react-native | stream-chat-react-native (min required) | react-native-reanimated (min required) |
| - | - | - |
| 0.65 | 3.9.0 | 2.2.1 |
| 0.64 | 3.6.2 | 2.2.0 |
| 0.63 | 3.0.0 | 2.2.0 |
|--------------|-----------------------------------------|----------------------------------------|
| 0.66 | 3.9.0 | 2.2.3 |
| 0.65 | 3.9.0 | 2.2.1 |
| 0.64 | 3.6.2 | 2.2.0 |
| 0.63 | 3.0.0 | 2.2.0 |

### Additional Steps

Expand Down
1 change: 1 addition & 0 deletions examples/SampleApp/.gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ build/
.gradle
local.properties
*.iml
*.hprof

# node.js
#
Expand Down
14 changes: 12 additions & 2 deletions examples/SampleApp/android/app/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,6 +125,11 @@ def jscFlavor = 'org.webkit:android-jsc:+'
*/
def enableHermes = project.ext.react.get("enableHermes", false);

/**
* Architectures to build native code for in debug.
*/
def nativeArchitectures = project.getProperties().get("reactNativeDebugArchitectures")

android {
ndkVersion rootProject.ext.ndkVersion

Expand Down Expand Up @@ -161,6 +166,11 @@ android {
debug {
signingConfig signingConfigs.debug
}
if (nativeArchitectures) {
ndk {
abiFilters nativeArchitectures.split(',')
}
}
release {
// Caution! In production, you need to generate your own keystore file.
// see https://reactnative.dev/docs/signed-apk-android.
Expand All @@ -181,7 +191,7 @@ android {
def abi = output.getFilter(OutputFile.ABI)
if (abi != null) { // null for the universal-debug, universal-release variants
output.versionCodeOverride =
defaultConfig.versionCode * 1000 + versionCodes.get(abi)
defaultConfig.versionCode * 1000 + versionCodes.get(abi)
}

}
Expand All @@ -206,7 +216,7 @@ dependencies {
implementation 'com.google.firebase:firebase-crashlytics'
implementation 'com.google.firebase:firebase-analytics'
debugImplementation("com.facebook.flipper:flipper:${FLIPPER_VERSION}") {
exclude group:'com.facebook.fbjni'
exclude group:'com.facebook.fbjni'
}

debugImplementation("com.facebook.flipper:flipper-network-plugin:${FLIPPER_VERSION}") {
Expand Down
1 change: 0 additions & 1 deletion examples/SampleApp/android/app/src/main/res/values/styles.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
<!-- Base application theme. -->
<style name="AppTheme" parent="Theme.AppCompat.DayNight.NoActionBar">
<!-- Customize your theme here. -->
<item name="android:textColor">#000000</item>
</style>

</resources>
4 changes: 2 additions & 2 deletions examples/SampleApp/android/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,15 +7,15 @@ buildscript {
compileSdkVersion = 30
targetSdkVersion = 30
androidXCore = "1.0.2"
ndkVersion = "20.1.5948944"
ndkVersion = "21.4.7075529"
kotlinVersion = '1.3.10'
}
repositories {
google()
mavenCentral()
}
dependencies {
classpath("com.android.tools.build:gradle:4.2.1")
classpath("com.android.tools.build:gradle:4.2.2")
classpath "org.jetbrains.kotlin:kotlin-gradle-plugin:$kotlinVersion"
classpath 'com.google.gms:google-services:4.3.4'
// NOTE: Do not place your application dependencies here; they belong
Expand Down
2 changes: 1 addition & 1 deletion examples/SampleApp/android/gradle.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,4 +26,4 @@ android.useAndroidX=true
android.enableJetifier=true

# Version of flipper SDK to use with React Native
FLIPPER_VERSION=0.93.0
FLIPPER_VERSION=0.99.0
1 change: 1 addition & 0 deletions examples/SampleApp/ios/Podfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,5 +27,6 @@ target 'SampleApp' do
use_flipper!()
post_install do |installer|
react_native_post_install(installer)
__apply_Xcode_12_5_M1_post_install_workaround(installer)
end
end
Loading