Upgrade @gorhom/bottom-sheet to v4 #1053

Activity

1. andreibarabas

   assigned

   madsroskar

   and

   vishalnarkhede

   on Dec 15, 2021
2. madsroskar commented on Dec 15, 2021

   

   madsroskar

   on Dec 15, 2021

   Contributor

   More actions

   Thanks for creating the issue!

   We have a task to upgrade the dependency in our backlog, but I don't yet know how fast we'll be able to prioritize this just yet. This should not break anything in your application, and for the time being you could suppress the warning by passing it as a string in an array to the React Native LogBox (Something like LogBox.ignoreLogs(["EventEmitter.removeListener"]) for example) until we have a release ready that handles the deprecation.

   We'll get back to you when we have more information on this.

   Link so this is referenced In our Jira issue: CRNS-494

   👍React with 👍1Reacted by Andrei Barabas
3. madsroskar

   added

   Added To Backlog

   on Dec 15, 2021
4. izakfilmalter commented on Dec 15, 2021

   

   izakfilmalter

   on Dec 15, 2021

   More actions

   I just did this as a patch, lol. It does break the app forcing @gorhom/bottom-sheet@4.1.5. It's a fairly easy upgrade though.

   I had to do the following:

   1. Add enablePanDownToClose to both instances of BottomSheet.
   2. The api for snapTo changed to snapToIndex:

     -      bottomSheetRef.current.snapTo(1);
     +      bottomSheetRef.current.snapToIndex(0);
   

   3. I also had to do the following to ImageGallery.tsx

   -  const snapPoints = React.useMemo(() => [0, (screenHeight * 9) / 10], []);
   +  const snapPoints = React.useMemo(() => [(screenHeight * 9) / 10], []);
   

   That seemed to do the tick for me. I think the real upgrade would be changing these to both be Modals, but that was a larger refactor than what I wanted as a patch. The nice thing about it all is that I was able to use BottomSheetModalProvider and useBottomSheet without any other changes to this lib.
5. madsroskar commented on Dec 15, 2021

   

   madsroskar

   on Dec 15, 2021

   Contributor

   More actions

   Thanks for reporting back with the changes you made for it to work, that's very helpful.

   I think the real upgrade would be changing these to both be Modals

   The modal wrapper in v4 does look nice, we'll look into that as part of the upgrade.
6. andreibarabas commented on Dec 17, 2021

   

   andreibarabas

   on Dec 17, 2021

   ContributorAuthor

   More actions

   Thanks guys. @izakfilmalter for the patch
7. vishalnarkhede

   added

   In code review

   EnhancementNew feature or requestNew feature or request

   Awaiting New Release

   Resolved

   and removed

   In code review

   Added To Backlog

   on Jan 11, 2022
8. vishalnarkhede commented on Mar 1, 2022

   

   vishalnarkhede

   on Mar 1, 2022

   Contributor

   More actions

   Hey @andreibarabas we have published our next major version of RN Chat SDK - v4.1.0 🎉.

   This release includes the fix for this issue. Please take a look at Release Notes for details.
9. vishalnarkhede

   removed

   Awaiting New Release

   on Mar 1, 2022
10. andreibarabas commented on Mar 1, 2022

    

    andreibarabas

    on Mar 1, 2022

    ContributorAuthor

    More actions

    Yes. I can confirm it's upgraded and working now. Thanks @vishalnarkhede
11. andreibarabas

    closed this as completedon Mar 1, 2022