Repository navigation
Expose the channel state from the Compose MessageListViewModel - #6734
Conversation
PR checklist ✅All required conditions are satisfied:
🎉 Great job! This PR is ready for review. |
SDK Size Comparison 📏
|
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (3)
Included review availability: Your plan provides up to 4 included reviews per hour; 3 remain after this review. WalkthroughMessageListViewModel now exposes the controller’s nullable ChannelState as a StateFlow. The public API declaration includes the accessor, and a test checks that the exposed value is the same instance as the fixture’s ChannelState. ChangesChannel state exposure
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~8 minutes Change: Feature Suggested reviewers: Merge Risk: ⚪ Minimal · up to The Compose view model exposes the controller's channel state, with matching API metadata and a test of the exposed value. No actionable merge risk is evident. Security Architecture ReviewSecurity architecture risk: 🔵 Low · up to The new API makes channel state easier for an app to observe, including messages and member information. It forwards an existing read-only state flow rather than adding a new write operation or apparent authorization path. No security finding was established, but downstream use of the new public API is not fully known. Retained concerns Security review detailsSecurity Blast Radius
Trust Boundaries and Controls
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 3 functions across 2 files. (1 skipped: 1 unsupported.)
✨ Finishing Touches 💡 2📝 Generate docstrings 💡
🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. A rabbit checks the channel stream, Comment |
andremion
left a comment
There was a problem hiding this comment.
Looks good. One optional nit inline.
|
|
🚀 Available in v6.45.0 |



Goal
The XML
MessageListViewModelexposeschannelState, the Compose one does not. Compose apps that needloadingor thelive members have to look the state up in the client's state registry instead.
Closes AND-1570
Implementation
channelState: StateFlow<ChannelState?>to the ComposeMessageListViewModel, backed by the controller's flow,same as the XML view model.
Testing
MessageListViewModelTestchecks the view model exposes the channel state the message list observes.🤖 Generated with Claude Code
Summary by CodeRabbit