Repository navigation
Keep the thread parent's quoted message when a reply is sent - #6730
Conversation
PR checklist ✅All required conditions are satisfied:
🎉 Great job! This PR is ready for review. |
SDK Size Comparison 📏
|
|
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (2)
Included review availability: Your plan provides up to 4 included reviews per hour; 3 remain after this review. WalkthroughWhen a thread message update references a quoted message outside the thread, the update now retains the event’s existing ChangesThread reply handling
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~10 minutes Change: Bug fix Suggested reviewers: Merge Risk: ⚪ Minimal · up to The change is ready to merge after normal checks: it retains the parent’s quoted-message preview when the quote is outside the thread while preferring the thread’s copy when present. Security Architecture ReviewSecurity architecture risk: 🔵 Low · up to The change is limited to how the client preserves an existing quote preview. No new message-fetching path or access-control bypass was established, although upstream event validation and some update-ordering behavior remain unverified. Retained concerns Security review detailsSecurity Blast Radius
Trust Boundaries and Controls
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. A quoted reply stays near, Comment |
|
🚀 Available in v7.13.0 |



Goal
When a thread's parent message quotes another message, sending a reply in the thread removes the quote preview from the
parent. It comes back when the thread is reopened.
Closes AND-1553
Implementation
message.updatedfor the parent, with itsquoted_message.ThreadLogiclooked thequoted message up only among the thread's messages, which usually don't include it, so the parent lost it.
thread still takes precedence.
Testing
ThreadLogicTestcovers a quote from outside the thread, which the event now keeps, and a quote from inside the thread,where the thread's copy is used.
🤖 Generated with Claude Code
Summary by CodeRabbit