Skip to content

Update google-services.json for sample apps - #6725

Merged
gpunto merged 1 commit into
v6from
chore/v6-sample-firebase-config
Sep 24, 2026
Merged

gpunto merged 1 commit into
v6from
chore/v6-sample-firebase-config

Conversation

@gpunto

@gpunto gpunto commented Sep 23, 2026 •

Copy link
Copy Markdown
Contributor

Goal

The v6 sample apps still point at the old Firebase project, so push notifications no longer reach v6 sample builds.
Backport the configuration develop moved to in #6469.

Closes AND-1563

Implementation

  • Replace google-services.json in both sample apps with develop's stream-android-32afb configuration.
  • Add develop's placeholder src/e2e/google-services.json for the Compose sample's e2e flavor, whose package is no
    longer in the root file.

Testing

The Google Services step resolves for every sample variant (Compose demo, release, benchmark, e2e; XML demo, release,
benchmark, full). Push notifications arrive in the Compose sample demo debug build.

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Chores
    • Updated Firebase settings for the Compose and UI sample apps to use the current project configuration.
    • Added Firebase settings for the Compose sample’s E2E debug build.

@gpunto gpunto added the pr:demo-app Changes specific to demo app label Sep 23, 2026
@github-actions

Copy link
Copy Markdown
Contributor

PR checklist ✅

All required conditions are satisfied:

  • Title length is OK (or ignored by label).
  • At least one pr: label exists.
  • Sections ### Goal, ### Implementation, and ### Testing are filled (or ignored for dependabot PRs).

🎉 Great job! This PR is ready for review.

@github-actions

Copy link
Copy Markdown
Contributor

SDK Size Comparison 📏

SDK Before After Difference Status
stream-chat-android-client 5.26 MB 5.32 MB 0.06 MB 🟢
stream-chat-android-offline 5.49 MB 5.54 MB 0.05 MB 🟢
stream-chat-android-ui-components 10.64 MB 10.76 MB 0.11 MB 🟢
stream-chat-android-compose 12.87 MB 13.15 MB 0.28 MB 🟡

@sonarqubecloud

Copy link
Copy Markdown

@gpunto
gpunto marked this pull request as ready for review September 23, 2026 16:20
@gpunto
gpunto requested a review from a team as a code owner September 23, 2026 16:20
@gpunto
gpunto enabled auto-merge (squash) September 23, 2026 16:20
@coderabbitai

coderabbitai Bot commented Sep 23, 2026

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Advanced

Run ID: 7489180c-4ea2-499e-9715-a5841d8e2b8c

📥 Commits

Reviewing files that changed from the base of the PR and between b1e6147 and 8e382f3.

📒 Files selected for processing (3)
  • stream-chat-android-compose-sample/google-services.json
  • stream-chat-android-compose-sample/src/e2e/google-services.json
  • stream-chat-android-ui-components-sample/google-services.json

Included review availability: Your plan provides up to 4 included reviews per hour; 1 remains after this review.


Walkthrough

The Compose and UI sample Firebase configurations now use a new project registration and updated client entries. A separate placeholder configuration was added for the Compose E2E debug package.

Changes

Sample Firebase registrations

Layer / File(s) Summary
Update sample Firebase registrations
stream-chat-android-compose-sample/google-services.json, stream-chat-android-ui-components-sample/google-services.json
Both configurations now reference project stream-android-32afb. Their client lists contain the Compose and UI sample packages and debug variants, with updated app IDs and a shared API key. OAuth and app-invite client entries were removed.
Add Compose E2E placeholder configuration
stream-chat-android-compose-sample/src/e2e/google-services.json
Added a Firebase configuration for package io.getstream.chat.android.compose.sample.e2etest.debug, using placeholder project and app identifiers and a fake API key.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to 8e382

This change points the Compose and UI sample apps at the updated Firebase project and gives the Compose end-to-end test build its own placeholder Firebase configuration. Each enabled sample build has a matching Firebase app entry, and no production SDK code changes. The change is ready to merge.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the main change: updating Google Services configuration for the sample apps.
Description check ✅ Passed The description includes the goal, implementation, linked issue, and testing results. The UI Changes, contributor checklist, reviewer checklist, and GIF sections are not completed, but they are not cr…
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

A rabbit checks the project keys,
Then hops through client entries with ease.
The E2E file joins the stack,
With placeholder values packed.
OAuth lists are out of sight,
And carrots wait beneath the moonlight.

Comment @coderabbitai help to get the list of available commands.

@gpunto
gpunto merged commit fe91c1f into v6 Sep 24, 2026
20 of 21 checks passed
@gpunto
gpunto deleted the chore/v6-sample-firebase-config branch September 24, 2026 10:04
@stream-public-bot stream-public-bot added the released Included in a release label Sep 24, 2026
@stream-public-bot

Copy link
Copy Markdown
Contributor

🚀 Available in v6.44.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr:demo-app Changes specific to demo app released Included in a release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants