Repository navigation
Remove the dead video call, thread request, and upstream channel read DTOs - #6692
Merged
Merged
Conversation
Contributor
PR checklist ✅All required conditions are satisfied:
🎉 Great job! This PR is ready for review. |
Contributor
SDK Size Comparison 📏
|
|
gpunto
marked this pull request as ready for review
September 10, 2026 11:50
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (7)
💤 Files with no reviewable changes (7)
Included review availability: Your plan provides up to 4 included reviews per hour; 3 remain after this review. WalkthroughThe change removes unused internal channel, thread, and video call DTO, request, and response model declarations from the Android client. ChangesObsolete internal model removal
Estimated code review effort: 1 (Trivial) | ~5 minutes Merge Risk: ⚪ Minimal · up to This cleanup removes unused internal models without changing client behavior or public API surface, so it is mergeable with normal checks. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. A rabbit checks the model nest Comment |
gpunto
enabled auto-merge
September 10, 2026 13:13
VelikovPetar
approved these changes
Sep 11, 2026
Contributor
|
🚀 Available in v7.12.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal
Delete nine hand-written DTO classes in
api2/modelthat nothing references any more, so theremaining count reflects actual migration work.
Part of AND-1291
Implementation
VideoCallDto,HMSDto,AgoraDto,VideoCallInfoDto,CreateVideoCallResponse,VideoCallCreateRequestandVideoCallTokenRequest. It is a closedgraph rooted at
CreateVideoCallResponse, andVideoCallApiis already gone.GetThreadRequest.ThreadsApi.getThreadtakes query parameters, so the body type itdocuments no longer exists.
UpstreamChannelUserRead. Reads are never sent upstream; onlyDownstreamChannelUserReadis in use, and the file is renamed after it to satisfy the ktlint filename rule.
All nine are
internal, so the API dump is unchanged.Testing
No behaviour to test. Each class was confirmed unreferenced across the whole repo, including
tests: the only hits were their own declarations and each other.
The stale
VideoCallCreateRequestandVideoCallTokenRequestlines left inbaseline-prof.txtare untouched. That file already names the long-deleted
VideoCallApi, and unresolvable profilerules are skipped at install time.
Summary by CodeRabbit