Archive bound-dark-window-exceptions - #165
Merged
Merged
Conversation
Applies the change's deltas into the two capability specs and moves the brief to `openspec/changes/archive/2026-08-07-bound-dark-window-exceptions/`. Spec updates: responsibility-contract (~1), standing-rules (+3 ~2). `openspec validate --all --strict` passes (45 items). The two MODIFIED standing-rules bodies were checked to be supersets of their pre-archive baselines, so no landed #127/#128 documentation was reverted by the wholesale requirement replacement archive performs. The brief stays in place: #130 and #131 depend on the bounded exception semantics.
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
📝 WalkthroughSummary by CodeRabbit
WalkthroughThe PR archives specifications for bounded dark-window exceptions, fail-closed ChangesDark-window exception controls
Estimated code review effort: 3 (Moderate) | ~20 minutes Possibly related issues
Possibly related PRs
Poem
Caution Pre-merge checks failedPlease resolve all errors before merging. Addressing warnings is optional.
❌ Failed checks (1 error)
✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 8
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@graphify-out/2026-08-07/GRAPH_REPORT.md`:
- Line 4773: Fix the generator or source producing the D-004 decision text so
its inline-code delimiters do not nest: use one code span for the complete
decision text or leave gate() as plain text. Regenerate both affected outputs
with graphify update .: graphify-out/2026-08-07/GRAPH_REPORT.md lines 4773-4773
and graphify-out/GRAPH_REPORT.md lines 4817-4817; do not edit generated reports
manually.
In
`@graphify-out/cache/ast/v0.9.10/033e11f4e89f596384e92e588a7fdf4c73a345b5e3fe762e156760392ccb513e.json`:
- Line 1: Update the Graphify node-ID generation to derive IDs from
repository-relative source paths rather than checkout-specific absolute paths,
preserving the existing relative source_file values. Apply this at the
ID-generation implementation, not in generated output; then run graphify update
. to regenerate all affected graphify-out/cache files and graph.json files. The
listed generated files require no direct edits.
In
`@graphify-out/cache/ast/v0.9.10/e782ecb1ca4600262d6a04f14c13bf48b621b6be35f2e69a56019e184fef6dbf.json`:
- Line 1: Update the AST node ID generation used by Graphify to derive IDs from
repository-relative paths instead of host-specific absolute prefixes. Regenerate
all cached AST output by running graphify update . so every node, including the
affected document nodes and edges, uses the normalized IDs.
In `@openspec/changes/archive/2026-08-07-bound-dark-window-exceptions/design.md`:
- Line 23: Label the pseudocode Markdown fence in
openspec/changes/archive/2026-08-07-bound-dark-window-exceptions/design.md at
lines 23-23 with an appropriate language identifier, and label both pseudocode
fences in
openspec/changes/archive/2026-08-07-bound-dark-window-exceptions/proposal.md at
lines 15-29; leave the fenced content unchanged.
- Around line 53-57: The notification bound currently implies a cumulative
limit, but max_pending_exceptions only limits unresolved exceptions. In
openspec/changes/archive/2026-08-07-bound-dark-window-exceptions/design.md lines
53-57, narrow the claim to concurrent or outstanding notifications, or add an
explicit lifetime, rate, or aggregation control; in
openspec/changes/archive/2026-08-07-bound-dark-window-exceptions/proposal.md
lines 64-74, likewise narrow the invariant and notification claim to outstanding
exceptions. Ensure both documents consistently describe the actual bound.
In
`@openspec/changes/archive/2026-08-07-bound-dark-window-exceptions/specs/standing-rules/spec.md`:
- Around line 96-99: Replace “idempotent per rule” with “idempotent per stable
request identity within a rule version” in the archived standing-rules
specification at
openspec/changes/archive/2026-08-07-bound-dark-window-exceptions/specs/standing-rules/spec.md
lines 96-99 and apply the same wording in the canonical specification at
openspec/specs/standing-rules/spec.md lines 69-71; make no other changes.
- Around line 61-63: Extend the lifecycle invalidation requirement to cover
startup recovery of stored invalid Allow rules: retire the rule, stale all
unresolved pending exceptions, and record durable evidence atomically. Apply
this to
openspec/changes/archive/2026-08-07-bound-dark-window-exceptions/specs/standing-rules/spec.md:61-63
and openspec/specs/standing-rules/spec.md:331-333; add the corresponding
startup-retirement acceptance scenario in
openspec/changes/archive/2026-08-07-bound-dark-window-exceptions/proposal.md:52-62
and implementation plus boundary-test tasks in
openspec/changes/archive/2026-08-07-bound-dark-window-exceptions/tasks.md:41-58.
In `@openspec/openspine-change-sequence.md`:
- Around line 123-134: Reduce the entries around the change-sequence sections to
dependency/decomposition edges and the archive-retention rationale only. Remove
duplicated normative details, including claims that pause or compatibility
changes stale pending exceptions, and align the summary with the canonical
capability specifications, where reviewed-context or compatibility changes use
consume-time rejection without a staleness write.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: c435e235-53c2-4847-898b-fcaf192b66cc
📒 Files selected for processing (25)
graphify-out/.graphify_labels.jsongraphify-out/2026-08-07/.graphify_labels.jsongraphify-out/2026-08-07/GRAPH_REPORT.mdgraphify-out/2026-08-07/graph.jsongraphify-out/2026-08-07/manifest.jsongraphify-out/GRAPH_REPORT.mdgraphify-out/cache/ast/v0.9.10/033e11f4e89f596384e92e588a7fdf4c73a345b5e3fe762e156760392ccb513e.jsongraphify-out/cache/ast/v0.9.10/13e085e221dcc7979fca5b48489b1727b39a34daaab1e50dbbfdb0debc6fa11d.jsongraphify-out/cache/ast/v0.9.10/2f0c04e8a12bc10aa047a29ede661c03b27f183e2fef18507695c726f0750ace.jsongraphify-out/cache/ast/v0.9.10/5a49a5bfc5da439869c675432b2c75374bcacdaf1aa9e9e9d12421baeb2038bb.jsongraphify-out/cache/ast/v0.9.10/5f3b08d2d3129c85416def1fd7539ae21af4cc91ec5a05f64a02070b4cf81559.jsongraphify-out/cache/ast/v0.9.10/cd6a17f64b60a4a02bfa97472f28d93b65d0df974d0d05344fa00077be1e4a1e.jsongraphify-out/cache/ast/v0.9.10/cebab2dc4930a41c28629b44e0752f33dd20579598e83a5db3b6ec250f57c15b.jsongraphify-out/cache/ast/v0.9.10/e782ecb1ca4600262d6a04f14c13bf48b621b6be35f2e69a56019e184fef6dbf.jsongraphify-out/cache/stat-index.jsongraphify-out/graph.jsongraphify-out/manifest.jsonopenspec/changes/archive/2026-08-07-bound-dark-window-exceptions/design.mdopenspec/changes/archive/2026-08-07-bound-dark-window-exceptions/proposal.mdopenspec/changes/archive/2026-08-07-bound-dark-window-exceptions/specs/responsibility-contract/spec.mdopenspec/changes/archive/2026-08-07-bound-dark-window-exceptions/specs/standing-rules/spec.mdopenspec/changes/archive/2026-08-07-bound-dark-window-exceptions/tasks.mdopenspec/openspine-change-sequence.mdopenspec/specs/responsibility-contract/spec.mdopenspec/specs/standing-rules/spec.md
| _High betweenness centrality (0.029) - this node is a cross-community bridge._ | ||
| - **Why does `Timestamp` connect `ADDED Requirements` to `D-004 — Every effectful action goes through `gate()``, `D-022 — Agent-owned inbox is distinct from owner mailbox access`, `D-023 — OpenSpine is the substrate; Lyra is a product built on it`, `banner`, `Requirements`, `StoreError`, `AppState`, `Lifecycle`, `OpenSpine Agent-OS Design Log`, `D-013 — Dynamic behavior easy; dynamic authority hard`, `Overlay & key model`, `D-010 — Model calls with private context go through model gateway`, `Requirements`, `Design: OpenSpine development process`, `offset.rs`, `D-035 — Kernel advertises a separate `advertise_endpoint` from its `bind_addr`; no Unix-domain-socket transport for `ProcessDriver``, `standing_rules_pending.rs`, `roadmap.md`, `threat-model.md`, `Proposal: Define OpenSpine development process`, `proposal.rs`, `SKILL.md`, `Result`, `README.md`, `SKILL.md`, `Tasks: Backfill implemented capability specs`, `connectors_tests.rs`, `String`, `Vec`, `Result`?** | ||
| _High betweenness centrality (0.025) - this node is a cross-community bridge._ | ||
| - **Why does `Timestamp` connect `ADDED Requirements` to `D-004 — Every effectful action goes through `gate()``, `SKILL.md`, `Vec`, `D-022 — Agent-owned inbox is distinct from owner mailbox access`, `D-023 — OpenSpine is the substrate; Lyra is a product built on it`, `banner`, `Requirements`, `content.d.ts`, `StoreError`, `SKILL.md`, `Lifecycle`, `Proposal: Refactor kernel registries`, `OpenSpine Agent-OS Design Log`, `ApprovalRecord`, `D-013 — Dynamic behavior easy; dynamic authority hard`, `artifact_propose.rs`, `Overlay & key model`, `D-010 — Model calls with private context go through model gateway`, `Requirements`, `properties`, `Design: OpenSpine development process`, `offset.rs`, `D-035 — Kernel advertises a separate `advertise_endpoint` from its `bind_addr`; no Unix-domain-socket transport for `ProcessDriver``, `standing_rules_pending.rs`, `roadmap.md`, `threat-model.md`, `Proposal: Define OpenSpine development process`, `proposal.rs`, `Result`, `README.md`, `SKILL.md`, `Requirement: Compatibility MUST fail closed for dangling learned references`, `Tasks: Backfill implemented capability specs`, `ADDED Requirements`, `connectors_tests.rs`, `String`, `mod.rs`, `Result`?** |
There was a problem hiding this comment.
📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win
Fix the malformed inline-code span in both generated reports.
The D-004 text opens an inline-code span before gate() and then opens another span inside it. This triggers markdownlint MD038 and can render the suggested question incorrectly. Emit one code span for the complete decision text, or make gate() plain text. Correct the source or generator, then regenerate both reports.
graphify-out/2026-08-07/GRAPH_REPORT.md#L4773-L4773: regenerate the line with valid inline-code delimiters.graphify-out/GRAPH_REPORT.md#L4817-L4817: regenerate the line with valid inline-code delimiters.
As per coding guidelines, graphify-out/ is generated output; after code changes, refresh it with graphify update . rather than manually maintaining it.
🧰 Tools
🪛 markdownlint-cli2 (0.23.2)
[warning] 4773-4773: Spaces inside code span elements
(MD038, no-space-in-code)
📍 Affects 2 files
graphify-out/2026-08-07/GRAPH_REPORT.md#L4773-L4773(this comment)graphify-out/GRAPH_REPORT.md#L4817-L4817
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@graphify-out/2026-08-07/GRAPH_REPORT.md` at line 4773, Fix the generator or
source producing the D-004 decision text so its inline-code delimiters do not
nest: use one code span for the complete decision text or leave gate() as plain
text. Regenerate both affected outputs with graphify update .:
graphify-out/2026-08-07/GRAPH_REPORT.md lines 4773-4773 and
graphify-out/GRAPH_REPORT.md lines 4817-4817; do not edit generated reports
manually.
Sources: Coding guidelines, Linters/SAST tools
| @@ -0,0 +1 @@ | |||
| {"nodes": [{"id": "users_george_repos_openspine_openspec_changes_archive_2026_08_07_bound_dark_window_exceptions_tasks_md", "label": "tasks.md", "file_type": "document", "source_file": "openspec/changes/archive/2026-08-07-bound-dark-window-exceptions/tasks.md", "source_location": "L1"}, {"id": "users_george_repos_openspine_openspec_changes_archive_2026_08_07_bound_dark_window_exceptions_tasks_tasks", "label": "Tasks", "file_type": "document", "source_file": "openspec/changes/archive/2026-08-07-bound-dark-window-exceptions/tasks.md", "source_location": "L1"}, {"id": "users_george_repos_openspine_openspec_changes_archive_2026_08_07_bound_dark_window_exceptions_tasks_1_make_the_exception_allowance_reviewable_data", "label": "1. Make the exception allowance reviewable data", "file_type": "document", "source_file": "openspec/changes/archive/2026-08-07-bound-dark-window-exceptions/tasks.md", "source_location": "L3"}, {"id": "users_george_repos_openspine_openspec_changes_archive_2026_08_07_bound_dark_window_exceptions_tasks_2_enforce_the_cap_atomically_in_the_scheduling_transaction", "label": "2. Enforce the cap atomically in the scheduling transaction", "file_type": "document", "source_file": "openspec/changes/archive/2026-08-07-bound-dark-window-exceptions/tasks.md", "source_location": "L9"}, {"id": "users_george_repos_openspine_openspec_changes_archive_2026_08_07_bound_dark_window_exceptions_tasks_3_report_suppression_as_an_ordinary_approval", "label": "3. Report suppression as an ordinary approval", "file_type": "document", "source_file": "openspec/changes/archive/2026-08-07-bound-dark-window-exceptions/tasks.md", "source_location": "L17"}, {"id": "users_george_repos_openspine_openspec_changes_archive_2026_08_07_bound_dark_window_exceptions_tasks_4_bind_the_pending_exception_to_the_reviewed_context", "label": "4. Bind the pending exception to the reviewed context", "file_type": "document", "source_file": "openspec/changes/archive/2026-08-07-bound-dark-window-exceptions/tasks.md", "source_location": "L23"}, {"id": "users_george_repos_openspine_openspec_changes_archive_2026_08_07_bound_dark_window_exceptions_tasks_5_account_for_exceptions_separately_from_quota", "label": "5. Account for exceptions separately from quota", "file_type": "document", "source_file": "openspec/changes/archive/2026-08-07-bound-dark-window-exceptions/tasks.md", "source_location": "L29"}, {"id": "users_george_repos_openspine_openspec_changes_archive_2026_08_07_bound_dark_window_exceptions_tasks_6_stale_open_exceptions_on_every_lifecycle_change", "label": "6. Stale open exceptions on every lifecycle change", "file_type": "document", "source_file": "openspec/changes/archive/2026-08-07-bound-dark-window-exceptions/tasks.md", "source_location": "L35"}, {"id": "users_george_repos_openspine_openspec_changes_archive_2026_08_07_bound_dark_window_exceptions_tasks_7_give_the_communication_allow_prohibition_enforcing_code", "label": "7. Give the communication Allow prohibition enforcing code", "file_type": "document", "source_file": "openspec/changes/archive/2026-08-07-bound-dark-window-exceptions/tasks.md", "source_location": "L41"}, {"id": "users_george_repos_openspine_openspec_changes_archive_2026_08_07_bound_dark_window_exceptions_tasks_8_test_the_boundaries", "label": "8. Test the boundaries", "file_type": "document", "source_file": "openspec/changes/archive/2026-08-07-bound-dark-window-exceptions/tasks.md", "source_location": "L47"}, {"id": "users_george_repos_openspine_openspec_changes_archive_2026_08_07_bound_dark_window_exceptions_tasks_9_document_and_record_authority_sensitive", "label": "9. Document and record (authority-sensitive)", "file_type": "document", "source_file": "openspec/changes/archive/2026-08-07-bound-dark-window-exceptions/tasks.md", "source_location": "L60"}], "edges": [{"source": "users_george_repos_openspine_openspec_changes_archive_2026_08_07_bound_dark_window_exceptions_tasks_md", "target": "users_george_repos_openspine_openspec_changes_archive_2026_08_07_bound_dark_window_exceptions_tasks_tasks", "relation": "contains", "confidence": "EXTRACTED", "source_file": "openspec/changes/archive/2026-08-07-bound-dark-window-exceptions/tasks.md", "source_location": "L1", "weight": 1.0}, {"source": "users_george_repos_openspine_openspec_changes_archive_2026_08_07_bound_dark_window_exceptions_tasks_tasks", "target": "users_george_repos_openspine_openspec_changes_archive_2026_08_07_bound_dark_window_exceptions_tasks_1_make_the_exception_allowance_reviewable_data", "relation": "contains", "confidence": "EXTRACTED", "source_file": "openspec/changes/archive/2026-08-07-bound-dark-window-exceptions/tasks.md", "source_location": "L3", "weight": 1.0}, {"source": "users_george_repos_openspine_openspec_changes_archive_2026_08_07_bound_dark_window_exceptions_tasks_tasks", "target": "users_george_repos_openspine_openspec_changes_archive_2026_08_07_bound_dark_window_exceptions_tasks_2_enforce_the_cap_atomically_in_the_scheduling_transaction", "relation": "contains", "confidence": "EXTRACTED", "source_file": "openspec/changes/archive/2026-08-07-bound-dark-window-exceptions/tasks.md", "source_location": "L9", "weight": 1.0}, {"source": "users_george_repos_openspine_openspec_changes_archive_2026_08_07_bound_dark_window_exceptions_tasks_tasks", "target": "users_george_repos_openspine_openspec_changes_archive_2026_08_07_bound_dark_window_exceptions_tasks_3_report_suppression_as_an_ordinary_approval", "relation": "contains", "confidence": "EXTRACTED", "source_file": "openspec/changes/archive/2026-08-07-bound-dark-window-exceptions/tasks.md", "source_location": "L17", "weight": 1.0}, {"source": "users_george_repos_openspine_openspec_changes_archive_2026_08_07_bound_dark_window_exceptions_tasks_tasks", "target": "users_george_repos_openspine_openspec_changes_archive_2026_08_07_bound_dark_window_exceptions_tasks_4_bind_the_pending_exception_to_the_reviewed_context", "relation": "contains", "confidence": "EXTRACTED", "source_file": "openspec/changes/archive/2026-08-07-bound-dark-window-exceptions/tasks.md", "source_location": "L23", "weight": 1.0}, {"source": "users_george_repos_openspine_openspec_changes_archive_2026_08_07_bound_dark_window_exceptions_tasks_tasks", "target": "users_george_repos_openspine_openspec_changes_archive_2026_08_07_bound_dark_window_exceptions_tasks_5_account_for_exceptions_separately_from_quota", "relation": "contains", "confidence": "EXTRACTED", "source_file": "openspec/changes/archive/2026-08-07-bound-dark-window-exceptions/tasks.md", "source_location": "L29", "weight": 1.0}, {"source": "users_george_repos_openspine_openspec_changes_archive_2026_08_07_bound_dark_window_exceptions_tasks_tasks", "target": "users_george_repos_openspine_openspec_changes_archive_2026_08_07_bound_dark_window_exceptions_tasks_6_stale_open_exceptions_on_every_lifecycle_change", "relation": "contains", "confidence": "EXTRACTED", "source_file": "openspec/changes/archive/2026-08-07-bound-dark-window-exceptions/tasks.md", "source_location": "L35", "weight": 1.0}, {"source": "users_george_repos_openspine_openspec_changes_archive_2026_08_07_bound_dark_window_exceptions_tasks_tasks", "target": "users_george_repos_openspine_openspec_changes_archive_2026_08_07_bound_dark_window_exceptions_tasks_7_give_the_communication_allow_prohibition_enforcing_code", "relation": "contains", "confidence": "EXTRACTED", "source_file": "openspec/changes/archive/2026-08-07-bound-dark-window-exceptions/tasks.md", "source_location": "L41", "weight": 1.0}, {"source": "users_george_repos_openspine_openspec_changes_archive_2026_08_07_bound_dark_window_exceptions_tasks_tasks", "target": "users_george_repos_openspine_openspec_changes_archive_2026_08_07_bound_dark_window_exceptions_tasks_8_test_the_boundaries", "relation": "contains", "confidence": "EXTRACTED", "source_file": "openspec/changes/archive/2026-08-07-bound-dark-window-exceptions/tasks.md", "source_location": "L47", "weight": 1.0}, {"source": "users_george_repos_openspine_openspec_changes_archive_2026_08_07_bound_dark_window_exceptions_tasks_tasks", "target": "users_george_repos_openspine_openspec_changes_archive_2026_08_07_bound_dark_window_exceptions_tasks_9_document_and_record_authority_sensitive", "relation": "contains", "confidence": "EXTRACTED", "source_file": "openspec/changes/archive/2026-08-07-bound-dark-window-exceptions/tasks.md", "source_location": "L60", "weight": 1.0}], "input_tokens": 0, "output_tokens": 0} No newline at end of file | |||
There was a problem hiding this comment.
🗄️ Data Integrity & Integration | 🟠 Major | 🏗️ Heavy lift
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
set -euo pipefail
files=(
graphify-out/cache/ast/v0.9.10/033e11f4e89f596384e92e588a7fdf4c73a345b5e3fe762e156760392ccb513e.json
graphify-out/cache/ast/v0.9.10/13e085e221dcc7979fca5b48489b1727b39a34daaab1e50dbbfdb0debc6fa11d.json
graphify-out/cache/ast/v0.9.10/2f0c04e8a12bc10aa047a29ede661c03b27f183e2fef18507695c726f0750ace.json
graphify-out/cache/ast/v0.9.10/5a49a5bfc5da439869c675432b2c75374bcacdaf1aa9e9e9d12421baeb2038bb.json
graphify-out/cache/ast/v0.9.10/5f3b08d2d3129c85416def1fd7539ae21af4cc91ec5a05f64a02070b4cf81559.json
graphify-out/cache/ast/v0.9.10/cd6a17f64b60a4a02bfa97472f28d93b65d0df974d0d05344fa00077be1e4a1e.json
graphify-out/cache/ast/v0.9.10/cebab2dc4930a41c28629b44e0752f33dd20579598e83a5db3b6ec250f57c15b.json
)
if rg -n '"id": "[^"]*(users_[^"]+_repos_|/Users/|/home/|/workspace/)' "${files[@]}"; then
echo "Machine-specific path fragments remain in graph node IDs." >&2
exit 1
fi
echo "No machine-specific path fragments found in graph node IDs."Repository: George-RD/openspine
Length of output: 50376
🏁 Script executed:
#!/bin/bash
set -euo pipefail
printf '%s\n' '--- tracked Graphify-related files ---'
git ls-files | rg '(^|/)(graphify|graphify-out|openspec)(/|$)|package.json|README|Makefile|Taskfile|justfile' | head -300
printf '%s\n' '--- ID/path generation references ---'
rg -n --hidden -g '!graphify-out/**' \
'source_file|sourceLocation|file_type|node.*id|graph.*id|absolute|relative|realpath|process\.cwd|cwd\(|Graphify|graphify' . \
| head -400
printf '%s\n' '--- generated cache file inventory and metadata ---'
find graphify-out/cache/ast/v0.9.10 -maxdepth 1 -type f -name '*.json' -print | sort | head -100
rg -n --hidden 'users_george_repos_openspine|/Users/|/home/|/workspace/' graphify-out/cache/ast/v0.9.10 -g '*.json' \
| cut -d: -f1 | sort | uniq -c | sort -nr | head -100Repository: George-RD/openspine
Length of output: 25507
🏁 Script executed:
#!/bin/bash
set -u
printf '%s\n' '--- Graphify root metadata ---'
for f in graphify-out/.graphify_root graphify-out/.graphify_python graphify-out/.graphify_labels.json graphify-out/2026-08-07/manifest.json graphify-out/2026-08-07/graph.json; do
if [ -f "$f" ]; then
echo "### $f"
sed -n '1,80p' "$f"
fi
done
printf '%s\n' '--- repository documentation references ---'
rg -n --hidden -g '!graphify-out/cache/**' -g '!*.json' \
'graphify|Graphify|node ID|node id|source_file|stable|absolute path|relative path' \
README.md .omp openspec 2>/dev/null | head -300
printf '%s\n' '--- exact seven-file machine-fragment counts ---'
python3 - <<'PY'
import json
from pathlib import Path
files = [
"graphify-out/cache/ast/v0.9.10/033e11f4e89f596384e92e588a7fdf4c73a345b5e3fe762e156760392ccb513e.json",
"graphify-out/cache/ast/v0.9.10/13e085e221dcc7979fca5b48489b1727b39a34daaab1e50dbbfdb0debc6fa11d.json",
"graphify-out/cache/ast/v0.9.10/2f0c04e8a12bc10aa047a29ede661c03b27f183e2fef18507695c726f0750ace.json",
"graphify-out/cache/ast/v0.9.10/5a49a5bfc5da439869c675432b2c75374bcacdaf1aa9e9e9d12421baeb2038bb.json",
"graphify-out/cache/ast/v0.9.10/5f3b08d2d3129c85416def1fd7539ae21af4cc91ec5a05f64a02070b4cf81559.json",
"graphify-out/cache/ast/v0.9.10/cd6a17f64b60a4a02bfa97472f28d93b65d0df974d0d05344fa00077be1e4a1e.json",
"graphify-out/cache/ast/v0.9.10/cebab2dc4930a41c28629b44e0752f33dd20579598e83a5db3b6ec250f57c15b.json",
]
for name in files:
p = Path(name)
data = json.loads(p.read_text())
ids = [n.get("id","") for n in data.get("nodes",[])]
sources = sorted(set(n.get("source_file") for n in data.get("nodes",[]) if n.get("source_file")))
bad = [i for i in ids if any(x in i for x in ("users_george_repos_openspine", "/Users/", "/home/", "/workspace/"))]
print(f"{p.name}: nodes={len(ids)} machine_specific_ids={len(bad)}")
print(f" source_files={sources[:3]}")
print(f" id_samples={ids[:2]}")
PYRepository: George-RD/openspine
Length of output: 21556
🏁 Script executed:
#!/bin/bash
set -u
python3 - <<'PY'
import json
from pathlib import Path
from collections import Counter
root = Path("graphify-out")
bad_markers = ("users_george_repos_openspine", "/Users/", "/home/", "/workspace/")
counts = Counter()
bad_files = []
bad_values = []
for p in root.rglob("*"):
if not p.is_file():
continue
try:
text = p.read_text(errors="replace")
except Exception:
continue
if any(m in text for m in bad_markers):
counts[str(p.relative_to(root).parts[0] if p.relative_to(root).parts else ".")] += 1
bad_files.append((str(p.relative_to(root)), text.count("users_george_repos_openspine")))
if len(bad_values) < 20:
bad_values.append((str(p.relative_to(root)), [line[:240] for line in text.splitlines() if "users_george_repos_openspine" in line][:2]))
print("generated_files_with_machine_fragments:", len(bad_files))
print("top_level_counts:", dict(counts))
for name, n in sorted(bad_files)[:100]:
print(f"{n:6d} {name}")
print("\n--- current dated graph references ---")
for p in sorted(root.glob("2026-08-07/*")):
if p.is_file():
text = p.read_text(errors="replace")
print(f"{p}: bad_id_occurrences={text.count('users_george_repos_openspine')}")
print("\n--- examples ---")
for name, lines in bad_values:
print(name)
for line in lines:
print(" ", line)
PY
printf '%s\n' '--- concise history for affected generated files ---'
git log --oneline -8 -- \
graphify-out/cache/ast/v0.9.10/033e11f4e89f596384e92e588a7fdf4c73a345b5e3fe762e156760392ccb513e.json \
graphify-out/2026-08-07/graph.json \
graphify-out/.graphify_rootRepository: George-RD/openspine
Length of output: 15727
Make Graphify node IDs repository-relative.
graphify-out contains checkout-specific IDs such as users_george_repos_openspine_..., although source_file values are relative. The issue affects 2,569 cache files and 11 graph.json files. Different checkout paths can produce different graph identities and expose local path data. Fix the ID generation, then run graphify update . to refresh all generated output. Do not edit generated files manually.
📍 Affects 7 files
graphify-out/cache/ast/v0.9.10/033e11f4e89f596384e92e588a7fdf4c73a345b5e3fe762e156760392ccb513e.json#L1-L1(this comment)graphify-out/cache/ast/v0.9.10/13e085e221dcc7979fca5b48489b1727b39a34daaab1e50dbbfdb0debc6fa11d.json#L1-L1graphify-out/cache/ast/v0.9.10/2f0c04e8a12bc10aa047a29ede661c03b27f183e2fef18507695c726f0750ace.json#L1-L1graphify-out/cache/ast/v0.9.10/5a49a5bfc5da439869c675432b2c75374bcacdaf1aa9e9e9d12421baeb2038bb.json#L1-L1graphify-out/cache/ast/v0.9.10/5f3b08d2d3129c85416def1fd7539ae21af4cc91ec5a05f64a02070b4cf81559.json#L1-L1graphify-out/cache/ast/v0.9.10/cd6a17f64b60a4a02bfa97472f28d93b65d0df974d0d05344fa00077be1e4a1e.json#L1-L1graphify-out/cache/ast/v0.9.10/cebab2dc4930a41c28629b44e0752f33dd20579598e83a5db3b6ec250f57c15b.json#L1-L1
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In
`@graphify-out/cache/ast/v0.9.10/033e11f4e89f596384e92e588a7fdf4c73a345b5e3fe762e156760392ccb513e.json`
at line 1, Update the Graphify node-ID generation to derive IDs from
repository-relative source paths rather than checkout-specific absolute paths,
preserving the existing relative source_file values. Apply this at the
ID-generation implementation, not in generated output; then run graphify update
. to regenerate all affected graphify-out/cache files and graph.json files. The
listed generated files require no direct edits.
Source: Path instructions
| @@ -0,0 +1 @@ | |||
| {"nodes": [{"id": "users_george_repos_openspine_openspec_changes_archive_2026_08_07_bound_dark_window_exceptions_proposal_md", "label": "proposal.md", "file_type": "document", "source_file": "openspec/changes/archive/2026-08-07-bound-dark-window-exceptions/proposal.md", "source_location": "L1"}, {"id": "users_george_repos_openspine_openspec_changes_archive_2026_08_07_bound_dark_window_exceptions_proposal_bound_dark_window_exceptions", "label": "Bound dark-window exceptions", "file_type": "document", "source_file": "openspec/changes/archive/2026-08-07-bound-dark-window-exceptions/proposal.md", "source_location": "L1"}, {"id": "users_george_repos_openspine_openspec_changes_archive_2026_08_07_bound_dark_window_exceptions_proposal_dependencies", "label": "Dependencies", "file_type": "document", "source_file": "openspec/changes/archive/2026-08-07-bound-dark-window-exceptions/proposal.md", "source_location": "L3"}, {"id": "users_george_repos_openspine_openspec_changes_archive_2026_08_07_bound_dark_window_exceptions_proposal_problem_context", "label": "Problem/Context", "file_type": "document", "source_file": "openspec/changes/archive/2026-08-07-bound-dark-window-exceptions/proposal.md", "source_location": "L11"}, {"id": "users_george_repos_openspine_openspec_changes_archive_2026_08_07_bound_dark_window_exceptions_proposal_proposed_solution", "label": "Proposed Solution", "file_type": "document", "source_file": "openspec/changes/archive/2026-08-07-bound-dark-window-exceptions/proposal.md", "source_location": "L38"}, {"id": "users_george_repos_openspine_openspec_changes_archive_2026_08_07_bound_dark_window_exceptions_proposal_acceptance_criteria", "label": "Acceptance Criteria", "file_type": "document", "source_file": "openspec/changes/archive/2026-08-07-bound-dark-window-exceptions/proposal.md", "source_location": "L52"}, {"id": "users_george_repos_openspine_openspec_changes_archive_2026_08_07_bound_dark_window_exceptions_proposal_invariant", "label": "Invariant", "file_type": "document", "source_file": "openspec/changes/archive/2026-08-07-bound-dark-window-exceptions/proposal.md", "source_location": "L64"}, {"id": "users_george_repos_openspine_openspec_changes_archive_2026_08_07_bound_dark_window_exceptions_proposal_out_of_scope", "label": "Out of Scope", "file_type": "document", "source_file": "openspec/changes/archive/2026-08-07-bound-dark-window-exceptions/proposal.md", "source_location": "L68"}], "edges": [{"source": "users_george_repos_openspine_openspec_changes_archive_2026_08_07_bound_dark_window_exceptions_proposal_md", "target": "users_george_repos_openspine_openspec_changes_archive_2026_08_07_bound_dark_window_exceptions_proposal_bound_dark_window_exceptions", "relation": "contains", "confidence": "EXTRACTED", "source_file": "openspec/changes/archive/2026-08-07-bound-dark-window-exceptions/proposal.md", "source_location": "L1", "weight": 1.0}, {"source": "users_george_repos_openspine_openspec_changes_archive_2026_08_07_bound_dark_window_exceptions_proposal_bound_dark_window_exceptions", "target": "users_george_repos_openspine_openspec_changes_archive_2026_08_07_bound_dark_window_exceptions_proposal_dependencies", "relation": "contains", "confidence": "EXTRACTED", "source_file": "openspec/changes/archive/2026-08-07-bound-dark-window-exceptions/proposal.md", "source_location": "L3", "weight": 1.0}, {"source": "users_george_repos_openspine_openspec_changes_archive_2026_08_07_bound_dark_window_exceptions_proposal_bound_dark_window_exceptions", "target": "users_george_repos_openspine_openspec_changes_archive_2026_08_07_bound_dark_window_exceptions_proposal_problem_context", "relation": "contains", "confidence": "EXTRACTED", "source_file": "openspec/changes/archive/2026-08-07-bound-dark-window-exceptions/proposal.md", "source_location": "L11", "weight": 1.0}, {"source": "users_george_repos_openspine_openspec_changes_archive_2026_08_07_bound_dark_window_exceptions_proposal_bound_dark_window_exceptions", "target": "users_george_repos_openspine_openspec_changes_archive_2026_08_07_bound_dark_window_exceptions_proposal_proposed_solution", "relation": "contains", "confidence": "EXTRACTED", "source_file": "openspec/changes/archive/2026-08-07-bound-dark-window-exceptions/proposal.md", "source_location": "L38", "weight": 1.0}, {"source": "users_george_repos_openspine_openspec_changes_archive_2026_08_07_bound_dark_window_exceptions_proposal_bound_dark_window_exceptions", "target": "users_george_repos_openspine_openspec_changes_archive_2026_08_07_bound_dark_window_exceptions_proposal_acceptance_criteria", "relation": "contains", "confidence": "EXTRACTED", "source_file": "openspec/changes/archive/2026-08-07-bound-dark-window-exceptions/proposal.md", "source_location": "L52", "weight": 1.0}, {"source": "users_george_repos_openspine_openspec_changes_archive_2026_08_07_bound_dark_window_exceptions_proposal_bound_dark_window_exceptions", "target": "users_george_repos_openspine_openspec_changes_archive_2026_08_07_bound_dark_window_exceptions_proposal_invariant", "relation": "contains", "confidence": "EXTRACTED", "source_file": "openspec/changes/archive/2026-08-07-bound-dark-window-exceptions/proposal.md", "source_location": "L64", "weight": 1.0}, {"source": "users_george_repos_openspine_openspec_changes_archive_2026_08_07_bound_dark_window_exceptions_proposal_bound_dark_window_exceptions", "target": "users_george_repos_openspine_openspec_changes_archive_2026_08_07_bound_dark_window_exceptions_proposal_out_of_scope", "relation": "contains", "confidence": "EXTRACTED", "source_file": "openspec/changes/archive/2026-08-07-bound-dark-window-exceptions/proposal.md", "source_location": "L68", "weight": 1.0}], "input_tokens": 0, "output_tokens": 0} No newline at end of file | |||
There was a problem hiding this comment.
🔒 Security & Privacy | 🟠 Major | 🏗️ Heavy lift
🧩 Analysis chain
🏁 Script executed:
#!/usr/bin/env bash
set -euo pipefail
python - <<'PY'
import json
import re
from pathlib import Path
host_prefix = re.compile(r"(?:^|_)(?:users|home|private|tmp)_[^_]+_")
for path in Path("graphify-out/cache/ast").rglob("*.json"):
payload = json.loads(path.read_text())
for node in payload.get("nodes", []):
node_id = node.get("id", "")
if host_prefix.search(node_id):
print(f"{path}: {node_id}")
PYRepository: George-RD/openspine
Length of output: 50376
🏁 Script executed:
#!/usr/bin/env bash
set -euo pipefail
printf '%s\n' '--- graphify-related tracked files ---'
git ls-files | rg -i '(^|/)(graphify|.*graph.*config|package\.json|pyproject\.toml|Cargo\.toml|README|.*\.ya?ml$|.*\.json$)' | head -200
printf '%s\n' '--- graphify configuration and ID-generation references ---'
rg -n -i --glob '!graphify-out/**' 'graphify|node.?id|source_file|source_file|repository-relative|relative path|absolute path|canonical' . | head -300
printf '%s\n' '--- cache summary ---'
python3 - <<'PY'
import json
from collections import Counter
from pathlib import Path
files = list(Path("graphify-out/cache/ast").rglob("*.json"))
node_count = 0
prefixes = Counter()
source_absolute = 0
for path in files:
data = json.loads(path.read_text())
for node in data.get("nodes", []):
node_count += 1
value = node.get("id", "")
parts = value.split("_")
if len(parts) >= 2 and parts[0] in {"users", "home", "private", "tmp"}:
prefixes["_".join(parts[:4])] += 1
source = node.get("source_file", "")
if source.startswith(("/", "~")):
source_absolute += 1
print("cache_files", len(files))
print("nodes", node_count)
print("absolute_source_file_values", source_absolute)
print("host_prefix_samples", prefixes.most_common(20))
PYRepository: George-RD/openspine
Length of output: 12655
🏁 Script executed:
#!/usr/bin/env bash
set -euo pipefail
printf '%s\n' '--- graphify-related tracked files ---'
git ls-files | rg -i '(^|/)(graphify|.*graph.*config|package\.json|pyproject\.toml|Cargo\.toml|README|.*\.ya?ml$|.*\.json$)' | head -200
printf '%s\n' '--- graphify configuration and ID-generation references ---'
rg -n -i --glob '!graphify-out/**' 'graphify|node.?id|source_file|repository-relative|relative path|absolute path|canonical' . | head -300
printf '%s\n' '--- cache summary ---'
python3 - <<'PY'
import json
from collections import Counter
from pathlib import Path
files = list(Path("graphify-out/cache/ast").rglob("*.json"))
node_count = 0
prefixes = Counter()
source_absolute = 0
for path in files:
data = json.loads(path.read_text())
for node in data.get("nodes", []):
node_count += 1
value = node.get("id", "")
parts = value.split("_")
if len(parts) >= 2 and parts[0] in {"users", "home", "private", "tmp"}:
prefixes["_".join(parts[:4])] += 1
source = node.get("source_file", "")
if source.startswith(("/", "~")):
source_absolute += 1
print("cache_files", len(files))
print("nodes", node_count)
print("absolute_source_file_values", source_absolute)
print("host_prefix_samples", prefixes.most_common(20))
PYRepository: George-RD/openspine
Length of output: 12655
🏁 Script executed:
#!/usr/bin/env bash
set -u
printf '%s\n' '--- graphify metadata ---'
for file in graphify-out/.graphify_python graphify-out/.graphify_root graphify-out/.graphify_labels.json; do
if [ -f "$file" ]; then
printf '%s\n' "--- $file"
sed -n '1,80p' "$file"
fi
done
printf '%s\n' '--- tracked graphify files outside generated output ---'
git ls-files | rg -i 'graphify' || true
printf '%s\n' '--- graphify references outside generated output ---'
rg -n -i --glob '!graphify-out/**' 'graphify|node.?id|source_file|repository-relative|absolute path|canonical' . || true
printf '%s\n' '--- AST cache identity summary ---'
python3 - <<'PY'
import json
from collections import Counter
from pathlib import Path
files = list(Path("graphify-out/cache/ast").rglob("*.json"))
node_count = 0
host_count = 0
source_absolute = 0
prefixes = Counter()
samples = []
for path in files:
data = json.loads(path.read_text())
for node in data.get("nodes", []):
node_count += 1
node_id = node.get("id", "")
parts = node_id.split("_")
if len(parts) >= 2 and parts[0] in {"users", "home", "private", "tmp"}:
host_count += 1
prefixes["_".join(parts[:4])] += 1
if len(samples) < 5:
samples.append((str(path), node_id))
source = node.get("source_file", "")
if source.startswith(("/", "~")):
source_absolute += 1
print("cache_files", len(files))
print("nodes", node_count)
print("host_prefixed_nodes", host_count)
print("absolute_source_file_values", source_absolute)
print("host_prefix_counts", prefixes.most_common(20))
print("samples")
for path, node_id in samples:
print(path, node_id)
PYRepository: George-RD/openspine
Length of output: 50376
🏁 Script executed:
#!/usr/bin/env bash
set -u
printf '%s\n' '--- graphify metadata ---'
for file in graphify-out/.graphify_python graphify-out/.graphify_root; do
if [ -f "$file" ]; then
printf '%s\n' "--- $file"
head -20 "$file"
fi
done
printf '%s\n' '--- tracked graphify files outside generated output ---'
git ls-files | rg -i '(^|/)graphify' | rg -v '^graphify-out/' || true
printf '%s\n' '--- graphify references outside generated output ---'
rg -n -i --glob '!graphify-out/**' 'graphify|node.?id|source_file|repository-relative|absolute path|canonical' . | head -100 || true
printf '%s\n' '--- AST cache identity summary ---'
python3 - <<'PY'
import json
from collections import Counter
from pathlib import Path
files = list(Path("graphify-out/cache/ast").rglob("*.json"))
node_count = 0
host_count = 0
source_absolute = 0
prefixes = Counter()
samples = []
for path in files:
data = json.loads(path.read_text())
for node in data.get("nodes", []):
node_count += 1
node_id = node.get("id", "")
parts = node_id.split("_")
if len(parts) >= 2 and parts[0] in {"users", "home", "private", "tmp"}:
host_count += 1
prefixes["_".join(parts[:4])] += 1
if len(samples) < 5:
samples.append((str(path), node_id))
source = node.get("source_file", "")
if source.startswith(("/", "~")):
source_absolute += 1
print("cache_files", len(files))
print("nodes", node_count)
print("host_prefixed_nodes", host_count)
print("absolute_source_file_values", source_absolute)
print("host_prefix_counts", prefixes.most_common(20))
for path, node_id in samples:
print("sample", path, node_id)
PYRepository: George-RD/openspine
Length of output: 19994
Remove host-specific prefixes from AST node IDs.
Graphify emits host-specific IDs in 54,371 of 68,582 AST nodes. Derive IDs from repository-relative paths, then run graphify update . to regenerate graphify-out/.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In
`@graphify-out/cache/ast/v0.9.10/e782ecb1ca4600262d6a04f14c13bf48b621b6be35f2e69a56019e184fef6dbf.json`
at line 1, Update the AST node ID generation used by Graphify to derive IDs from
repository-relative paths instead of host-specific absolute prefixes. Regenerate
all cached AST output by running graphify update . so every node, including the
affected document nodes and edges, uses the normalized IDs.
Source: Coding guidelines
Comment on lines
+123
to
+134
| - `bound-dark-window-exceptions` (D-159..D-162 — outstanding dark-window | ||
| exceptions are bounded per reviewed rule version by a validated | ||
| `max_pending_exceptions` counted inside the scheduling transaction, so | ||
| varying payload, grant, or chat can no longer turn exhausted quota into an | ||
| unbounded silence queue; the cap and the fired-token binding are keyed | ||
| separately, and a fired token revalidates its reviewed context; a fired | ||
| exception is accounted as an exception rather than quota and does not | ||
| refresh the lapse clock; every lifecycle change stales its open exceptions; | ||
| and dark-window `Allow` eligibility became an explicit empty catalog | ||
| allowlist enforced at activation and swept over stored rules, replacing a | ||
| classifier that permitted whatever it could not classify. Brief stays in | ||
| place — #130 and #131 depend on the bounded exception semantics) |
There was a problem hiding this comment.
🗄️ Data Integrity & Integration | 🟠 Major | ⚡ Quick win
Keep the change sequence limited to dependencies and decomposition.
Lines 123-134 and 595-612 duplicate normative requirement content. They also state that pause and compatibility changes stale pending exceptions. The canonical design excludes pause and handles reviewed-context or compatibility changes through consume-time rejection without a staleness write.
Keep only the dependency edges and archive-retention reason in this file. Move the detailed semantics to the capability specifications and align the summary with those specifications.
As per coding guidelines, openspec/openspine-change-sequence.md must remain limited to decomposition and dependency edges; requirement content belongs in the canon.
Also applies to: 595-612
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@openspec/openspine-change-sequence.md` around lines 123 - 134, Reduce the
entries around the change-sequence sections to dependency/decomposition edges
and the archive-retention rationale only. Remove duplicated normative details,
including claims that pause or compatibility changes stale pending exceptions,
and align the summary with the canonical capability specifications, where
reviewed-context or compatibility changes use consume-time rejection without a
staleness write.
Source: Coding guidelines
There was a problem hiding this comment.
Caution
Inline review comments failed to post. This is likely due to GitHub's internal server error or limits when posting large numbers of comments. If you are seeing this consistently it is likely a permissions issue. Please check "Moderation" -> "Code review limits" under your organization settings.
Actionable comments posted: 8
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@graphify-out/2026-08-07/GRAPH_REPORT.md`:
- Line 4773: Fix the generator or source producing the D-004 decision text so
its inline-code delimiters do not nest: use one code span for the complete
decision text or leave gate() as plain text. Regenerate both affected outputs
with graphify update .: graphify-out/2026-08-07/GRAPH_REPORT.md lines 4773-4773
and graphify-out/GRAPH_REPORT.md lines 4817-4817; do not edit generated reports
manually.
In
`@graphify-out/cache/ast/v0.9.10/033e11f4e89f596384e92e588a7fdf4c73a345b5e3fe762e156760392ccb513e.json`:
- Line 1: Update the Graphify node-ID generation to derive IDs from
repository-relative source paths rather than checkout-specific absolute paths,
preserving the existing relative source_file values. Apply this at the
ID-generation implementation, not in generated output; then run graphify update
. to regenerate all affected graphify-out/cache files and graph.json files. The
listed generated files require no direct edits.
In
`@graphify-out/cache/ast/v0.9.10/e782ecb1ca4600262d6a04f14c13bf48b621b6be35f2e69a56019e184fef6dbf.json`:
- Line 1: Update the AST node ID generation used by Graphify to derive IDs from
repository-relative paths instead of host-specific absolute prefixes. Regenerate
all cached AST output by running graphify update . so every node, including the
affected document nodes and edges, uses the normalized IDs.
In `@openspec/changes/archive/2026-08-07-bound-dark-window-exceptions/design.md`:
- Line 23: Label the pseudocode Markdown fence in
openspec/changes/archive/2026-08-07-bound-dark-window-exceptions/design.md at
lines 23-23 with an appropriate language identifier, and label both pseudocode
fences in
openspec/changes/archive/2026-08-07-bound-dark-window-exceptions/proposal.md at
lines 15-29; leave the fenced content unchanged.
- Around line 53-57: The notification bound currently implies a cumulative
limit, but max_pending_exceptions only limits unresolved exceptions. In
openspec/changes/archive/2026-08-07-bound-dark-window-exceptions/design.md lines
53-57, narrow the claim to concurrent or outstanding notifications, or add an
explicit lifetime, rate, or aggregation control; in
openspec/changes/archive/2026-08-07-bound-dark-window-exceptions/proposal.md
lines 64-74, likewise narrow the invariant and notification claim to outstanding
exceptions. Ensure both documents consistently describe the actual bound.
In
`@openspec/changes/archive/2026-08-07-bound-dark-window-exceptions/specs/standing-rules/spec.md`:
- Around line 96-99: Replace “idempotent per rule” with “idempotent per stable
request identity within a rule version” in the archived standing-rules
specification at
openspec/changes/archive/2026-08-07-bound-dark-window-exceptions/specs/standing-rules/spec.md
lines 96-99 and apply the same wording in the canonical specification at
openspec/specs/standing-rules/spec.md lines 69-71; make no other changes.
- Around line 61-63: Extend the lifecycle invalidation requirement to cover
startup recovery of stored invalid Allow rules: retire the rule, stale all
unresolved pending exceptions, and record durable evidence atomically. Apply
this to
openspec/changes/archive/2026-08-07-bound-dark-window-exceptions/specs/standing-rules/spec.md:61-63
and openspec/specs/standing-rules/spec.md:331-333; add the corresponding
startup-retirement acceptance scenario in
openspec/changes/archive/2026-08-07-bound-dark-window-exceptions/proposal.md:52-62
and implementation plus boundary-test tasks in
openspec/changes/archive/2026-08-07-bound-dark-window-exceptions/tasks.md:41-58.
In `@openspec/openspine-change-sequence.md`:
- Around line 123-134: Reduce the entries around the change-sequence sections to
dependency/decomposition edges and the archive-retention rationale only. Remove
duplicated normative details, including claims that pause or compatibility
changes stale pending exceptions, and align the summary with the canonical
capability specifications, where reviewed-context or compatibility changes use
consume-time rejection without a staleness write.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: c435e235-53c2-4847-898b-fcaf192b66cc
📒 Files selected for processing (25)
graphify-out/.graphify_labels.jsongraphify-out/2026-08-07/.graphify_labels.jsongraphify-out/2026-08-07/GRAPH_REPORT.mdgraphify-out/2026-08-07/graph.jsongraphify-out/2026-08-07/manifest.jsongraphify-out/GRAPH_REPORT.mdgraphify-out/cache/ast/v0.9.10/033e11f4e89f596384e92e588a7fdf4c73a345b5e3fe762e156760392ccb513e.jsongraphify-out/cache/ast/v0.9.10/13e085e221dcc7979fca5b48489b1727b39a34daaab1e50dbbfdb0debc6fa11d.jsongraphify-out/cache/ast/v0.9.10/2f0c04e8a12bc10aa047a29ede661c03b27f183e2fef18507695c726f0750ace.jsongraphify-out/cache/ast/v0.9.10/5a49a5bfc5da439869c675432b2c75374bcacdaf1aa9e9e9d12421baeb2038bb.jsongraphify-out/cache/ast/v0.9.10/5f3b08d2d3129c85416def1fd7539ae21af4cc91ec5a05f64a02070b4cf81559.jsongraphify-out/cache/ast/v0.9.10/cd6a17f64b60a4a02bfa97472f28d93b65d0df974d0d05344fa00077be1e4a1e.jsongraphify-out/cache/ast/v0.9.10/cebab2dc4930a41c28629b44e0752f33dd20579598e83a5db3b6ec250f57c15b.jsongraphify-out/cache/ast/v0.9.10/e782ecb1ca4600262d6a04f14c13bf48b621b6be35f2e69a56019e184fef6dbf.jsongraphify-out/cache/stat-index.jsongraphify-out/graph.jsongraphify-out/manifest.jsonopenspec/changes/archive/2026-08-07-bound-dark-window-exceptions/design.mdopenspec/changes/archive/2026-08-07-bound-dark-window-exceptions/proposal.mdopenspec/changes/archive/2026-08-07-bound-dark-window-exceptions/specs/responsibility-contract/spec.mdopenspec/changes/archive/2026-08-07-bound-dark-window-exceptions/specs/standing-rules/spec.mdopenspec/changes/archive/2026-08-07-bound-dark-window-exceptions/tasks.mdopenspec/openspine-change-sequence.mdopenspec/specs/responsibility-contract/spec.mdopenspec/specs/standing-rules/spec.md
🛑 Comments failed to post (4)
openspec/changes/archive/2026-08-07-bound-dark-window-exceptions/design.md (2)
23-23: 📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win
Add languages to all Markdown fences.
openspec/changes/archive/2026-08-07-bound-dark-window-exceptions/design.md#L23-L23: label the pseudocode fence.openspec/changes/archive/2026-08-07-bound-dark-window-exceptions/proposal.md#L15-L29: label both pseudocode fences.🧰 Tools
🪛 markdownlint-cli2 (0.23.2)
[warning] 23-23: Fenced code blocks should have a language specified
(MD040, fenced-code-language)
📍 Affects 2 files
openspec/changes/archive/2026-08-07-bound-dark-window-exceptions/design.md#L23-L23(this comment)openspec/changes/archive/2026-08-07-bound-dark-window-exceptions/proposal.md#L15-L29🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@openspec/changes/archive/2026-08-07-bound-dark-window-exceptions/design.md` at line 23, Label the pseudocode Markdown fence in openspec/changes/archive/2026-08-07-bound-dark-window-exceptions/design.md at lines 23-23 with an appropriate language identifier, and label both pseudocode fences in openspec/changes/archive/2026-08-07-bound-dark-window-exceptions/proposal.md at lines 15-29; leave the fenced content unchanged.Source: Linters/SAST tools
53-57: 🚀 Performance & Scalability | 🟠 Major | 🏗️ Heavy lift
The pending cap bounds only concurrently unresolved rows.
After a row resolves, the slot becomes available. A worker can then create another exception and notification. These documents must either add a cumulative control or state only a concurrent/outstanding bound.
openspec/changes/archive/2026-08-07-bound-dark-window-exceptions/design.md#L53-L57: narrow the notification claim to concurrent notifications or add a lifetime/rate/aggregation limit.openspec/changes/archive/2026-08-07-bound-dark-window-exceptions/proposal.md#L64-L74: narrow the invariant and notification claim to outstanding exceptions.📍 Affects 2 files
openspec/changes/archive/2026-08-07-bound-dark-window-exceptions/design.md#L53-L57(this comment)openspec/changes/archive/2026-08-07-bound-dark-window-exceptions/proposal.md#L64-L74🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@openspec/changes/archive/2026-08-07-bound-dark-window-exceptions/design.md` around lines 53 - 57, The notification bound currently implies a cumulative limit, but max_pending_exceptions only limits unresolved exceptions. In openspec/changes/archive/2026-08-07-bound-dark-window-exceptions/design.md lines 53-57, narrow the claim to concurrent or outstanding notifications, or add an explicit lifetime, rate, or aggregation control; in openspec/changes/archive/2026-08-07-bound-dark-window-exceptions/proposal.md lines 64-74, likewise narrow the invariant and notification claim to outstanding exceptions. Ensure both documents consistently describe the actual bound.openspec/changes/archive/2026-08-07-bound-dark-window-exceptions/specs/standing-rules/spec.md (2)
61-63: 🔒 Security & Privacy | 🟠 Major | ⚡ Quick win
Cover stored invalid
Allowrules during startup recovery.The responsibility contract requires retirement, exception staling, and durable evidence when the kernel opens such data. The standing-rules specifications and acceptance tasks do not fully carry this transition.
openspec/changes/archive/2026-08-07-bound-dark-window-exceptions/specs/standing-rules/spec.md#L61-L63: add the startup sweep to lifecycle invalidation.openspec/specs/standing-rules/spec.md#L331-L333: add the same transition to the canonical requirement.openspec/changes/archive/2026-08-07-bound-dark-window-exceptions/proposal.md#L52-L62: add an acceptance scenario for startup retirement.openspec/changes/archive/2026-08-07-bound-dark-window-exceptions/tasks.md#L41-L58: add implementation and boundary-test tasks.🧰 Tools
🪛 LanguageTool
[grammar] ~61-~61: Ensure spelling is correct
Context: ... Pending dark-window exceptions MUST be staled by every lifecycle change Revocation, ...(QB_NEW_EN_ORTHOGRAPHY_ERROR_IDS_1)
📍 Affects 4 files
openspec/changes/archive/2026-08-07-bound-dark-window-exceptions/specs/standing-rules/spec.md#L61-L63(this comment)openspec/specs/standing-rules/spec.md#L331-L333openspec/changes/archive/2026-08-07-bound-dark-window-exceptions/proposal.md#L52-L62openspec/changes/archive/2026-08-07-bound-dark-window-exceptions/tasks.md#L41-L58🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@openspec/changes/archive/2026-08-07-bound-dark-window-exceptions/specs/standing-rules/spec.md` around lines 61 - 63, Extend the lifecycle invalidation requirement to cover startup recovery of stored invalid Allow rules: retire the rule, stale all unresolved pending exceptions, and record durable evidence atomically. Apply this to openspec/changes/archive/2026-08-07-bound-dark-window-exceptions/specs/standing-rules/spec.md:61-63 and openspec/specs/standing-rules/spec.md:331-333; add the corresponding startup-retirement acceptance scenario in openspec/changes/archive/2026-08-07-bound-dark-window-exceptions/proposal.md:52-62 and implementation plus boundary-test tasks in openspec/changes/archive/2026-08-07-bound-dark-window-exceptions/tasks.md:41-58.
96-99: 🗄️ Data Integrity & Integration | 🟠 Major | ⚡ Quick win
Define idempotency by stable request identity, not by rule.
Rule-wide idempotency conflicts with the separate request identity used for token binding and terminal-row deduplication.
openspec/changes/archive/2026-08-07-bound-dark-window-exceptions/specs/standing-rules/spec.md#L96-L99: replace “idempotent per rule” with “idempotent per stable request identity within a rule version.”openspec/specs/standing-rules/spec.md#L69-L71: apply the same wording in the canonical specification.📍 Affects 2 files
openspec/changes/archive/2026-08-07-bound-dark-window-exceptions/specs/standing-rules/spec.md#L96-L99(this comment)openspec/specs/standing-rules/spec.md#L69-L71🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@openspec/changes/archive/2026-08-07-bound-dark-window-exceptions/specs/standing-rules/spec.md` around lines 96 - 99, Replace “idempotent per rule” with “idempotent per stable request identity within a rule version” in the archived standing-rules specification at openspec/changes/archive/2026-08-07-bound-dark-window-exceptions/specs/standing-rules/spec.md lines 96-99 and apply the same wording in the canonical specification at openspec/specs/standing-rules/spec.md lines 69-71; make no other changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Applies the change's deltas into the two capability specs and moves the
brief to
openspec/changes/archive/2026-08-07-bound-dark-window-exceptions/.Spec updates: responsibility-contract (~1), standing-rules (+3 ~2).
openspec validate --all --strictpasses (45 items). The two MODIFIEDstanding-rules bodies were checked to be supersets of their pre-archive
baselines, so no landed #127/#128 documentation was reverted by the
wholesale requirement replacement archive performs.
The brief stays in place: #130 and #131 depend on the bounded exception
semantics.
Summary by cubic
Archived the bound-dark-window-exceptions change and folded its requirements into the live specs. This caps pending dark-window exceptions per reviewed rule version and tightens activation and review behavior.
openspec/changes/archive/2026-08-07-bound-dark-window-exceptions/.openspec validate --all --strictpasses.Written for commit 4c29e0b. Summary will update on new commits.